mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Cole Leavitt <cole@unwrap.rs>
To: vkoul@kernel.org, yung-chuan.liao@linux.intel.com
Cc: pierre-louis.bossart@linux.dev, david.rhodes@cirrus.com,
	rf@opensource.cirrus.com, lgirdwood@gmail.com,
	broonie@kernel.org, perex@perex.cz, tiwai@suse.com,
	linux-sound@vger.kernel.org, patches@opensource.cirrus.com,
	linux-kernel@vger.kernel.org, cole@unwrap.rs
Subject: [PATCH 0/2] soundwire: suppress expected unattach warnings during codec reset
Date: Tue, 17 Feb 2026 16:35:31 -0700	[thread overview]
Message-ID: <20260217233533.4716-1-cole@unwrap.rs> (raw)

On systems with CS35L56 SoundWire codecs (e.g. Lenovo ThinkPad P16
Gen3), every boot produces misleading dev_warn() messages:

  cs35l56 sdw:0:2:01fa:3556:01:0: Slave 2 state check1: UNATTACHED, status was 1
  cs35l56 sdw:0:2:01fa:3556:01:1: Slave 1 state check1: UNATTACHED, status was 1

These fire when the CS35L56 driver triggers a system reset after
firmware download, which physically detaches the codec from the bus.
This is expected and handled gracefully -- the driver waits for
re-enumeration and the codec recovers within milliseconds.

The warnings were added in commit d1b328557058 ("soundwire: bus: add
dev_warn() messages to track UNATTACHED devices") to debug genuine
attachment failures. They remain valuable for unexpected detachments,
but firing on every boot for normal codec operation degrades their
diagnostic value.

This series adds a simple boolean flag (unattach_pending) to struct
sdw_slave that codec drivers can set before triggering an expected
detach. When set, the bus layer emits dev_dbg() instead of dev_warn()
and auto-clears the flag.

Note: There is also a separate set of UNATTACHED warnings during
initial multi-device enumeration, caused by the known PING frame race
documented in cadence_master.c. That is a different problem with
different constraints and is not addressed here.

Cole Leavitt (2):
  soundwire: bus: downgrade expected unattach warnings to dev_dbg
  ASoC: cs35l56: set unattach_pending before SoundWire system reset

 drivers/soundwire/bus.c       | 9 +++++++--
 include/linux/soundwire/sdw.h | 1 +
 sound/soc/codecs/cs35l56.c    | 4 ++++
 3 files changed, 12 insertions(+), 2 deletions(-)

-- 
2.52.0


             reply	other threads:[~2026-02-17 23:35 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-17 23:35 Cole Leavitt [this message]
2026-02-17 23:35 ` [PATCH 1/2] soundwire: bus: downgrade expected unattach warnings to dev_dbg Cole Leavitt
2026-02-17 23:35 ` [PATCH 2/2] ASoC: cs35l56: set unattach_pending before SoundWire system reset Cole Leavitt
2026-02-18 10:14 ` [PATCH 0/2] soundwire: suppress expected unattach warnings during codec reset Richard Fitzgerald
2026-02-18 10:50   ` Pierre-Louis Bossart
2026-02-18 11:01     ` Richard Fitzgerald
2026-02-18 12:49     ` Charles Keepax
2026-02-18 13:55 ` [PATCH v2] soundwire: bus: demote UNATTACHED slave warnings to dev_dbg Cole Leavitt
2026-02-18 14:00 ` [PATCH v3] " Cole Leavitt
2026-02-18 16:52   ` Pierre-Louis Bossart
2026-02-18 18:02 ` [PATCH v4] soundwire: bus: demote UNATTACHED state warnings to dev_dbg() Cole Leavitt
2026-02-23 15:20   ` Richard Fitzgerald
2026-03-09  7:05 ` [PATCH 0/2] soundwire: suppress expected unattach warnings during codec reset Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260217233533.4716-1-cole@unwrap.rs \
    --to=cole@unwrap.rs \
    --cc=broonie@kernel.org \
    --cc=david.rhodes@cirrus.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=patches@opensource.cirrus.com \
    --cc=perex@perex.cz \
    --cc=pierre-louis.bossart@linux.dev \
    --cc=rf@opensource.cirrus.com \
    --cc=tiwai@suse.com \
    --cc=vkoul@kernel.org \
    --cc=yung-chuan.liao@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®