mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Armin Wolf <W_Armin@gmx.de>
To: hansg@kernel.org, ilpo.jarvinen@linux.intel.com
Cc: wse@tuxedocomputers.com, platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH v4 0/4] uniwill-laptop: Input-related improvements
Date: Wed, 18 Feb 2026 01:50:57 +0100	[thread overview]
Message-ID: <20260218005101.73680-1-W_Armin@gmx.de> (raw)

This patch series contains a set of input-related improvements
for the uniwill-laptop driver. The first patch renames the
"fn_lock_toggle_enable" and "super_key_toggle_enable" sysfs attributes
after it was discovered that the underlying hardware works differently
than previously thought. This technically breaks user space
applications using those sysfs attributes, but AFAIK no such users
currently exist.

The next two patches fix a potential crash and an issue with the fn
lock status not being updated when using a key combination. The
remaining patch ensurea that when the users changes the fn lock
status using a key combination, a poll notification is being issued
on the appropriate sysfs attr.

Tested on a TUXEDO InfinityBook Pro 15 Gen 10 AMD (whitelist entry
comes next).

Changes since v3:
- drop last patch, because it turned out that all super key events
  are also send by the EC when the super key is enabled/disabled
  using the sysfs attribute

Changes since v2:
- rename UNIWILL_OSD_SUPER_KEY_LOCK_CHANGED
- do no use UNIWILL_OSD_SUPER_KEY_LOCK_ENABLE and
  UNIWILL_OSD_SUPER_KEY_LOCK_DISABLE events for triggering
  the poll notification

Changes since v1:
- update admin-guide for uniwill laptops
- rename UNIWILL_OSD_SUPER_KEY_LOCK_ENABLE and
  UNIWILL_OSD_SUPER_KEY_LOCK_DISABLE
- fix small issue in commit description of patch 5

Armin Wolf (4):
  platform/x86: uniwill-laptop: Rename FN lock and super key lock attrs
  platform/x86: uniwill-laptop: Fix crash on unexpected battery event
  platform/x86: uniwill-laptop: Mark FN lock status as being volatile
  platform/x86: uniwill-laptop: Handle FN lock event

 .../ABI/testing/sysfs-driver-uniwill-laptop   |  10 +-
 .../admin-guide/laptops/uniwill-laptop.rst    |   2 +-
 drivers/platform/x86/uniwill/uniwill-acpi.c   | 110 ++++++++++++------
 drivers/platform/x86/uniwill/uniwill-wmi.h    |   6 +-
 4 files changed, 84 insertions(+), 44 deletions(-)

-- 
2.39.5


             reply	other threads:[~2026-02-18  0:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-18  0:50 Armin Wolf [this message]
2026-02-18  0:50 ` [PATCH v4 1/4] platform/x86: uniwill-laptop: Rename FN lock and super key lock attrs Armin Wolf
2026-02-18  0:50 ` [PATCH v4 2/4] platform/x86: uniwill-laptop: Fix crash on unexpected battery event Armin Wolf
2026-02-18  0:51 ` [PATCH v4 3/4] platform/x86: uniwill-laptop: Mark FN lock status as being volatile Armin Wolf
2026-02-18  0:51 ` [PATCH v4 4/4] platform/x86: uniwill-laptop: Handle FN lock event Armin Wolf
2026-02-23 16:35 ` [PATCH v4 0/4] uniwill-laptop: Input-related improvements Ilpo Järvinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260218005101.73680-1-W_Armin@gmx.de \
    --to=w_armin@gmx.de \
    --cc=hansg@kernel.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=wse@tuxedocomputers.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®