From: Franz Schnyder <fra.schnyder@gmail.com>
To: Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>
Cc: Franz Schnyder <franz.schnyder@toradex.com>,
linux-kernel@vger.kernel.org,
Francesco Dolcini <francesco@dolcini.it>,
stable@vger.kernel.org
Subject: [PATCH v1 1/2] regulator: pf9453: Respect IRQ trigger settings from firmware
Date: Wed, 18 Feb 2026 11:25:14 +0100 [thread overview]
Message-ID: <20260218102518.238943-2-fra.schnyder@gmail.com> (raw)
In-Reply-To: <20260218102518.238943-1-fra.schnyder@gmail.com>
From: Franz Schnyder <franz.schnyder@toradex.com>
The datasheet specifies, that the IRQ_B pin is pulled low when any
unmasked interrupt bit status is changed, and it is released high once
the application processor reads the INT1 register. As it specifies a
level-low behavior, it should not force a falling-edge interrupt.
Remove the IRQF_TRIGGER_FALLING to not force the falling-edge interrupt
and instead rely on the flag from the device tree.
Fixes: 0959b6706325 ("regulator: pf9453: add PMIC PF9453 support")
Cc: stable@vger.kernel.org
Signed-off-by: Franz Schnyder <franz.schnyder@toradex.com>
---
drivers/regulator/pf9453-regulator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/pf9453-regulator.c b/drivers/regulator/pf9453-regulator.c
index 779a6fdb0574..eed3055d1c1c 100644
--- a/drivers/regulator/pf9453-regulator.c
+++ b/drivers/regulator/pf9453-regulator.c
@@ -809,7 +809,7 @@ static int pf9453_i2c_probe(struct i2c_client *i2c)
}
ret = devm_request_threaded_irq(pf9453->dev, pf9453->irq, NULL, pf9453_irq_handler,
- (IRQF_TRIGGER_FALLING | IRQF_ONESHOT),
+ IRQF_ONESHOT,
"pf9453-irq", pf9453);
if (ret)
return dev_err_probe(pf9453->dev, ret, "Failed to request IRQ: %d\n", pf9453->irq);
--
2.43.0
next prev parent reply other threads:[~2026-02-18 10:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-18 10:25 [PATCH v1 0/2] regulator: pf9453: Fix IRQ trigger and allow sharing Franz Schnyder
2026-02-18 10:25 ` Franz Schnyder [this message]
2026-02-18 10:25 ` [PATCH v1 2/2] regulator: pf9453: Allow shared IRQ Franz Schnyder
2026-03-02 0:25 ` Mark Brown
2026-03-03 11:20 ` [PATCH v1 0/2] regulator: pf9453: Fix IRQ trigger and allow sharing Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260218102518.238943-2-fra.schnyder@gmail.com \
--to=fra.schnyder@gmail.com \
--cc=broonie@kernel.org \
--cc=francesco@dolcini.it \
--cc=franz.schnyder@toradex.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®