From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.unwrap.rs (mail.unwrap.rs [172.232.15.166]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1828D328B40; Wed, 18 Feb 2026 13:55:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=172.232.15.166 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771422925; cv=none; b=juGkMMomrFZFaa+RQuANkwLrp1qt5rSVTKzq6udW7uwkYiZIHzEXj4XRhSpNaBhcKtIg00KEDihzYA7UQuXVoeBMN4u4Fen+qrIyOwhlqebBGV8DA/M9F2vtWtdbu1C5LnyEE5W5AYpAlWj6tmEI12EQXgFPN1TosG0AdQkS/Ek= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771422925; c=relaxed/simple; bh=w3YNPP20ZeLgRL62e0LsUyiDC0Gz2gu+cEDFwnI2P+A=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Op3d7eBSHzrdXGr8incFAAdungeZnOAg56O2DE+UXrAX94JvxE/XytwmK2uvEVQ3n0CWNODHSAFg0z8JoLPA8xLjrroQjTqWVrlgOjbEUkXDCzwWAqcM6v9w+wItqOGKLhRqkH/62Fgd4bm8YLMRd6Lqj6CUdJEE5CQ/dvpn8mM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=unwrap.rs; spf=pass smtp.mailfrom=unwrap.rs; arc=none smtp.client-ip=172.232.15.166 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=unwrap.rs Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=unwrap.rs From: Cole Leavitt To: Vinod Koul , Bard Liao Cc: Pierre-Louis Bossart , Richard Fitzgerald , Charles Keepax , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, Cole Leavitt Subject: [PATCH v2] soundwire: bus: demote UNATTACHED slave warnings to dev_dbg Date: Wed, 18 Feb 2026 06:55:12 -0700 Message-ID: <20260218135512.20838-1-cole@unwrap.rs> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260217233533.4716-1-cole@unwrap.rs> References: <20260217233533.4716-1-cole@unwrap.rs> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The dev_warn() messages in sdw_handle_slave_status() for UNATTACHED transitions were added in commit d1b328557058 ("soundwire: bus: add dev_warn() messages to track UNATTACHED devices") to debug attachment failures with dynamic debug enabled. These warnings fire during normal operation -- for example when a codec driver triggers a system reset after firmware download, or during initial multi-device enumeration due to the PING frame race documented in cadence_master.c -- producing misleading noise on every boot. The original debugging use case is fully served by dev_dbg(), which remains visible when dynamic debug is enabled. Demote both state check warnings to dev_dbg(). Signed-off-by: Cole Leavitt --- drivers/soundwire/bus.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c index fb68738dfb9b..45234cc07f35 100644 --- a/drivers/soundwire/bus.c +++ b/drivers/soundwire/bus.c @@ -1899,8 +1899,8 @@ int sdw_handle_slave_status(struct sdw_bus *bus, if (status[i] == SDW_SLAVE_UNATTACHED && slave->status != SDW_SLAVE_UNATTACHED) { - dev_warn(&slave->dev, "Slave %d state check1: UNATTACHED, status was %d\n", - i, slave->status); + dev_dbg(&slave->dev, "Slave %d state check1: UNATTACHED, status was %d\n", + i, slave->status); sdw_modify_slave_status(slave, SDW_SLAVE_UNATTACHED); /* Ensure driver knows that peripheral unattached */ @@ -1951,8 +1951,8 @@ int sdw_handle_slave_status(struct sdw_bus *bus, if (slave->status == SDW_SLAVE_UNATTACHED) break; - dev_warn(&slave->dev, "Slave %d state check2: UNATTACHED, status was %d\n", - i, slave->status); + dev_dbg(&slave->dev, "Slave %d state check2: UNATTACHED, status was %d\n", + i, slave->status); sdw_modify_slave_status(slave, SDW_SLAVE_UNATTACHED); break; -- 2.52.0