From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4C4D1684B0 for ; Thu, 19 Feb 2026 09:16:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771492605; cv=none; b=GuD9dteCxSBa/dS33nzUcKSAep8r5f6Emwrj6QAcrJgbSch4gEGrMzogVofozBtxayA/mwWPKKD5+XqkH5D0VYb7ffw+7LArb1Rl6R+Ouhip+U3zloHtsWnpbgqBju4hM0Zg2eInXPxSeSEvxvUENbR18MjC/1+LVyypMWnBbp8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771492605; c=relaxed/simple; bh=aEyWs1Zvn9OJBYISRKRqEdGU3qAi+EDqYLdy0wsyuVA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UhIzIl0p+Ex1NDoN0D0FasfxEXmO6FUcmbUdhiTR6pU1KgKoHICOIGbtvgJZDSk9dok927JvS4P8QKg2wPRcjjbHS4coV0zr2m6UvEz4RrXft986S+466PDz8BNPnXV/2vNRChNFn3m3eX1JmivIs0o5LaRzJXN+EzHaUbmRgTM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=JhZY9M53; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=KN5g58Xd; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="JhZY9M53"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="KN5g58Xd" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1771492602; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FvCQKIeQDulHEvNvZG4/Rs7O2SMt0AI9xdkS+RkTuNc=; b=JhZY9M531T8czRiInT97GVBotBybPRy7SrPLtErUizDPiAOXGpzzrVJC/xBQ2k/RY5jcpe CBT4mrAUlqNg/zYvYwlWRhdk4vJ/OVGxSkOpSp/rlSao4zSx3c8SLEsIaBh1p7i5uJ2n5O w9BadVN9XS+RwLGUHYJyav/Rq26n1N8= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-575-eVkeE3pDORiTYRSqCbRx9w-1; Thu, 19 Feb 2026 04:16:40 -0500 X-MC-Unique: eVkeE3pDORiTYRSqCbRx9w-1 X-Mimecast-MFC-AGG-ID: eVkeE3pDORiTYRSqCbRx9w_1771492600 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-482d8e6e13aso4808415e9.3 for ; Thu, 19 Feb 2026 01:16:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1771492600; x=1772097400; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=FvCQKIeQDulHEvNvZG4/Rs7O2SMt0AI9xdkS+RkTuNc=; b=KN5g58XdCaGHiKPmJ/NGudUiRrESmzZaMOV/jXZ8x6aymgjeiHsfDrCud/ZW+zwl+S gRVe4yHtRWQRqXYZS8Jwtgz2CrdbutF0EkD/nq1MXB46PipcWEyP5waQFHIe1d2XsHXn jEoxtTA17L68VM7A7oRA/t5RApeHxiUMyIf7j9axD1WTfMcYsiFsw9NPPkMdfgHL2F8Z vANmqarRKAJwPI27Q33JCUWpGkEj9WfEzX6fnWWHNBhkXPaTHk3VJTbulDco5K8hLwjm HYuCrmtBvHXmHx5QIxIvJWeT44ZjikrCIS7fTNH4y4bv9w01wmGBrhCWSttNxzS5cJ+L 5fbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771492600; x=1772097400; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FvCQKIeQDulHEvNvZG4/Rs7O2SMt0AI9xdkS+RkTuNc=; b=QwgJiM0lE3yE82+tcaHeDG2JU9d//7GE0TiC6crPq9WEtw2FXNVmHougiPRlYdGzof t7zDCKX+FA6kIayg5tb2QJx28SPZ0DiAjnlx36jdabFYKlO1MYPJFv6/lQ5+5zsaQ11t pkcijm5wp4ZuGqApjvXbPo2sk5aMxBV0AANUJX+6jryrEnk1SG2edlO8JENgG2HzehW8 BHc9a0L6ntFcrdhKN9i5NyQKhQu/5QsPSQMf18yfBlUTN5muA0/48gXOIuLu15Zs6oCO xijThrN+Mx6ipxrEB8J0tQ1i5ak1o+i1iTb24nDmdyUHJfyzDp3mulyukFK2tlbaryz6 05Mg== X-Forwarded-Encrypted: i=1; AJvYcCXY11P717rORDJLz4XPSDNGyNBzpZRQr8Bn/z/Q9I/HOUrXuMPk0ZiObK2hkq+onvn01jYLW13nS4tvhhE=@vger.kernel.org X-Gm-Message-State: AOJu0Yy8OK/Q1p0NocQjxsQDAhklYVu3J1Yle1BHhHvFqd3pmn5zxIgx CcIf8lyc0LtU4vfoOiehhAd8GPcGf2d69/SHB+7ELNXI4WDEUU2tgAib+qSvQhZMfmH2kpfiplW EbIvj2nY5O13rIb1rlajDwUqcoYusFcjBkrOSSqrg8DBpREMyymJZRvBgrrd0F4usiw== X-Gm-Gg: AZuq6aIyavBpDkD0WrIpxKpvdgEI7NHniXeFgWvPkguXmbgCji0Y4TfaxVWAXrnjDLM 0OfgZK/BJMcqjm08vQuy8EicTUl0uX6RpQq+nuyEErdWg/W8B2e0V24urlwJ1Nw/KFA5Ut6aLq+ cOCgflCI98n+Ma0lWOwXusGQ8NIA3wzcN/OYl10c41slaach7Wa12qXsEh7Gbh63RB/hnFR3ZoX K32ahX+BH9IhuGLvSf2ysVR0BSda5XUngSw6RLOpficI6tYBMGhJ2dGWCoOreNlFkbIOOylIx+3 Ed7L9Ir7gysxd0WinXQAX4wvoNAsygcBkyX9GKpt1ZxfMuQf8KqAtAts1fQuofgsRWuffvmyEw= = X-Received: by 2002:a05:600c:8289:b0:479:3a89:121d with SMTP id 5b1f17b1804b1-4839e66fc83mr23233395e9.36.1771492599587; Thu, 19 Feb 2026 01:16:39 -0800 (PST) X-Received: by 2002:a05:600c:8289:b0:479:3a89:121d with SMTP id 5b1f17b1804b1-4839e66fc83mr23232985e9.36.1771492599016; Thu, 19 Feb 2026 01:16:39 -0800 (PST) Received: from localhost ([2a01:e0a:b25:f902::ff]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4839ea1e7e1sm14492695e9.2.2026.02.19.01.16.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Feb 2026 01:16:38 -0800 (PST) Date: Thu, 19 Feb 2026 10:16:37 +0100 From: Maxime Ripard To: Eric Chanudet Cc: Sumit Semwal , Benjamin Gaignard , Brian Starkey , John Stultz , "T.J. Mercier" , Christian =?utf-8?B?S8O2bmln?= , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org, Albert Esteve , linux-mm@kvack.org Subject: Re: [PATCH v2 3/3] dma-buf: heaps: cma: charge each cma heap's dmem Message-ID: <20260219-illustrious-tungsten-starfish-5dad8c@houat> References: <20260218-dmabuf-heap-cma-dmem-v2-0-b249886fb7b2@redhat.com> <20260218-dmabuf-heap-cma-dmem-v2-3-b249886fb7b2@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha384; protocol="application/pgp-signature"; boundary="qbjavhllvvchwpql" Content-Disposition: inline In-Reply-To: <20260218-dmabuf-heap-cma-dmem-v2-3-b249886fb7b2@redhat.com> --qbjavhllvvchwpql Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v2 3/3] dma-buf: heaps: cma: charge each cma heap's dmem MIME-Version: 1.0 Hi, On Wed, Feb 18, 2026 at 12:14:12PM -0500, Eric Chanudet wrote: > The cma dma-buf heaps let userspace allocate buffers in CMA regions > without enforcing limits. Since each cma region registers in dmem, > charge against it when allocating a buffer in a cma heap. >=20 > Signed-off-by: Eric Chanudet > --- > drivers/dma-buf/heaps/cma_heap.c | 15 ++++++++++++++- > 1 file changed, 14 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/dma-buf/heaps/cma_heap.c b/drivers/dma-buf/heaps/cma= _heap.c > index 49cc45fb42dd7200c3c14384bcfdbe85323454b1..bbd4f9495808da19256d97bd6= a4dca3e1b0a30a0 100644 > --- a/drivers/dma-buf/heaps/cma_heap.c > +++ b/drivers/dma-buf/heaps/cma_heap.c > @@ -27,6 +27,7 @@ > #include > #include > #include > +#include > =20 > #define DEFAULT_CMA_NAME "default_cma_region" > =20 > @@ -58,6 +59,7 @@ struct cma_heap_buffer { > pgoff_t pagecount; > int vmap_cnt; > void *vaddr; > + struct dmem_cgroup_pool_state *pool; I guess we should add an #if IS_ENABLED #endif guard for dmem? > }; > =20 > struct dma_heap_attachment { > @@ -276,6 +278,7 @@ static void cma_heap_dma_buf_release(struct dma_buf *= dmabuf) > kfree(buffer->pages); > /* release memory */ > cma_release(cma_heap->cma, buffer->cma_pages, buffer->pagecount); > + dmem_cgroup_uncharge(buffer->pool, buffer->len); > kfree(buffer); > } > =20 > @@ -319,9 +322,17 @@ static struct dma_buf *cma_heap_allocate(struct dma_= heap *heap, > if (align > CONFIG_CMA_ALIGNMENT) > align =3D CONFIG_CMA_ALIGNMENT; > =20 > + if (mem_accounting) { > + ret =3D dmem_cgroup_try_charge( > + cma_get_dmem_cgroup_region(cma_heap->cma), size, > + &buffer->pool, NULL); This alone doesn't call for a new version, but adhering to the kernel coding style would look like this: + ret =3D dmem_cgroup_try_charge(cma_get_dmem_cgroup_region(cma_heap->cma), + size, &buffer->pool, NULL); It looks good to me otherwise, Acked-by: Maxime Ripard Maxime --qbjavhllvvchwpql Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iJUEABMJAB0WIQTkHFbLp4ejekA/qfgnX84Zoj2+dgUCaZbU8AAKCRAnX84Zoj2+ diB9AYDhkg6+tBwkM8yMFN9/WFT+hpPNlhGw0UEY/ZE0DHuKywzN1rTS3USBgeXc 4vi8MkIBgIRG4eHa1thavtEHDzWooCqiLhwDczcPdIil4bWekTGZxgf1mQQHrqGd pK5ZeNH5CQ== =YZKD -----END PGP SIGNATURE----- --qbjavhllvvchwpql--