From: Radu Sabau via B4 Relay <devnull+radu.sabau.analog.com@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Nuno Sa <nuno.sa@analog.com>,
Jonathan Cameron <jic23@kernel.org>,
David Lechner <dlechner@baylibre.com>,
Andy Shevchenko <andy@kernel.org>,
Robert Budai <robert.budai@analog.com>,
Antoniu Miclaus <antoniu.miclaus@analog.com>,
Ramona Gradinariu <ramona.gradinariu@analog.com>
Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
Radu Sabau <radu.sabau@analog.com>
Subject: [PATCH] iio: imu: adis: Fix NULL pointer dereference in adis_init
Date: Fri, 20 Feb 2026 15:36:17 +0200 [thread overview]
Message-ID: <20260220-adis-fix-v1-1-9fa10cce812f@analog.com> (raw)
From: Radu Sabau <radu.sabau@analog.com>
The adis_init() function dereferences adis->ops to check if the
individual function pointers (write, read, reset) are NULL, but does
not first check if adis->ops itself is NULL.
Drivers like adis16480, adis16490, adis16545 and others do not set
custom ops and rely on adis_init() assigning the defaults. Since struct
adis is zero-initialized by devm_iio_device_alloc(), adis->ops is NULL
when adis_init() is called, causing a NULL pointer dereference:
Unable to handle kernel NULL pointer dereference at virtual
address 0000000000000000
pc : adis_init+0xc0/0x118
Call trace:
adis_init+0xc0/0x118
adis16480_probe+0xe0/0x670
Fix this by checking if adis->ops is NULL before dereferencing it,
falling through to assign the default ops in that case.
Fixes: 7f15d7a7d12d ("iio: imu: adis: Add reset to custom ops")
Signed-off-by: Radu Sabau <radu.sabau@analog.com>
---
adis_init() dereferences adis->ops to validate its function pointers
before checking whether adis->ops itself is NULL. Drivers that rely on
the default ops (adis16480, adis16490, adis16545, among others) never
set adis->ops prior to calling adis_init(), so the field is NULL due to
zero-initialisation by devm_iio_device_alloc(). The result is a kernel
crash on probe:
Unable to handle kernel NULL pointer dereference at virtual address 0000000000000000
Hardware name: Raspberry Pi 5 Model B Rev 1.0 (DT)
pc : adis_init+0xc0/0x118
lr : adis_init+0x50/0x118
Call trace:
adis_init+0xc0/0x118
adis16480_probe+0xe0/0x670
spi_probe+0x8c/0xf8
really_probe+0xc4/0x2b0
The bug was introduced in 7f15d7 ("iio: imu: adis: Add reset to custom ops")
which added the ops validation logic without a prior NULL check
on the pointer itself.
The fix is a one-line addition of !adis->ops to the condition, so that
a NULL ops pointer is treated the same as an ops struct with all-NULL
function pointers, both falling through to the default ops assignment.
The validation path for partially-populated custom ops structs is
unchanged.
Tested on Raspberry Pi 5 with adis16545-3 connected over SPI. Without
the fix the kernel crashes at adis_init+0xc0. With the fix the driver
probes successfully and the device is accessible via the IIO subsystem.
---
drivers/iio/imu/adis.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/imu/adis.c b/drivers/iio/imu/adis.c
index d160147cce0b..e68bc1c36ed1 100644
--- a/drivers/iio/imu/adis.c
+++ b/drivers/iio/imu/adis.c
@@ -526,7 +526,7 @@ int adis_init(struct adis *adis, struct iio_dev *indio_dev,
adis->spi = spi;
adis->data = data;
- if (!adis->ops->write && !adis->ops->read && !adis->ops->reset)
+ if (!adis->ops || (!adis->ops->write && !adis->ops->read && !adis->ops->reset))
adis->ops = &adis_default_ops;
else if (!adis->ops->write || !adis->ops->read || !adis->ops->reset)
return -EINVAL;
---
base-commit: 8bf22c33e7a172fbc72464f4cc484d23a6b412ba
change-id: 20260220-adis-fix-177ca0405d8a
Best regards,
--
Radu Sabau <radu.sabau@analog.com>
next reply other threads:[~2026-02-20 13:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-20 13:36 Radu Sabau via B4 Relay [this message]
2026-02-20 14:06 ` Andy Shevchenko
2026-02-20 14:10 ` Miclaus, Antoniu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260220-adis-fix-v1-1-9fa10cce812f@analog.com \
--to=devnull+radu.sabau.analog.com@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=antoniu.miclaus@analog.com \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=radu.sabau@analog.com \
--cc=ramona.gradinariu@analog.com \
--cc=robert.budai@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®