From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B5C030F539 for ; Fri, 20 Feb 2026 22:39:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771627146; cv=none; b=LkxPmCCgLcKE+acdD14lCAxLNgAzVqPpkZgX4DM6GKpXdKpNBgb5GZCRTS7AHJlzHRr+n+luzGrWc0Vdl4o5MYeOJ8djBKe+WAfHrrhSZTRm7hIZp8llDGbfoVzEk++reIW1MA45aK7vag6Cs8DKJ5p7F0SoXzExET34yusTTOg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771627146; c=relaxed/simple; bh=mI3DiEAWC0QgxvWgebPwZRRwG+6G2ivTegh9FS0XPY4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fUQu/DVnXWEdomt+d5QsXfmpCrDjO2fFXXW2WMjmnhjdqiwqA0G6W0QH0pbP8s8itQwiyEJmnsB9I6puSUWtLGmT26b+8VuNOmlidFmMXRzApY3jHVs5ogXlmtC+ZOYoaDhLiw8xnmgHWQaY4v669hORMlVQW30CtKQasM0Pruk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=DtqyY89S; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="DtqyY89S" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 566C0C116C6; Fri, 20 Feb 2026 22:39:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1771627145; bh=mI3DiEAWC0QgxvWgebPwZRRwG+6G2ivTegh9FS0XPY4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DtqyY89S8+Y3uZXsSTb8oCWlweAUkqOy4n1TuPeCmBAuuiA2v85rhrFetnYZkegKo /cuSwMJ+GKjTxc/DEE1PYsoFUYwnWWbgS2+1fUmVJLjmQhe93W+hIEE3W/PkJw1LKV kK/Hnts8aXOt22Ju3aqqXZHhXeLFwsnOSIvCqydESsB0gKFXCfPKQxbnj13Rffcxl5 Q5zjs8M4H2ygyJQMShEilcflT1pYH0zCDt16s6F2rW7Hx9hT+Sj3UrpYLZyT4sjJZ6 tvEHWS4gHrEf5KgpP+pOg7td5pLy3ujqkCLghzi2BWWYd+pVxbD6sE+fwPdy4mIVFo 2N1FTDkGtCW+w== Date: Fri, 20 Feb 2026 22:39:01 +0000 From: Conor Dooley To: Jisheng Zhang Cc: Kunwu Chan , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Anup Patel , Atish Patra , Zong Li , Deepak Gupta , Zhouyi Zhou , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND 0/2] riscv: fix minor typos and style issues in XIP code Message-ID: <20260220-cardigan-scanning-da6647279ea8@spud> References: <20260214023804.677127-1-kunwu.chan@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="WCtFJNCIevePJJ7C" Content-Disposition: inline In-Reply-To: --WCtFJNCIevePJJ7C Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Feb 20, 2026 at 11:38:03PM +0800, Jisheng Zhang wrote: > On Sat, Feb 14, 2026 at 10:38:02AM +0800, Kunwu Chan wrote: > > Fix a few minor issues found in riscv XIP-related code: >=20 > 'RESEND' isn't expected to be used as you did in this series. > You sent the v1 series on Feb 14, only 4 days ago, the series doesn't > miss any dev window. > https://lore.kernel.org/linux-riscv/8ee1b065-b021-411b-b5ee-22c4a108cbce@= linux.dev/T/#t v1 wasn't threaded correctly, so I think a resend is fine as the content didn't change. > > - xip_fixup.h: comment typo (_start vs _sdata) and spaces-vs-tab > > - head.S: spelling typo and wrong #endif comment >=20 > I'm sorry, but how important is fixing comment/spelling typo or #endif > comment among maintainship? It's not, but I think we've made this point already! > The riscv XIP code doesn't stand on itself, > but heavily affects and is affected by other riscv arch common code. --WCtFJNCIevePJJ7C Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCaZjihAAKCRB4tDGHoIJi 0iWWAP41tLmKr1IGVMl/E/wbeln1O2Hjk1pJKmW1r7JdMht2/wD+MEwUc0+gdCto x/VOvGbhkbNUS2r4Q8BYG3Is38CDXQY= =ZR/J -----END PGP SIGNATURE----- --WCtFJNCIevePJJ7C--