From: Antoniu Miclaus <antoniu.miclaus@analog.com>
To: "Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Antoniu Miclaus" <antoniu.miclaus@analog.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 3/5] iio: dac: ad5592r-base: remove redundant else after return
Date: Fri, 20 Feb 2026 15:33:32 +0200 [thread overview]
Message-ID: <20260220133337.85216-4-antoniu.miclaus@analog.com> (raw)
In-Reply-To: <20260220133337.85216-1-antoniu.miclaus@analog.com>
The else returning the internal 2500mV fallback in ad5592r_get_vref()
is unnecessary since the if block for the external regulator already
returns.
Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
---
drivers/iio/dac/ad5592r-base.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/dac/ad5592r-base.c b/drivers/iio/dac/ad5592r-base.c
index 4720733d66b2..a8c10ca238d0 100644
--- a/drivers/iio/dac/ad5592r-base.c
+++ b/drivers/iio/dac/ad5592r-base.c
@@ -179,9 +179,9 @@ static int ad5592r_get_vref(struct ad5592r_state *st)
return ret;
return ret / 1000;
- } else {
- return 2500;
}
+
+ return 2500;
}
static int ad5592r_set_channel_modes(struct ad5592r_state *st)
--
2.43.0
next prev parent reply other threads:[~2026-02-20 13:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-20 13:33 [PATCH 0/5] iio: " Antoniu Miclaus
2026-02-20 13:33 ` [PATCH 1/5] iio: adc: ad7298: " Antoniu Miclaus
2026-02-20 13:33 ` [PATCH 2/5] iio: adc: ad7606: " Antoniu Miclaus
2026-02-20 13:33 ` Antoniu Miclaus [this message]
2026-02-20 13:33 ` [PATCH 4/5] iio: dac: ad5758: " Antoniu Miclaus
2026-02-20 13:33 ` [PATCH 5/5] iio: filter: admv8818: " Antoniu Miclaus
2026-02-20 14:14 ` Andy Shevchenko
2026-02-20 14:13 ` [PATCH 0/5] iio: " Andy Shevchenko
2026-02-20 14:16 ` Andy Shevchenko
2026-02-22 16:43 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260220133337.85216-4-antoniu.miclaus@analog.com \
--to=antoniu.miclaus@analog.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®