From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D070241695 for ; Fri, 20 Feb 2026 16:06:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771603603; cv=none; b=M8L50bAAUDgTueJOtcAz8H7/sV65KqQKyzRIKh1GK3Ubbf3y9F+0mdvvHB4Fo++DyL7ouMr12IJTsMYBdnITQqRk7sAYR5thpC2sRMnyQH/wZEckF+jmGqwUQiS/KoOzAzToReFoZfEU+v5V/fPxZil9upRt3MFWscAxGVIJfXo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771603603; c=relaxed/simple; bh=9hclLdLgKwtOnm6aWCR8GUkLVckqubKuLwKXDE3aOz4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=B44k7omOSStFEibQEsrirJB1dJbTXIOj6Kd0BNQAAy8LDpa2hwEprRWrqPeO+NVwS9CWfv43yQJOs28t8s1y4DsVFy0lQSgaTsF8Z8YtpwkZvhMMOnMkelL0hvu6D68YMt/aog64hnz/mdU3HCJnL3+StX/KNo+5wlXtKP4ndKM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id B5D3068B05; Fri, 20 Feb 2026 17:06:39 +0100 (CET) Date: Fri, 20 Feb 2026 17:06:39 +0100 From: Christoph Hellwig To: Caleb Sander Mateos Cc: Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , Chaitanya Kulkarni , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/6] nvme: add preferred I/O size fields to struct nvme_id_ns_nvm Message-ID: <20260220160639.GB15071@lst.de> References: <20260220032809.758089-1-csander@purestorage.com> <20260220032809.758089-2-csander@purestorage.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260220032809.758089-2-csander@purestorage.com> User-Agent: Mutt/1.5.17 (2007-11-01) On Thu, Feb 19, 2026 at 08:28:04PM -0700, Caleb Sander Mateos wrote: > A subsequent change will use the NPDGL and NPDAL fields of the NVM > Command Set Specific Identify Namespace structure, so add them (and the > handful of intervening fields) to struct nvme_id_ns_nvm. Looks good. Btw, as the kernel now has a the global scope static_assert, can you add that too any on the wire format struct you touch to ensure our modifications aren't changing the sizses? Signed-off-by: Christoph Hellwig