From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C661A930; Sat, 21 Feb 2026 10:50:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771671032; cv=none; b=SwtoUofYIr4R9rBmWRJc83Gw60/onHaYbI1BVQcMA4Ut7WllmF62CmylPH6V+YrHtRGHtDhbyGeEBTPJcX6SkRXVUcsrZflhJQHLkWYaZUYjWbnzhxjLpsBWQvwA5Po46c0HaR6xE3sdfOV1YgHu+pqP0o9x0UK4X/7NnLj/Mp0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771671032; c=relaxed/simple; bh=/P/wUs/RpRhI0E1M0aMEkA8nxb12jUrG+esikZ6r3S8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RCdj06+ZwmLnBpSLmKsKHb6MIxIFybni0xgNiFgCcdrHubHDqI/oA94oy5VuMEb+fBR4SuIE2J+MxZwWhiPowBDdW43WfCOY9LosbwEiwaBZwzwsIrTZJ/TlL6TgaxMPFQ9vvXtoZ7FwkQ0tSQVPUc2jB6d7J9fjSQ7WSv0kFQ0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=b9Mu5xfo; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="b9Mu5xfo" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 36ED1C4CEF7; Sat, 21 Feb 2026 10:50:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1771671031; bh=/P/wUs/RpRhI0E1M0aMEkA8nxb12jUrG+esikZ6r3S8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=b9Mu5xfoUua6lFAi/NIaU1S/kIhwWgFUuuhQlH2XQOzwQVhGAtrKgGKDxKPxRdeRP 3RkxAFWQuzN5eUIHgCIN4zdfA56bF/vORnLiiy/VXWXSySri0r1h15jGNlnsHM/59n E7q+vMfYPqD/FAUWlvwuFHKxHEb2xFzRMYGa/NqQzu6xdODU7bChO6cVPQZqo7wf9F jMZTRnsbqMNpHoOa5MHKXvpbHN3s11TrYMBxZN3lhxy2zHhJH0d7i9f5ExUy6ICIBX 0ejcB//tKwEcCWLCQB04Xs3oprxcKu4KcD4ELVjE1KDq8kMnrFVw8GNsEEXcVZbuio eCUBK9P7tcKJA== Date: Sat, 21 Feb 2026 11:50:29 +0100 From: Krzysztof Kozlowski To: Otto =?utf-8?Q?Pfl=C3=BCger?= Cc: Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Orson Zhai , Baolin Wang , Chunyan Zhang , Lee Jones , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 2/3] dt-bindings: mfd: sprd,sc2731: Reference sprd,sc2730-regulator bindings Message-ID: <20260221-unyielding-violet-dragon-6121d5@quoll> References: <20260220-sc2730-regulators-v1-0-3f2bbc9ecf14@abscue.de> <20260220-sc2730-regulators-v1-2-3f2bbc9ecf14@abscue.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <20260220-sc2730-regulators-v1-2-3f2bbc9ecf14@abscue.de> On Fri, Feb 20, 2026 at 06:01:50PM +0100, Otto Pfl=C3=BCger wrote: > The SC2730 PMIC provides a different set of regulators than SC2731 and > thus requires separate regulator bindings. Determine which bindings to > include based on the compatible string of the PMIC. >=20 > Signed-off-by: Otto Pfl=C3=BCger > --- > Documentation/devicetree/bindings/mfd/sprd,sc2731.yaml | 13 +++++++++++++ > 1 file changed, 13 insertions(+) >=20 > diff --git a/Documentation/devicetree/bindings/mfd/sprd,sc2731.yaml b/Doc= umentation/devicetree/bindings/mfd/sprd,sc2731.yaml > index b023e1ef8d3c..e4ebb511bba1 100644 > --- a/Documentation/devicetree/bindings/mfd/sprd,sc2731.yaml > +++ b/Documentation/devicetree/bindings/mfd/sprd,sc2731.yaml > @@ -99,6 +99,19 @@ required: > - '#interrupt-cells' > - '#size-cells' > =20 > +allOf: > + - if: > + properties: > + compatible: > + contains: > + enum: > + - sprd,sc2730 > + then: > + properties: > + regulators: > + type: object > + $ref: /schemas/regulator/sprd,sc2730-regulator.yaml# This contradicts the top-level which says it is sc2731. It cannot be both. You just need oneOf for $ref or compatible, in the top level place for regulators and then just drop this. If you want additionally (!!!) to put constraints what can be the child, it's fine, but just with compatible if you have it and also what about all of other children? =2E.. which will lead you to next problem - it's getting complicated, so why not having it just separate schema? Best regards, Krzysztof