From: Andrew Morton <akpm@linux-foundation.org>
To: Rio <rioo.tsukatsukii@gmail.com>
Cc: feng.tang@linux.alibaba.com, joel.granados@kernel.org,
linux-kernel@vger.kernel.org, pmladek@suse.com,
pnina.feder@mobileye.com, wangjinchao600@gmail.com
Subject: Re: [PATCH] kernel/panic: increase buffer size for verbose taint logging
Date: Sat, 21 Feb 2026 12:03:24 -0800 [thread overview]
Message-ID: <20260221120324.aefaf060faa571e55c30b465@linux-foundation.org> (raw)
In-Reply-To: <20260221065603.24754-1-rioo.tsukatsukii@gmail.com>
On Sat, 21 Feb 2026 12:26:03 +0530 Rio <rioo.tsukatsukii@gmail.com> wrote:
> > "accommodate". I'll fix this.
>
> Thanks
>
> > How does this look?
>
> > + *
> > + * Also, update TAINT_BUF_MAX below.
> > */
> > ...
> > -/* 350 can accomadate all taint flags in verbose mode, with some headroom */
> > +/* 350 can accommodate all taint flags in verbose mode, with some headroom */
> > #define TAINT_BUF_MAX 350
>
> Looks good, though it might help future maintainers if we document the current
> maximum length of the verbose string (excluding the trailing NULL). Happy to
> send a small follow-up patch if needed.
OK, how about this idea.
- Allocating static storage is annoying: dynamic allocation is better
- Now knowing how large to make the storage is also annoying.
So:
- define a static buffer, mark it __initdata so it gets released
later in boot. Make print_tainted() use that, initially, so
print_tainted() is available at initial bootup time.
- write a new __init function which adds up all string lengths in
taint_flags[] and calculates the precise maximum needed buffer size.
Allocate that much memory (kmalloc) and switch print_tainted() over
to using that buffer.
- When __init data gets released, the initial static buffer and the
new __init function get thrown away.
next prev parent reply other threads:[~2026-02-21 20:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-20 15:15 Rio
2026-02-20 21:06 ` Andrew Morton
2026-02-21 6:56 ` Rio
2026-02-21 20:03 ` Andrew Morton [this message]
2026-02-22 14:08 ` [PATCHv2] kernel/panic: allocate taint string buffer dynamically Rio
2026-02-22 15:23 ` Rio
2026-02-22 19:25 ` Andrew Morton
2026-02-23 3:59 ` [PATCHv3] kernel/panic: mark init_taint_buf as __initdata and panic instead of warning in alloc_taint_buf() Rio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260221120324.aefaf060faa571e55c30b465@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=feng.tang@linux.alibaba.com \
--cc=joel.granados@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=pnina.feder@mobileye.com \
--cc=rioo.tsukatsukii@gmail.com \
--cc=wangjinchao600@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®