From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f48.google.com (mail-dl1-f48.google.com [74.125.82.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16C125464D for ; Sun, 22 Feb 2026 00:37:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771720652; cv=none; b=ZEqC+03z5fM2X08daFyYWmwhTrj51suv0XQxoPgt3rx93veCdrpz+7V4NC5/PWZ8sDvwi5rxAdmaYaBrw0dRhqtiwLdLEVtzXXfYLALOHPbJjPAT2ylaN8bATTQ0ZUdlL2kGD5EbXTLej+SkUKvcW/Svmdbt1sMDZwMDnvwWXaE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771720652; c=relaxed/simple; bh=/oWe9TBcbfGVgvA3YAwcI++qilYUs5G6I0MwqlEyTXQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RU6sJoPFLWUCo5iCJwGRdV9D6anws3tNPcGlxfNyTr2JXaY7noaJjDIWUO5ch24xYzf9RP0cSQMntr7/ZtAYVGgIwusRQIyr1pBQvNGvw5+Yaj0uocUS0a2LzqMvjrLUzHC8/enirhkdkhWHgvSgLgqxFwLmDGFByYceqbpXKe8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RSlxUR6t; arc=none smtp.client-ip=74.125.82.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RSlxUR6t" Received: by mail-dl1-f48.google.com with SMTP id a92af1059eb24-1271257ae53so3015914c88.1 for ; Sat, 21 Feb 2026 16:37:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771720650; x=1772325450; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NCOB+xu4HpFhupd2ul95dO/R/350Wo1NOuKyLRfUoGY=; b=RSlxUR6t63YWJUImIV2pOsjQcfgwU5MROiABCoo+qd7JMdhBPfn3ZtbjJtP8CY5NPt VJNtibz9iy16s64kw1bR6FV82zsU5/whVKSsU5k/yV/0yxrFYs1ajS/nsuVTiuf54vSm h3hIQa3HnatX2ARrDbpJ8XGnAkk3q5CtD7DAUbi3QgpOiKPx5Ffa9voYCNCMPKTz0kMn Nve1xm2oQAu6PxXuddgOnjV2iVbwgZYxe0+tHN5CzNhvHQtpkrj5nvSXkekG6BIzQs7Q QWC6TTkYOlIj8A53X01F42EYpVnWcz6Y1qMNg8QSYsTtnKdlmqXJi6ZYUXEJaNN0SrOk 9bBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771720650; x=1772325450; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=NCOB+xu4HpFhupd2ul95dO/R/350Wo1NOuKyLRfUoGY=; b=YG9ID+bA8kKjls9ZxTBWubMmJnrjwNOYg08zDmLH/9T/PJ0qX1Ds/08MzJDafkNjxo cvE4Jq38k2Dhfh88TN6X1UGBhNMqQCsZtpyGBCerSgti+wF6riq5Pu7T5CxEFrXuc+Q8 JTVLfMBoHbsLj+KJbwyaZCz94Ym94Fyoq9V5v3jDeu/DhGxmXYJOFGz4bg+m87XLyoYk w2Rtmj4335wvVvpBb3Xwz6xWgcxEIDqaEBFrYiKzcTbe8lJqsHR5VgnYhtH2XOUn9ry1 55pWTXDt6FT6wCRWJff+tY3NPBZZPwmjr3L57IFqMzgqcxgpghqM81+zPyx/8zpRprmY AxPw== X-Forwarded-Encrypted: i=1; AJvYcCWROk4shsD1jBA/kqHbZ6l/WtVPxe1KZd/GtnOCi9sFOBGJRfi+bO/boat9beJVkqurtCcIRq6PGliGwWI=@vger.kernel.org X-Gm-Message-State: AOJu0YxlbFZMJV/Xj6XN3O8HU1OZyLRw34Ldls8OPlU23BKg9A+o4gQd mpDYyptywp3/S9TAA2zj4KoUWcORIZo0XhUIzmuuA78d42FdNQ5nXO8W X-Gm-Gg: AZuq6aIcpYZgOy1zgH6Yd2ku8rvOEF95rC21x/YxPAtx+8oPeYRxogd6TBpKoMzi07L 8huJDqhxfSCoXg/B69AXVElvlsLnxhtfeV9KCBFaSZQRk0TEF6rLSGlPa3b6F2lwbE1Dm87lOX/ y9/TKaD4tyuu1UE3yk55Bw8oHOshMtlca7cmo6U+EVUgy2beDlCwcjICAV01CIKPflZ60NtIbnz l07IArAIzhXLvS8T2YxM4IEi1IXt4V8z4DcFar8TL533dTeKgy2QF4lX7VGXVSd2jKtcFMLy2KU FcGIuOKnrauZ7VMa8y79hUREwi/suEr1d4QgN4pVp3QH20A8uwsNltQqOnGkJTdHBEQIaVhc64z mLp86luJbO4zLFKyG8mIuGA9cD2ZdD6TcWFxdPZWQ1lk4/kUGKZDzWzhPSzmQHFLsNAx43bPTRp 9dB8DwyYYEtJDpadWPRuaBMoq9OBGLBJ9KErR00ZR8tWs24Wobivs7Abha6aIdLcSIQ95OBcx+g rlZwz+UV3j+kWE76bFoyrN+ X-Received: by 2002:a05:7022:2482:b0:127:35af:143c with SMTP id a92af1059eb24-1276ad39a83mr1667574c88.37.1771720650227; Sat, 21 Feb 2026 16:37:30 -0800 (PST) Received: from dtor-ws.sjc.corp.google.com ([2a00:79e0:2ebe:8:73d:b075:516c:4a69]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2bd7dc167d3sm2383191eec.24.2026.02.21.16.37.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Feb 2026 16:37:29 -0800 (PST) From: Dmitry Torokhov To: Fabio Baltieri , Benson Leung Cc: Guenter Roeck , Simon Glass , Tzung-Bi Shih , linux-input@vger.kernel.org, chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 7/7] Input: cros_ec_keyb - factor out column processing Date: Sat, 21 Feb 2026 16:37:15 -0800 Message-ID: <20260222003717.471977-7-dmitry.torokhov@gmail.com> X-Mailer: git-send-email 2.53.0.345.g96ddfc5eaa-goog In-Reply-To: <20260222003717.471977-1-dmitry.torokhov@gmail.com> References: <20260222003717.471977-1-dmitry.torokhov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Factor out column processing and eagerly skip processing columns that do not have any changes in them. Signed-off-by: Dmitry Torokhov --- drivers/input/keyboard/cros_ec_keyb.c | 47 +++++++++++++++------------ 1 file changed, 27 insertions(+), 20 deletions(-) diff --git a/drivers/input/keyboard/cros_ec_keyb.c b/drivers/input/keyboard/cros_ec_keyb.c index 02176aee0530..8cf9129f6198 100644 --- a/drivers/input/keyboard/cros_ec_keyb.c +++ b/drivers/input/keyboard/cros_ec_keyb.c @@ -254,6 +254,26 @@ static void cros_ec_keyb_process_key_fn_map(struct cros_ec_keyb *ckdev, input_report_key(idev, code, state); } +static void cros_ec_keyy_process_col(struct cros_ec_keyb *ckdev, int col, + u8 col_state, u8 changed) +{ + for (int row = 0; row < ckdev->rows; row++) { + if (changed & BIT(row)) { + u8 key_state = col_state & BIT(row); + + dev_dbg(ckdev->dev, "changed: [r%d c%d]: byte %02x\n", + row, col, key_state); + + if (ckdev->has_fn_map) + cros_ec_keyb_process_key_fn_map(ckdev, row, col, + key_state); + else + cros_ec_keyb_process_key_plain(ckdev, row, col, + key_state); + } + } +} + /* * Compares the new keyboard state to the old one and produces key * press/release events accordingly. The keyboard state is one byte @@ -261,10 +281,6 @@ static void cros_ec_keyb_process_key_fn_map(struct cros_ec_keyb *ckdev, */ static void cros_ec_keyb_process(struct cros_ec_keyb *ckdev, u8 *kb_state, int len) { - int col, row; - int new_state; - int old_state; - if (ckdev->ghost_filter && cros_ec_keyb_has_ghosting(ckdev, kb_state)) { /* * Simple-minded solution: ignore this state. The obvious @@ -275,24 +291,15 @@ static void cros_ec_keyb_process(struct cros_ec_keyb *ckdev, u8 *kb_state, int l return; } - for (col = 0; col < ckdev->cols; col++) { - for (row = 0; row < ckdev->rows; row++) { - new_state = kb_state[col] & BIT(row); - old_state = ckdev->old_kb_state[col] & BIT(row); - - if (new_state == old_state) - continue; - - dev_dbg(ckdev->dev, "changed: [r%d c%d]: byte %02x\n", - row, col, new_state); + for (int col = 0; col < ckdev->cols; col++) { + u8 changed = kb_state[col] ^ ckdev->old_kb_state[col]; - if (ckdev->has_fn_map) - cros_ec_keyb_process_key_fn_map(ckdev, row, col, new_state); - else - cros_ec_keyb_process_key_plain(ckdev, row, col, new_state); - } - ckdev->old_kb_state[col] = kb_state[col]; + if (changed) + cros_ec_keyy_process_col(ckdev, col, kb_state[col], + changed); } + + memcpy(ckdev->old_kb_state, kb_state, sizeof(ckdev->old_kb_state)); input_sync(ckdev->idev); } -- 2.53.0.345.g96ddfc5eaa-goog