Re: [PATCH] iio: adc: nxp-sar-adc: Remove unnecessary type casting

[Jonathan Cameron <jic23@kernel.org>]

On Sun, 22 Feb 2026 02:09:08 +0800
Felix Gu <ustc.gu@gmail.com> wrote:

> The readl_poll_timeout() macro returns a signed integer error code.
> 
> In nxp_sar_adc_calibration_wait(), the return value is casted to u32
> before being returned as int, which is unnecessary.
> 
> Signed-off-by: Felix Gu <ustc.gu@gmail.com>
Hi Felix,

Make sure to include the author of the code you are touching in the +CC list.
Added Daniel.

I think this is simple enough, so I've picked it up now but I'm fine adding
tags or indeed dropping it if other reviews come in.  I'll be rebasing
or rc1 later in the week.

Applied to the testing branch of iio.git

Thanks,

Jonathan

> ---
>  drivers/iio/adc/nxp-sar-adc.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/nxp-sar-adc.c b/drivers/iio/adc/nxp-sar-adc.c
> index 9efa883c277d..a6e4888a8464 100644
> --- a/drivers/iio/adc/nxp-sar-adc.c
> +++ b/drivers/iio/adc/nxp-sar-adc.c
> @@ -247,7 +247,8 @@ static inline void nxp_sar_adc_calibration_start(void __iomem *base)
>  
>  static inline int nxp_sar_adc_calibration_wait(void __iomem *base)
>  {
> -	u32 msr, ret;
> +	u32 msr;
> +	int ret;
>  
>  	ret = readl_poll_timeout(NXP_SAR_ADC_MSR(base), msr,
>  				 !FIELD_GET(NXP_SAR_ADC_MSR_CALBUSY, msr),
> 
> ---
> base-commit: d4906ae14a5f136ceb671bb14cedbf13fa560da6
> change-id: 20260222-nxp-sar-adc-1906a65ce5b6
> 
> Best regards,