From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 713F4360751 for ; Mon, 23 Feb 2026 10:57:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771844278; cv=none; b=fSzwHPNnVaffN5rikswTdPhcgJsEWH3WvdG2c2rBQQe4K4kgis8fNFBycLqtnG8LOTfGUpDfUHGy/0yitWdoZIMt9bHxPikrFyLP3JwjEoh+/VVmWIEFokTS+X4PAK+/ue/RUZQ9fSh7MLGQOP/ldapG1WdnA5mm/uD7GhSalPw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771844278; c=relaxed/simple; bh=+nk0zqEXRtWTFEcBezA2NF762YohjLOZpAiO63L4OZk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=KQqHQ4rR38ZA7ItGSEe9OTI8ok0yEMIM2yb5uwpQNQlGSdpMUf3wa5opnP782XOQuVMkC2Y3HVPbjJADbVQP5ht2CKFw2te+WJ8/K12ZTOLW0ORDyOajc4ndOaBsO2/jnEZktIbXk6XI3drlrzhrIHI1cM2xAoe7dunDF0kQZAM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=G30+pnd7; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=XGnaCOgh; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="G30+pnd7"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="XGnaCOgh" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61N9oofK2783699 for ; Mon, 23 Feb 2026 10:57:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= v6t/kIGkz1spavzDz1IjVV+f0Kkjf8oUKB5O1Sgr+3Y=; b=G30+pnd7RIZSElDV wNkMTQEbLvcUIaeaXKTd/Y9WV4DkY1jl42MaTuPIL97i4A8I089kv3/t6CsS5/pP sT6uHtEpKizjTqWC4uyzocnDOGD3WxV1O9G/tiIIITPN1/5LGNowbAC2p1YbH7q5 XDz0a/0FlalNztpux657ycR4l7r85jheGXVATIelk8ux7qX0EbCe9939uU7rXS3o 3qRhC3YiMzH7tOJs9ytL+2LOkw3yfQLsWjhDJzo9xwkBxHz3pFvxhNnOJzrtO5vb z9pa/xDJE+Q8SRDojL/DJLxid6caHErDgg/HHi4uUF51Vo7dRblDAYsfTZPZJ+qz jqHe+A== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cf5vgvge4-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 23 Feb 2026 10:57:56 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8c70ed6c849so3925126785a.1 for ; Mon, 23 Feb 2026 02:57:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771844276; x=1772449076; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=v6t/kIGkz1spavzDz1IjVV+f0Kkjf8oUKB5O1Sgr+3Y=; b=XGnaCOghV5MYG7RAo+EG+iL9CJMrOWzPq3c71rvwgz7UFZv3uhon9oyW7mOY7qd/Iz 1BcrKUUOZEQaNNLu81iFKnaRJnfyFRkZO5VkatzQ2hk7MZPpg/O5A5O0LIhmO9994IKe 8pqT2QZk93BwNKUg2UFw5DDn27zgnrVcudTdoZzysQKYjvahkRafSEeFHYGFqZpf+thZ Z4j4PJoyLkCitT3RkHQdFiW+h/wXq68KkIFLWQ7X9/sk8lXSiJWpSM160TMcHdOlxoy8 p/M4IJBybE5VtvJJg0M4p9L2ji1QwB+mAZLwxZ7y3fJwDgCjHv8hkDKJQ4ICPUy2kDlQ vFKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771844276; x=1772449076; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=v6t/kIGkz1spavzDz1IjVV+f0Kkjf8oUKB5O1Sgr+3Y=; b=Y7/4xXG2ZXUHHBUlFhRXEwP/WXGA317Z+XPlVVb0pNjElxxokQ+7+Ng4JGG6RzSbGN YC6hj3BQNAqfjzs2vRRablV3QuJcbsPsd0XGXKGkdK4qGVOWBjA0M4k4StJCfjW9SjaT 50yiyTHNuEOWcBUz3mkvu/LegFpRqela8f38W1N+Ff5C+Ae8yV0q6sFXWh0ZMr78VupV w0xxcjS6MPG1U006LfQOvFlwLq0BDqO3s7gtZT4nTEfGCXbKihhzvX2KxwZ1wGBy8BUG hbPhJkqx+/czMiRmqp9behi20UCzI4CMBdE4EmTmyBB16z1/5jtKkGrQxIfwhCVUdYHh M/8A== X-Gm-Message-State: AOJu0YyXAAmmUF6B8khaNYho+tUVkitJ4C6E61ejc6WoIHLBzveDYja6 kHkdtuP2l1Dy3ShAQniQPWBAMdboyTMv8ZPE0CpnrFZp/qL5jf3S33kI/JEeYpW0L/p9q29jMgK zzJJ+zxvYFWGdzmU84W4/wNi6KEkR8zSiWkMsl2rTxDlAKH8Q9/ctT2IUeoBeEeNvvlk= X-Gm-Gg: AZuq6aK0/p9fjGXSMHOMfZdSi3vy2DYzXd72rso/ABRyWz4UezoIcdwEU+mWWLwjVpY eUVSinIkk3NVM8ZEwfYfS1w43pGlMtH9pmAX/x9osJUvsAnFAtAt6CzOkQn6iiv4KhptMpn449z YZ7mqUjHQ/WjUFYUS3ktHEuruTHM6macekgvtHQe0R4qe/tGe9MCcuVs750txGl26JKt+UGLj8C 4eOhlo33jsGX7lYGivZVVOYEgRHpVt9/tyNSqDGEiHOCdFK8d29N9DKWGiaFkBOB0rUGccWjnBf vzNMTHA8IYrfzRBe08qiAwMMb+k7peoqEPFn7e4FMOxmbcCaj6Yzr5MxUJWRgKoUgmB969e1lew sqyvtJeQ/hityAY64JgJHMgEwElcJaoP4k/cf4SABtDnmabLLpcxO X-Received: by 2002:a05:620a:319b:b0:8c6:b45b:9e2e with SMTP id af79cd13be357-8cb8ca65f49mr880593885a.38.1771844275811; Mon, 23 Feb 2026 02:57:55 -0800 (PST) X-Received: by 2002:a05:620a:319b:b0:8c6:b45b:9e2e with SMTP id af79cd13be357-8cb8ca65f49mr880592185a.38.1771844275309; Mon, 23 Feb 2026 02:57:55 -0800 (PST) Received: from brgl-qcom.local ([2a01:cb1d:dc:7e00:bd71:422c:5e83:8b37]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43970c00c18sm18120002f8f.14.2026.02.23.02.57.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Feb 2026 02:57:54 -0800 (PST) From: Bartosz Golaszewski Date: Mon, 23 Feb 2026 11:57:03 +0100 Subject: [PATCH v2 2/7] nvmem: return -EOPNOTSUPP to in-kernel users on missing callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260223-nvmem-unbind-v2-2-0df33a933dca@oss.qualcomm.com> References: <20260223-nvmem-unbind-v2-0-0df33a933dca@oss.qualcomm.com> In-Reply-To: <20260223-nvmem-unbind-v2-0-0df33a933dca@oss.qualcomm.com> To: Srinivas Kandagatla , Bartosz Golaszewski Cc: linux-kernel@vger.kernel.org, brgl@kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2920; i=bartosz.golaszewski@oss.qualcomm.com; h=from:subject:message-id; bh=+nk0zqEXRtWTFEcBezA2NF762YohjLOZpAiO63L4OZk=; b=owEBbQKS/ZANAwAKAQWdLsv/NoTDAcsmYgBpnDKpmcaBWn50J3WDnPBwKIcXmGpZnq5oj+fW4 cT7WX21mOCJAjMEAAEKAB0WIQSR5RMt5bVGHXuiZfwFnS7L/zaEwwUCaZwyqQAKCRAFnS7L/zaE wzEBD/95zvi1r7sRbL4qeObb5sE4VS16yWo7yaoTBIHpU843KZo0YEZq8a4Y1jyUxRklqdxIIeK EFAtwemEZM8T5Xyi0/RbcsLK+rBxpMq5SUFu4o7kFyjeZyjtb6rTEnLS3V+fx2zaVhSIcay88LX 0BpDDwt1i4Y6nr1lQ6TdJakLVY9VT/o96pF2I+r7TFJBOQsZUvDFr6eF3i7dtocIMFDimtKLXn9 xSyzM23ls7HPL3f1bNDfUfZWbbatc2WqrRmVt4+dwaoo1wCq+9cqipKkuRGIFzQRaswAbhOCmrP Gv66CMC7gj2DiDG4xmuTYNsCCdyrVY73oIDp/LThJwZN28iDV6a3Vmxftkzd/aW2AjK+FwYRxsy +Y3BeLan1sMhe3pus0P77PVaNzc/WEb4dlEfjji5nL6z2hwpXBFyuXLPo6wiuaxbH2EmxMIIKAd iGS5UIdo59/p4oYhOM/kIQZFeuJ2V5Pd6hggqgfYGf5czIGQjddjtIQ3kbTRvsSnFpv4cZanYeD p0JsRzO8Yb6lx06xgiro7wuW7mUpXJLvADMx0EdfEo1zgM/kuvX7sjxRMRvJgSQXHjgWTyhSVyo 4XGy5NVTM0JdykwJCPcvO4ke31ujeCLWsdvDvqrT3xGmXYhF7POevuD5QSak9lv8LPrrikOczzT u7yA9MYCvgc0i0Q== X-Developer-Key: i=bartosz.golaszewski@oss.qualcomm.com; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjIzMDA5NCBTYWx0ZWRfX+fZvYcOzIlsg Uvx7AmfVnlkjOx8bTOwxe3mfx4WPgrOQzqRqJY2zsyPi/MRihOw7/QSqggop+NuBFAUcdCYN32J d3xP500KL1Lmr7jDD8/bQiPLttvCVBj2Bamz4XmP34rLgfj5r6TZ3UqeHmZVZpSb2wiU7babteT BrC5ksxC6/Kp4Krrj84vw8UfME1AGuvyTghzfbHT1Npj9fj2+9J90FSEXUTmr+kVaDkj6EHuV2+ wNKnhLBzBghubuYr9h98udi6LfOZX+PfENqwLaFiNNYDqPvHuJ0+ofmmsEuje0/OuHJZ131GZ2D PnFjzIdAIMqLHmwB4xnSEpdVfD5I4JW46Yjf6Cnfd2kil/p3jtgbogJg7ceKr6QmLVbMXrMcOXn YZhJHia9KQBr40XNTAf01yN7Jx4xI2xxd/Znp1OaKXwYnHq6Kq9x6CinfXJ1lkDFLru22vF375v H2QSPq57U7QTVFzwPfg== X-Authority-Analysis: v=2.4 cv=W+A1lBWk c=1 sm=1 tr=0 ts=699c32b4 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=fMUuWMZ6TpuTS4Z4e9kA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-GUID: 1qIktQlSWwQZV4SeM59yrpUjbVCM65ZS X-Proofpoint-ORIG-GUID: 1qIktQlSWwQZV4SeM59yrpUjbVCM65ZS X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-23_02,2026-02-20_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 phishscore=0 suspectscore=0 spamscore=0 bulkscore=0 adultscore=0 priorityscore=1501 clxscore=1015 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602230094 __nvmem_reg_read/write() currently return -EINVAL if the relevant callback is not present. User-space helpers again check the presence of the callbacks to see if they should return -EPERM. Ahead of adding SRCU synchronization: change the error code returned to in-kernel users to -EOPNOTSUPP which is more indicative of the actual reason for the failure as well as allows us to translate it easily to -EPERM in sysfs callbacks without having to dereference the callback pointers. This will allow us to limit the number of SRCU critical sections in the follow-up commits. Signed-off-by: Bartosz Golaszewski --- drivers/nvmem/core.c | 37 +++++++++++++++++++------------------ 1 file changed, 19 insertions(+), 18 deletions(-) diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c index 311cb2e5a5c02d2c6979d7c9bbb7f94abdfbdad1..14f583e466c8d95690539bd886fd0c2fdd440998 100644 --- a/drivers/nvmem/core.c +++ b/drivers/nvmem/core.c @@ -55,10 +55,10 @@ static BLOCKING_NOTIFIER_HEAD(nvmem_notifier); static int __nvmem_reg_read(struct nvmem_device *nvmem, unsigned int offset, void *val, size_t bytes) { - if (nvmem->reg_read) - return nvmem->reg_read(nvmem->priv, offset, val, bytes); + if (!nvmem->reg_read) + return -EOPNOTSUPP; - return -EINVAL; + return nvmem->reg_read(nvmem->priv, offset, val, bytes); } static int __nvmem_reg_write(struct nvmem_device *nvmem, unsigned int offset, @@ -66,14 +66,14 @@ static int __nvmem_reg_write(struct nvmem_device *nvmem, unsigned int offset, { int ret; - if (nvmem->reg_write) { - gpiod_set_value_cansleep(nvmem->wp_gpio, 0); - ret = nvmem->reg_write(nvmem->priv, offset, val, bytes); - gpiod_set_value_cansleep(nvmem->wp_gpio, 1); - return ret; - } + if (!nvmem->reg_write) + return -EOPNOTSUPP; + + gpiod_set_value_cansleep(nvmem->wp_gpio, 0); + ret = nvmem->reg_write(nvmem->priv, offset, val, bytes); + gpiod_set_value_cansleep(nvmem->wp_gpio, 1); - return -EINVAL; + return ret; } static int nvmem_access_with_keepouts(struct nvmem_device *nvmem, @@ -231,13 +231,12 @@ static ssize_t bin_attr_nvmem_read(struct file *filp, struct kobject *kobj, count = round_down(count, nvmem->word_size); - if (!nvmem->reg_read) - return -EPERM; - rc = nvmem_reg_read(nvmem, pos, buf, count); - - if (rc) + if (rc) { + if (rc == -EOPNOTSUPP) + rc = -EPERM; return rc; + } return count; } @@ -264,13 +263,15 @@ static ssize_t bin_attr_nvmem_write(struct file *filp, struct kobject *kobj, count = round_down(count, nvmem->word_size); - if (!nvmem->reg_write || nvmem->read_only) + if (nvmem->read_only) return -EPERM; rc = nvmem_reg_write(nvmem, pos, buf, count); - - if (rc) + if (rc) { + if (rc == -EOPNOTSUPP) + rc = -EPERM; return rc; + } return count; } -- 2.47.3