From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85CB935B62A for ; Mon, 23 Feb 2026 10:06:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771841201; cv=none; b=Tj7PLOG10CR9Yt/6S68KTusCVMWOG65FAuqKaefKq+ZJd0ZQf4Vi7eQ71owxrZcWWF/3/r5CSu1ihWjOgHuZVZ1mOA0XqmDO172z2Naw3JYIZoo+Hpu1JVuIKWGVtEh1uu4dq7MOAMWuwVM5kBZ7O749MIbMKVx6ZYl+b8iuq9s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771841201; c=relaxed/simple; bh=+mk4ppL9XWF9OnQIKVkGYEAnsfhU9QaSc9cxpk6TKTM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=pndSu/9leQ27G5yUvjCQnsYnd5ltDRefjnTtJdVyvAwAVxkN9AHo0dIXu7j0tiuLwn2KtdDlhrvltmMdzWZrQfmq57EO0zSPIT8Ein78BXiVdm2jqVMaV/SgQ/Q0zO26/e+apL0EDjPPB/hqu6BBW1Gw4Ut2RgkP3EOvvgUDd9o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=FgSQIZUm; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Il4fmBno; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="FgSQIZUm"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Il4fmBno" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61MMsBii2238684 for ; Mon, 23 Feb 2026 10:06:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Q3cNLjTDzr/nLnZnG7PjL1WTHdf61SjrQzPwxu8BAtc=; b=FgSQIZUmAXVQdO0l FiafRLC+CD8xYZlsCQnsNkD2wWuGGkAI81lQx9egC0lfXOqHJIskZDJVNNWeHpyb Z9kMA85jYNGe9U4z4wSo91NH091npLdZ07YhvldF9nKgTwx8FA713k/M4oJf670g pjPkEMM4fu1vFItH/BTEy92Z+sC0roEqPyalVBNU0NcKs7InfXdVo/mVGTfXFxko mMqqIAxkV1okBUn0H+EevKcmI+gzS9TUnF/lmKl1y+KrqtA7nkwR+X9+Q80JeGpj B+t9BlwgCAz/wNf75+6rW9NWguesIjctATrjfUvet2WoXGzzxX/6I1SWm/eLtzct VHFzsg== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cf5vum766-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 23 Feb 2026 10:06:39 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8cb3ff05c73so4157524485a.0 for ; Mon, 23 Feb 2026 02:06:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771841199; x=1772445999; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Q3cNLjTDzr/nLnZnG7PjL1WTHdf61SjrQzPwxu8BAtc=; b=Il4fmBnogw1MFlWsMUUiVZAFCw+6PEl0Z8wE+eSvtQIKFPWAJe2XgwMW2rqzLp2pk4 GW/rgLjU6UL75iPC4tvdR+93ZX/U63OaRk5TrJ4GtN4h3ZxKPJ5O9hN1JjPCWyCofcWy jX9gw8oiIBIQ8qWNX0rlrzf75vfikdT6L6dfnrZ+dP5fVqe6U1X+J5Hq6TxjLRZT6q0w gr4PcOkYSnnKgq591HTkOdG6M+Nzw6j6nd+roZA5OckWw82/rfcJfQ+tYmizLVxdHVPD JtbyNt00InAfbeYEeWcRZeZ6XW80KjsSlJJK27D7VWhi27wJS7jJs7iVPmsVlG4Mec9p vXeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771841199; x=1772445999; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Q3cNLjTDzr/nLnZnG7PjL1WTHdf61SjrQzPwxu8BAtc=; b=ArrIwt/2+8xzlc3Jv9/n273b+cEYdDvwQ3Nd+rVjXSZM/mjm16/0MjMaGiP8LGx+4r LlxL7En+sUmCvwVqUACb4EM7IH79TpUCworivDvIqFZDVKGiiDL9U7izUHO8gIQ2dHrz RgD++70mmEAiZnaP86D3vd4zWZuUyWBZxbwRewn7qm4rtvbQoXTL97QfHYTgFa46wC3U Q2HP5x2EXOhHBQo2QjjRc0ReeXNMYLoPlgw1jMPVEmrQRntOhlj8o2pdKMaf/0tVduvp owAjLDmaXgA2WGk9eYhL1Rv1PjjkIe0DmYK9Ni6jp37EGr/IILfRpS4+i8TbaHkb7FnB Fm5g== X-Gm-Message-State: AOJu0Yx5uIK70Mqk+NzjBY6UuaHEX9tw9kwN14ckO3abhpBmdwcSfR1Q ZX0jFg2xHWZG38ZoT/90uBG1fAsu8+rmtPSTxqn3zMDYpSh72xR0o/n0DNzco1TbPd6F16F+bUw cRLIQQmXjlnfiVHbUEZRhU8nWHAHYLDdAXgA3yuHjIDf3Y8GOE6bvpSg3kJ7UVFxvrQeGFkWqpk M= X-Gm-Gg: AZuq6aI3q8diNtwapSij52Rq+jJWE3vjJSUPUh0149dgGdRGqFVKqpWsXQ1HCLpYYkz vyG1LczVO7epCLykHT8jN/GsrrJ3Vq1hYxazKV6UqJ4IKKW0F1ETsko9+LkYGb/rtMJiJ5EGZYR McuYKl0jfcpUlfl/bERWdrZqQurRPkCMLDfnsalCoHNKsvGyE+fg4tolUxh9HRmUnPlm3h8OWz0 KPUkQx6rUERIEUweJOGtEe4ht/V0FVGvQnexeq5DQ+UqzmnkwnFSxDJ/iFxNmZWC77b9wLsH63J zrBnNr9OQrQCHYdnPKI0VwERSm1PRLbFJ9e0sh50Fn8/n0CrVsv7+LQtvw3B26nDmyksrEQg/cX XS6f2w1AAlBjli/EIV8yfm42ip5/FGDtFtD63/nnp7w7OFR/TH6S7 X-Received: by 2002:a05:620a:2844:b0:8cb:3e7c:a4a4 with SMTP id af79cd13be357-8cb8ca67610mr976070885a.46.1771841198772; Mon, 23 Feb 2026 02:06:38 -0800 (PST) X-Received: by 2002:a05:620a:2844:b0:8cb:3e7c:a4a4 with SMTP id af79cd13be357-8cb8ca67610mr976068785a.46.1771841198374; Mon, 23 Feb 2026 02:06:38 -0800 (PST) Received: from brgl-qcom.local ([2a01:cb1d:dc:7e00:bd71:422c:5e83:8b37]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43970d54760sm18288885f8f.35.2026.02.23.02.06.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Feb 2026 02:06:37 -0800 (PST) From: Bartosz Golaszewski Date: Mon, 23 Feb 2026 11:06:14 +0100 Subject: [PATCH v2 01/14] reset: gpio: remove unneeded OF-node put Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260223-reset-core-refactor-v2-1-5e5a7289190c@oss.qualcomm.com> References: <20260223-reset-core-refactor-v2-0-5e5a7289190c@oss.qualcomm.com> In-Reply-To: <20260223-reset-core-refactor-v2-0-5e5a7289190c@oss.qualcomm.com> To: Krzysztof Kozlowski , Philipp Zabel Cc: linux-kernel@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1749; i=bartosz.golaszewski@oss.qualcomm.com; h=from:subject:message-id; bh=+mk4ppL9XWF9OnQIKVkGYEAnsfhU9QaSc9cxpk6TKTM=; b=owEBbQKS/ZANAwAKAQWdLsv/NoTDAcsmYgBpnCaf0o9gtJciiwopTJ9dKc040oEmNOb7+sWuX jwVo/sks9qJAjMEAAEKAB0WIQSR5RMt5bVGHXuiZfwFnS7L/zaEwwUCaZwmnwAKCRAFnS7L/zaE w8mHD/4ynadNLRzzd4URmipE73UC35+Vy8cFrhfWyjeWj4QJXg3NIWtCkr89Jv4NKp7d6xSVgRb fYGA8YyWHDGNfjPYtFEz88H5232kmP1insAcvG/NMonGSUYvWtrZNnJdxd9LNHt++gUL4JuPx11 v6Yo/2V4cQqNYEEqRmUc0aa3C/yEsi3dFm0pVKssx+hsiWrQfoeAFvBYzZ82uu2DUW3DLpomt2X JKp1cOIfGkBj9tK0MMAkmOpc9BciMGJt8jm6xS+iS3RxHTXa8SYwaG/B9dG3f8S+RAqUKDXcBOy wTpZrEXESLHZOMVR8YggxWYkwVA1FARMZ1wIKH3RSQqQnPa7Tmhrwf+JQ462zPNaz8U2PnYmslu oNO/hp5t+FTZkh6GXH70gCUe3ypAmePX15Uh+TwHh1kOadlxDZQFCFuxfpLpbqOXXa7+eE3HZDi /W8XSGXw9pNhfMZ0kEvklCi1VacPtP+Jq8VrkFZaypIXrvTYFRiyWl1qt6rdqv8xE0KHttBeArP rDwl+nnBalf967UqcKDEc36EcwgBcdA0hJs+GQuBz5qKP+lUtbKqqoWiIUjnhjFBp2ei/QqKnZD auUu7U2F3UO/CsIn2b6cCwv9T6T41E8Cn0R0lm/e+1cL4lzQYzNQZsKNk8lLJ1YSZHz/3sv9hrS GZtqUffCx/Lalyg== X-Developer-Key: i=bartosz.golaszewski@oss.qualcomm.com; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-Authority-Analysis: v=2.4 cv=AL4GpdX7 c=1 sm=1 tr=0 ts=699c26af cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=ygpbbqW4ee5_35vKHe4A:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-GUID: YUpgM23JLmQISekPJtZCygG3nDrxai1e X-Proofpoint-ORIG-GUID: YUpgM23JLmQISekPJtZCygG3nDrxai1e X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjIzMDA4NiBTYWx0ZWRfX2CMuI6iNbQjD tnQ2omrQlUad60GhD1xgawg2lS+txDDCESlModBuqF45ZOpVoYUc1mvuTXYotYBF1SZFkvD29Td 59PzeyixVJqTbLpNYnRJ9hsDPgFnywmQn6D81q2eL/Wm7M7zsQECLmrhobs0NdrozdH8wKjQ4/t nx3noRaew/X2FbmzBQVE/Xn7rzw5and0WwBdsVDwXfMw92ooWUNhOhwWTvAmYs7zW9Ah/zWJLYs ZGdyIRQ6kUoVVlkv75UM5CM+8XYZrY4cSfJ6PZYim12190G3wHLTzb6vQBaLOCJu7IAfeuy0Xr/ dweZGDfjrELMOWo7ui0RKexuU1RWHZeilFSxi0VAbJEcOceRIh4tOqmN1l7Cgqrw4KzzRMlyPLY Obw81MIfWiusHIV3WUyY05NBnbH5tUNneEK2jB6X6PNNSmNdLC9zWwvphXUjYIoDudEXzdgUs5H zWfPIEAeiIKmg1LIKEQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-23_02,2026-02-20_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 malwarescore=0 bulkscore=0 impostorscore=0 phishscore=0 clxscore=1015 suspectscore=0 priorityscore=1501 adultscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602230086 priv->rc.of_node is never set in reset core. Even if it were: tasking the reset-gpio driver with controlling the reference count of an OF node set up in reset core is a weird inversion of responsability. But it's also wrong in that the underlying device never actually gets removed so the node should not be put at all and especially not at driver detach. Remove the devres action. Reviewed-by: Philipp Zabel Signed-off-by: Bartosz Golaszewski --- drivers/reset/reset-gpio.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/reset/reset-gpio.c b/drivers/reset/reset-gpio.c index 0a1610d9e78a3f1db8f523654a548fbba6087106..ad5bfe27aaef7de57f9566330253333aa2b1253f 100644 --- a/drivers/reset/reset-gpio.c +++ b/drivers/reset/reset-gpio.c @@ -52,18 +52,12 @@ static int reset_gpio_of_xlate(struct reset_controller_dev *rcdev, return reset_spec->args[0]; } -static void reset_gpio_of_node_put(void *data) -{ - of_node_put(data); -} - static int reset_gpio_probe(struct auxiliary_device *adev, const struct auxiliary_device_id *id) { struct device *dev = &adev->dev; struct of_phandle_args *platdata = dev_get_platdata(dev); struct reset_gpio_priv *priv; - int ret; if (!platdata) return -EINVAL; @@ -83,10 +77,6 @@ static int reset_gpio_probe(struct auxiliary_device *adev, priv->rc.owner = THIS_MODULE; priv->rc.dev = dev; priv->rc.of_args = platdata; - ret = devm_add_action_or_reset(dev, reset_gpio_of_node_put, - priv->rc.of_node); - if (ret) - return ret; /* Cells to match GPIO specifier, but it's not really used */ priv->rc.of_reset_n_cells = 2; -- 2.47.3