From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C25B361645 for ; Mon, 23 Feb 2026 10:06:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771841206; cv=none; b=pIWb0FhZ7jF0beYq/HBKBR8rRETWc2/8N+9ktTBJk2ztfGWAC3eBM+t//VY202hHLF6kWBpPJWRDHUj00n1ChajH50gnz/R5IiimSnU3n7Q5Mc7IyElmdTDYIDbv20FLgcdnly1qMBGZnV0UCy37YSuuwg4uU9/aoFFQMmsPBlc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771841206; c=relaxed/simple; bh=cWpfqX93SvKzM3z2d3OuDKDlUpdlj9+kKcBHteEGi4g=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=QlR7o3KnSJTQQUtIFo8pXGnDST5U4ddrXEQn1bGJe9ptCDg/gVLa0nlnm5Jx628BXh8fQBoE6IdamwV9zk9suXpMtD/ufDxfWVhprsQxLJLjy480Mk21OHOHg/cf6V9+uVhxrmaqomFUwnqDyucxGVUPj682q+nt2Quo/RnxroE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=d+lH4TNC; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Bhel4NHe; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="d+lH4TNC"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Bhel4NHe" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61N9WINd2816475 for ; Mon, 23 Feb 2026 10:06:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ObOclJsmqEBKfwKYqBvxR++so0GEyVdseAewMu5bD5k=; b=d+lH4TNC8mbp2KsZ nbr04xykgM1ygV6txu3E519FybqyU80oj0SO5FAo8hbljGGR26okNN7VT5kdzMk+ aA2ov2XSEH0sEPVGuSbuiQ8maOAg7+ma9fz5A+Pj/ZPN4V0FbDdfL2KUoZPfUb5Q aYT8NuZey9/mwuFGKwmci5eF8BdcTZ3Ago1vljVL8QlXX4vv27wJr68aoiH7sKG/ Qc8Kj6ww19rnh+O8cWLVIljqxcLoy7O+0H6Drnf5H3Nezj8+qlPfJGKvtQUavOJX /uE51/NoPU8w6zGX7TkC2mj2koFeWs+WWXBVdvxovjOB7WCKhWQkCAxEJxRtTed2 38a0cQ== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cf5vj47ne-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 23 Feb 2026 10:06:43 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8cb390a0c4eso1162180285a.1 for ; Mon, 23 Feb 2026 02:06:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771841203; x=1772446003; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ObOclJsmqEBKfwKYqBvxR++so0GEyVdseAewMu5bD5k=; b=Bhel4NHeKo6ZkoiFo/HsR8uE+BbVL+1h0FgArUgo5DL0AFHJh0O6cbs1bJIKTY2bT/ my5h/Cs9LkJbCyYQd+ZfwVlIQTEyzk/YZsHCCh2lVUvX3E2i91dnRbq4EWumwMxl3l3B Z7SDcy1/YqXL4jMZ2DZG811YN5wQoCmWmKUvg2H+9/pJiWj+uEOlfpmHwEDBn1hOe1wo WwMJQ9He7PUYdK4zvVC5Mj0H0NaDOyseI+9ujdrdc4tuId1ATNbb6x9wlu9BH06OYzC6 m99bvs20odrCBqCOuOFq1KASaHNU5moo22MAl/diaSMLTsr7Kv4yvMFM3nFWSv4Bf/yz ah2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771841203; x=1772446003; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=ObOclJsmqEBKfwKYqBvxR++so0GEyVdseAewMu5bD5k=; b=Jn9ln5hwlJqqxsXoKGlLEcWKoxGndtBXeAVUc9YrusCKzFtKD7Xx6GDV0kNIv+oqXm dxesBGa4iPYen9sHJG/ryaDUrhyTGOFIP1uWu+ZiIQoOJ7umehwt9C30Q4BoXLs1gQqg +v3Cio3eOrgub4wdAwzndmcmLdR9ccgqGPrw5Njllwz4kYDgXN2WYLrnGa7ZQL7hwK8Z r3MrRaXUjSx5N+kZEvbg7iC8qvI/CjGzm1/uV8/b1zmkzZm/OY0CFSwWm9/uQfTS096f R2WFhCDC5vniYnvd8anGzW/dWPkgHivbCg6cVC8c6IMJpascop63DZ/tuwgzElJlOIZJ 9DOw== X-Gm-Message-State: AOJu0YyOXBhoVnCBoW0+cP9SbTDibL4LDHIz+IKXd+Cu0BhdXWVMTWHd Dn+kUISTu4LvT9cPgghnaarUycetKIp5DF4NNhZEoBlSZSpUDx/ULH6cD6i8gk/T0wjAt5NgjZY 9Duye34caEFHCU5cgzJKzt9tNFJnbtWVC09pUQ1yO2ymbWPvLTLQxrQsfVf1vdFtbtSg= X-Gm-Gg: AZuq6aKx/g55xaCLW4+cYGmFQ15LEfpCt6zc9yHIsbByDuE6I7f4sYeJb5g7C+qeKjM 1OtyAd6Z5HwI2iuzdn+Qy2bH3YUY6i9Yo8PXJzGbkURb5LuVj7LkuZYpPygS5iUfiYXwrn0fhDj nVNOtXAS9uDXMsCDt27C4gOYWEqzu8JoF3mFul2X2B8hYQLOTMASSRtaOebm1Qp+wfIuKMI9iXh jEV8Db+vQSM1sjjWqzBiRWWOAk9bx+6hTucqoGWK18y8TOthqwM0gR3oLJtz1heScuWlAoGjMFS igbpbC4RiNzaKp3WC4RJwAICBVoLd8hywLOEPqd26nMlHg+cv5XWgOWGCiWdn1v7ScnFcWpQqzj E8tRjywJ+yvhe2TzNBVLHjkHpH1PLasBgGuESwNp0L2lmwwDWve8t X-Received: by 2002:a05:620a:8398:b0:8cb:39e0:1710 with SMTP id af79cd13be357-8cb8ca742f6mr951402185a.54.1771841202767; Mon, 23 Feb 2026 02:06:42 -0800 (PST) X-Received: by 2002:a05:620a:8398:b0:8cb:39e0:1710 with SMTP id af79cd13be357-8cb8ca742f6mr951400085a.54.1771841202314; Mon, 23 Feb 2026 02:06:42 -0800 (PST) Received: from brgl-qcom.local ([2a01:cb1d:dc:7e00:bd71:422c:5e83:8b37]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43970d54760sm18288885f8f.35.2026.02.23.02.06.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Feb 2026 02:06:41 -0800 (PST) From: Bartosz Golaszewski Date: Mon, 23 Feb 2026 11:06:18 +0100 Subject: [PATCH v2 05/14] reset: warn on reset-gpio release Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260223-reset-core-refactor-v2-5-5e5a7289190c@oss.qualcomm.com> References: <20260223-reset-core-refactor-v2-0-5e5a7289190c@oss.qualcomm.com> In-Reply-To: <20260223-reset-core-refactor-v2-0-5e5a7289190c@oss.qualcomm.com> To: Krzysztof Kozlowski , Philipp Zabel Cc: linux-kernel@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1110; i=bartosz.golaszewski@oss.qualcomm.com; h=from:subject:message-id; bh=cWpfqX93SvKzM3z2d3OuDKDlUpdlj9+kKcBHteEGi4g=; b=owEBbQKS/ZANAwAKAQWdLsv/NoTDAcsmYgBpnCakHxvE8jG4+fHEp4PaaOi/ftdu3MwoB9KR1 RNM00++2AeJAjMEAAEKAB0WIQSR5RMt5bVGHXuiZfwFnS7L/zaEwwUCaZwmpAAKCRAFnS7L/zaE w4kyD/9dOtpzsPzdNYTh6SK71dtIlCzrPYYWGpZMpT1LrpNtcDJQt7gKaEjrQpdejsHracE2zb+ eTvxCazAgZRbQMOPltb9wuoL4NtBVcsrclV8t20DGa2i9EuHEhc9J6y3wgpGv7lQx6sy/IarKF4 9l1WQ5Klzir7CsjZZwFYGxn7e9+fe5cGdVK2Ffpup6Vx1vELxvhJp74ZCHVoF35agpaH1Y7/Sc1 +gicsuSORQuc43RJcbYLmPM4Zc7LLPkxHP21Ha73ANaRzswhcs0Nkrc0KkY9QQggTY58hm19cAd cDRGhujGKjwjwGKaZs6wpr6CebZZQUKKOLM6sx046GbtPIr4lQuK0mgtnkU6uc2jJBYfypZ8QW+ 8D4YNZPv6S9SepojAjDo9P501y7pW02xUu/X9xKByNQj7TIbFTSd5iBWKV9LXHx97FRt/34uacv Xm8wFRaqyLchDWckpur6v0toYfJjRnHzbOaMC3Ksz4QbKFVV4EER3f8wvreLZK27e4Cp3z+uKDl U1RdJ6wjz6EuHYraPUMDWFYFbsata1X4kYh++GUyOg6k1Qqf91RJE+gGkkWsURXgsYDQURkaatQ 3uM0sy/b5zRF92E3KSuVjhKi31H0Fkt+CBk2LkOsNAFkboyEObtpg/FVZDaoHy9716ysnM2yn9h +DK2x6uXH1QkJSw== X-Developer-Key: i=bartosz.golaszewski@oss.qualcomm.com; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjIzMDA4NiBTYWx0ZWRfX7CWGw9NSOsbD Ghn7yUQ+oxtztLeVz+OUijR71qvp78zqxqOhjjvBgSMxaT9uOaTAyv2cX+dbvMEQIH8B6UH5afp PqU+NKojgjxahYlnys0QxhvbvrLf4LbKWsjJxvKvrffTqCpDtppc7Xp9CwRB9RGahauKdwNWoZx eV+5ILaL+xNt2RxV4IebDacbXrFMp7gDfOSxJoOV1LorKgBXhYjR21KAt7PGN0UuUsJV44JNWoa anadMV5X6JIDGJGjyFWDBKwizuIAY2Gu45J+1rCk0AtsNKSfe8z/Ed84YjpO/RRtkky1WjBwQkL p8FV/e67+tz93PLXIL2n/Jl3WtNXqtKjQEdvH1Lebcvek/SUmURIGvRZJtpbE/afpMilqJx+Dam v9SsKK/Irmwn7EU1N9BpzSYxaOwUSovnWthsVaAJORSIZi9MV4Eo5/trBCtDmuoXeSh8u1h3Wbu mCEkPy1RBdw/yaE0KwA== X-Authority-Analysis: v=2.4 cv=T5KBjvKQ c=1 sm=1 tr=0 ts=699c26b3 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=ZUnkwru6gbkhQxgbgcoA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-GUID: L_0vZR64zzJl9uDcj-dpUstr4wFp7-_o X-Proofpoint-ORIG-GUID: L_0vZR64zzJl9uDcj-dpUstr4wFp7-_o X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-23_02,2026-02-20_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 malwarescore=0 priorityscore=1501 clxscore=1015 phishscore=0 lowpriorityscore=0 adultscore=0 impostorscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602230086 While we implement an empty .release() callback for reset-gpio (driver core requires it), this function will never actually be called as nobody ever removes the device and the last reference is not dropped anywhere. This is by design - once created, the reset-gpio device stays in memory. Make the .release() callback emit a warning, should it ever be called due to a programming bug. Signed-off-by: Bartosz Golaszewski --- drivers/reset/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/reset/core.c b/drivers/reset/core.c index 954df36a242e804b639027384700b8d988be0e90..3e55f794d539e4edc99104cb5396cac72ba30618 100644 --- a/drivers/reset/core.c +++ b/drivers/reset/core.c @@ -820,7 +820,7 @@ static void __reset_control_put_internal(struct reset_control *rstc) static void reset_gpio_aux_device_release(struct device *dev) { - + WARN("reset-gpio device %s should never have been removed", dev_name(dev)); } static int reset_create_gpio_aux_device(struct reset_gpio_lookup *rgpio_dev, -- 2.47.3