From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B679346E78 for ; Mon, 23 Feb 2026 06:43:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771829039; cv=none; b=Yjh05Lyqa8PU0kmuF4Nb1iG4pFzlD83xKQTfM5BOjL3y3zhNiGIglsCvTZxh7HxsNbfN5QsTBhjBzm+j5cmItW4jGNPNe3jcvKMgVzenrpckjmniUbWzzle21ecfADUEEEr6Ju+mxAfCyGOgliGrMmyJYIhQFG70rt+4qrAaP64= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771829039; c=relaxed/simple; bh=OCqMqTV3Fk0GHlGjVJ0UFzNI1DHV1XFUgzJgSRR9AZA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KGZptCp30S6dtjU8Cfpf6onuHyW9yZSoq5uvnfuMwAX3WvTMvWluseyJIqrK6jXfn3UkhtIXIOI3Xxv2wt0ap1AfioFY+bvPqZ13B5PMnak/VTlXZYVabifDwUftyFSPHK9eoib2GrVJ9HhgBQrWmHLTeKt5evA239cz4OGB3I4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ibne/XYK; arc=none smtp.client-ip=209.85.167.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ibne/XYK" Received: by mail-lf1-f42.google.com with SMTP id 2adb3069b0e04-59b672f8ec4so3930528e87.1 for ; Sun, 22 Feb 2026 22:43:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771829035; x=1772433835; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+87770G0UGJrf+jBGNAZwy7BjuGZ53X0m5gpUF71N68=; b=ibne/XYKUYUTWuDiS7ANQLisCJtzd0wstNRGKhRQ70aR12RVZFFxkPazdFdlftzH/Z bC+XrFR4uiG2kg9RbAPr9xuQwFyvYoj8Itfgb9z8i/n/NCZB+4Qzk5YcmhTxRR438X+c XXGmzg5ewF4XQ8SJnj/fjeetBF8KkkYN62KQbemyhrJcwBJA+E39PkpNf5PqiXttLZfL XkKBha5enMHc7kER4Oy7c2Mk8njFfnF0zxm+zA4che26sS2SzkEplEOt1y0NDSM+27Pu 1cWt1l/QZMtr5X+1R4pYp5IIfNMKufztferiHXSxB99DaVhoRbXbhQEw5HWJXS8aSzMu A8+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771829035; x=1772433835; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=+87770G0UGJrf+jBGNAZwy7BjuGZ53X0m5gpUF71N68=; b=DtLqkw5KRzNmQ4akVRBhCCFuxLxl82ZFjpCjSHDaiV8WrsQDVpDDe/YbO8TVkX0DMh yiAhJrRCrKeeZTfUpRe5FCCs0usoU6YO/83u9dplLrtkQe95DvoYMepx6a0Z08uZT/A7 UAX7nSKJ/R3UT93SnJay0csZwsHMB5NeKciSnLrsgiCzwhi0XC5wzky06F2saeJik5XL jupa7wu8tngpTF7U5Foa1n/tkiRbegQpr1N/Bc2Yv6fNTAsyIDtDVZRqj9/a+QonLgI5 GhnykFth492D5WQoLt/aUDpbrenFyAYpG19H7KMrN91C+Sg7O8FnsZVGngJfFXF45LLR Tf9A== X-Gm-Message-State: AOJu0Yxu5EuEREfp2C+1MGUdGVzFvHaK0WUg96lPUKWpQQJtlURIdcu/ 9VDUkq8l6964SG8JbixUiMBk6ZdjUG8Dy80UU2ASJgbFxcarXvHG2witw4xrCQ== X-Gm-Gg: AZuq6aIcpWfJOqhPiASPcAVjfwVu84oi2XGlgzqBfiNN0j3w5PlVwgfaLZcICAfuHKA Tf2ryk40uJrzq7jzfg1TMpjy7Ucomvnp2vWG7bmGKP/eepAuVs9rLCuuz0GytX51xtc4FUQnvJE iFNPE7Y9Q9wzUwHzBQ1gGmWCvaKVhiB/p/oJQKI8j2VYkuEotg5fvPsJq4OtIu6gSSUN90bQPar Kyy7bQXTFQlV+6mNPR/0SActssdOyUwJ2JrmS5IqRF0pvK3Xxe4R+BF3ojRtXTMbS0qfAu7gr5j F/ub3YjtjUItDq0i1i3PxVGxnM0wV+ggXTt7PJUgSuM0ZPwbXrOQmm35OGnYWLsrZYlYa9hZMv8 NlPVin9Fd8uCfZUsAFKOtpV3FiTmiBhZUVRw7dW/IAVG2/kSMHsiTAs4SGpYKlCcLZ8CIVc6cRc DaocLMB0qoRRs0 X-Received: by 2002:a05:6512:1597:b0:59f:710c:5203 with SMTP id 2adb3069b0e04-5a0ed9ba448mr2052492e87.42.1771829035338; Sun, 22 Feb 2026 22:43:55 -0800 (PST) Received: from xeon ([188.163.112.76]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a0eeb3eb6dsm1363274e87.50.2026.02.22.22.43.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Feb 2026 22:43:55 -0800 (PST) From: Svyatoslav Ryhel To: Chanwoo Choi , Krzysztof Kozlowski , Lee Jones , Rob Herring , Conor Dooley , Alexandre Belloni , Svyatoslav Ryhel Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-rtc@vger.kernel.org Subject: [PATCH v2 2/2] rtc: max77686: convert to i2c_new_ancillary_device Date: Mon, 23 Feb 2026 08:43:43 +0200 Message-ID: <20260223064343.12516-3-clamor95@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260223064343.12516-1-clamor95@gmail.com> References: <20260223064343.12516-1-clamor95@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Convert RTC I2C device creation from devm_i2c_new_dummy_device() to i2c_new_ancillary_device() to enable the use of a device tree-specified RTC address instead of a hardcoded value. If the device tree does not provide an address, use hardcoded values as a fallback. This addresses an issue with the MAX77663 PMIC, which can have the RTC at different I2C positions (either 0x48, like the MAX77714, or 0x68, like the MAX77620). The MAX77620 value is used as the default. The I2C position of the MAX77663 is factory-set and cannot be detected from the chip itself. Signed-off-by: Svyatoslav Ryhel --- drivers/rtc/rtc-max77686.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c index 69ea3ce75b5a..3cdfd78a07cc 100644 --- a/drivers/rtc/rtc-max77686.c +++ b/drivers/rtc/rtc-max77686.c @@ -686,6 +686,11 @@ static int max77686_rtc_init_reg(struct max77686_rtc_info *info) return ret; } +static void max77686_rtc_release_dev(void *client) +{ + i2c_unregister_device(client); +} + static int max77686_init_rtc_regmap(struct max77686_rtc_info *info) { struct device *parent = info->dev->parent; @@ -713,12 +718,17 @@ static int max77686_init_rtc_regmap(struct max77686_rtc_info *info) goto add_rtc_irq; } - client = devm_i2c_new_dummy_device(info->dev, parent_i2c->adapter, - info->drv_data->rtc_i2c_addr); + client = i2c_new_ancillary_device(parent_i2c, "rtc", + info->drv_data->rtc_i2c_addr); if (IS_ERR(client)) return dev_err_probe(info->dev, PTR_ERR(client), "Failed to allocate I2C device for RTC\n"); + ret = devm_add_action_or_reset(info->dev, max77686_rtc_release_dev, + client); + if (ret) + return ret; + info->rtc_regmap = devm_regmap_init_i2c(client, info->drv_data->regmap_config); if (IS_ERR(info->rtc_regmap)) -- 2.51.0