From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC2D534CFCC for ; Mon, 23 Feb 2026 10:23:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771842227; cv=none; b=LHHdx1l6y5+Xbd/JPGk27XoaYSTfALB1BYZRPetmQUXd6c6D2LItQoASWKZBZIipS4YS4o9+WzYvz9AgU2wpPsMFdjENiihmI7sAFjsujkbhpmZ+ZLsm5NvxiH25NwWROTFmChNlOQvYoXDntndZxvJAYxjv5oy30otSO4YyVdY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771842227; c=relaxed/simple; bh=8H8C6h5DDJwdoU0xdxXQMeRVpisNrZDWGZJ+6o+yYdg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=Ssgm3j8b1OhWSA/JtRQaoizSwO63L6K7wxAG8a2bBXWR0t4zm72PuJasBTphtrcRAHlVQhJnO9nkZYfgPMsdX6UV7RXCbZIgVwbw44KJdETxxvXtlSoDJvpTbst+YaKfRJh1juVUDRiKMNvbLTwDMwxrWsVekXyYoPgB6GhF17c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=H0keSolb; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="H0keSolb" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-48379a42f76so32085235e9.0 for ; Mon, 23 Feb 2026 02:23:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1771842224; x=1772447024; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=nV+jaHXZ5H0pVA9k4tp7HLdqRtif45/+z1Z7Bw2P8sc=; b=H0keSolbZWVPG0oHfRGueQNJdn//ghGsnBtGyavVZMpqni/8Vy1fliF20BFy7bktmL INl6VarQPXXZf1icpbjlXEoum9krMAq+DWh7FCOvTAe4om3l5dXKctwQgorZCjsbld/j j5I3irdAByKigF08BrFTnsO+yC5exZsy+k7ntFWGJoSMxSoyObutEaSyxXD4VydmGXYS WYz+0ky1Sk+gJYgCV6seZ3IDXmI+7bVXa69aXsRsu8IK3Sb3qSwLkAsPzCHRA2W78sJh RQt3QEhQkeS1vklgHj8g10mSGyBm8sxBXwejVGBI+zcFy5JOCtZdWu50TvPi1e03jQPi vWkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771842224; x=1772447024; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nV+jaHXZ5H0pVA9k4tp7HLdqRtif45/+z1Z7Bw2P8sc=; b=fe6IF++9bmG1qsQ597jtgwzZAsUe3FCbZl4Uzfcdkp05mI1GIumsAkyYscmQXqlgC5 BEh1q6je0FyXQce1qhRmCW6o5L7zjPJJBd28u8wvsLrguKO/s6OIN5fZZhD3Z0Hx7kPo jvZi1BN/tOHPutTPNOldHhm3bzIbvGjMygVk2K3Xtl74NoOA6zs1l7FtiWJXdG444Si8 eUTzk5SD/jOb6/S2bbPO9cONLjZ4Ykr6+6GNyG1TAZCUjZJWiy1qjmLWZ9elj6Lqs+gf m9+Vbsi+BQ/BIfpsfBvFv/PJiVEVQQydjjduIAC/oOGzaie0DQE8i9Rmd57tHQHdbBQd j96A== X-Gm-Message-State: AOJu0YzETWNWkC+hbeKCI9YcOWu+af9Ls8UngtBGAnFEOmJD+BYGupL/ QBROUxhX/Vtr/u03cGwXYMUlJX+tRo1x06xwhcZN5IcwXIqfyMdS5Pb5kHUxtB1lxxweTrF5zXi HsXc/ X-Gm-Gg: AZuq6aLQrcx9bhlS8MT7VOcjEa6dLWPeX9ayYJqi8QAm4bIzkf8WNsPkgKHWO2rgk9h WuQs4DQS5VOCWqFWX66KEe6aKPY1MstYWBiG4ZjU7s/5Q1EA24ErJXkHBXhCj84sOOZllMwrCWy 0bCEGuvNYyF4zPNBzAbQJYpmoQQA/l9NpefRO66RATUaZpO2I8k7PEj54ZZIXyQxhR7OXZnMI1C eDMvzCP+sdEnerRsMGVPZCw8iKF/a+eJJhpgybRpy2AvBPox87qYesT2bOd7AhLN39SUwl3OvwP p0BvqggVJuo7hLTCHXFzfZhgquY3RP2lSRKMPnXNL5AgxDUM8ErKDQRDEqfF5oIWkseo959VYce ZiUo35WQGCG4GtZ76n4kgMkOP6K/rc+lqBJQRSe9uTdGVpS9UkiZyBlKTRDMn8ofCUY1ES3znf3 pZKYdbIdNsdnpjhaYNz0PK5nB36Tl31CXMIqrg4OdaJvMc X-Received: by 2002:a05:600c:3d87:b0:45d:f81d:eae7 with SMTP id 5b1f17b1804b1-483a9635c34mr112627865e9.28.1771842223876; Mon, 23 Feb 2026 02:23:43 -0800 (PST) Received: from linux.fritz.box.box ([2a00:6d43:105:c401:e307:1a37:2e76:ce91]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483a31bc0e3sm237342465e9.5.2026.02.23.02.23.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Feb 2026 02:23:43 -0800 (PST) From: Marco Crivellari To: linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org Cc: Tejun Heo , Lai Jiangshan , Frederic Weisbecker , Sebastian Andrzej Siewior , Marco Crivellari , Michal Hocko , Christoph Hellwig , Sagi Grimberg , Chaitanya Kulkarni , Justin Tee , Naresh Gottumukkala , Paul Ely Subject: [PATCH v2 0/3] replace old wq(s), added WQ_PERCPU to alloc_workqueue Date: Mon, 23 Feb 2026 11:23:26 +0100 Message-ID: <20260223102336.108512-1-marco.crivellari@suse.com> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi, === Current situation: problems === Let's consider a nohz_full system with isolated CPUs: wq_unbound_cpumask is set to the housekeeping CPUs, for !WQ_UNBOUND the local CPU is selected. This leads to different scenarios if a work item is scheduled on an isolated CPU where "delay" value is 0 or greater then 0: schedule_delayed_work(, 0); This will be handled by __queue_work() that will queue the work item on the current local (isolated) CPU, while: schedule_delayed_work(, 1); Will move the timer on an housekeeping CPU, and schedule the work there. Currently if a user enqueue a work item using schedule_delayed_work() the used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to schedule_work() that is using system_wq and queue_work(), that makes use again of WORK_CPU_UNBOUND. This lack of consistency cannot be addressed without refactoring the API. === Recent changes to the WQ API === The following, address the recent changes in the Workqueue API: - commit 128ea9f6ccfb ("workqueue: Add system_percpu_wq and system_dfl_wq") - commit 930c2ea566af ("workqueue: Add new WQ_PERCPU flag") The old workqueues will be removed in a future release cycle. === Introduced Changes by this series === 1) [P 1] Replace uses of system_wq system_wq is a per-CPU workqueue, but his name is not clear. Because of that, system_wq has been replaced with system_percpu_wq. 2) [P 2-3] add WQ_PERCPU to all relevant alloc_workqueue() users This change adds a new WQ_PERCPU flag to explicitly request alloc_workqueue() to be per-cpu when WQ_UNBOUND has not been specified. Thanks! --- Changes in v2: - improved commit logs - rebased on v7.0-rc1 Marco Crivellari (3): nvmet: replace use of system_wq with system_percpu_wq nvme: add WQ_PERCPU to alloc_workqueue users nvmet-fc: add WQ_PERCPU to alloc_workqueue users drivers/nvme/target/admin-cmd.c | 2 +- drivers/nvme/target/core.c | 5 +++-- drivers/nvme/target/fabrics-cmd-auth.c | 2 +- drivers/nvme/target/fc.c | 6 +++--- drivers/nvme/target/tcp.c | 2 +- 5 files changed, 9 insertions(+), 8 deletions(-) -- 2.51.1