From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E8E5633B967 for ; Mon, 23 Feb 2026 18:08:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771870082; cv=none; b=SCN9VI7gvmNntooo75Tcxor5F9CZ9vJF7KRfGq/l5yGoN4ALt0i/jfhoVbtYpSpf4EfqS5Z4/chTfkDqtFQoIuib7KA1aXOXPfcIIYkqsTnIbEBZ2H0cmdBz/iGIAyXiESqezDqpt7XjqUo01cXxu5vzbU8sRWIPkAAMAGS1YlE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771870082; c=relaxed/simple; bh=z0nBWK5+F2wsJrQIhtl6TV5njKOz8lu+80qf9G2Sim0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dp7zmkHqSfrCDWp0Uk30Yog51fBZ85F2z3Zo8yk6yNTMmEKmXQ0p7amn5Z1Y5Ko6hHb00VnBpYHY6JI0LAdHYK9plYe8DXBoP89TgAJv/xe9IxEa7cZrYTFMTMIuT9NSbwBYkMB2uhpH3mBCmKwszmAVPLx1DBqnV5c3r6fvv64= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=H8r2I+7K; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=gNU4R34I; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="H8r2I+7K"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="gNU4R34I" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61NAWDDu3732709 for ; Mon, 23 Feb 2026 18:08:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=vJxFLg7wg9k swXDRQsScAbUneSzeSw/ohZQ+0IC4ocg=; b=H8r2I+7KV8h3oqSJmnLDpVD5DrB TJAJH1j9/fPIoXssIrJ7o8VgeLWj5xTEq4mugrSm8EvoZgZ9DK8gpjFF+C3aJfCc p4KBiRrQmTADUN/TTtixKoLRU5nL1Xxz8OENvGrfTe9qkx8GKAPPvlzh1GkG5fUC EzW68UON0TZ4AfPm5VxTp7881nOW+R4Py310JLdoW/G3bI005QNpmmO8APk5ZaJN BXbXiMZgz1p4pwvBXpgu6V3kqbBKV73QKCOSoe+BLTzlcu/qImKRvr03uf9IdWjy 0DPKS8zrKQlzuorSIYCuxuKyXcj9QOGPhr4imCSebQlUCico9gBCf4NX/uw== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cgn7t9e8t-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 23 Feb 2026 18:07:59 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8cb3b0d938dso4795468585a.2 for ; Mon, 23 Feb 2026 10:07:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771870079; x=1772474879; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vJxFLg7wg9kswXDRQsScAbUneSzeSw/ohZQ+0IC4ocg=; b=gNU4R34IkcLXbdc5o9GztyjYW24HM3lcc8HC2O+wIHO2sF3Bi0/yNTaTX6PBwxKEpb t8O/zpJhX6Ekggb0QQ2r2nPpESaVy5IRUksaAMJQGqcGMwfLiGs0eOgvX9hzI52ITAa9 QafDfO5fRyBK+mi5vBVUHyfQFYMcaM/m5pVqod2hmpjqPIVJ7rQWw4BmkftsiCPY6NW4 vQis1O0cNpirHcZITg62FavG68CI8flx3CAECtQLjZw1lJJwHK8qmMwx8OAwCO98MKbF Z7G08THef+9HwPHiptNU2kYAhyuH0cPmf7y/tFuUE0ShSyykFHms02d/b1Y7UszWsDYJ USXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771870079; x=1772474879; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=vJxFLg7wg9kswXDRQsScAbUneSzeSw/ohZQ+0IC4ocg=; b=OeExRblDdcuDb85IGxeJJMrOFy0FCab3Eu/Y43CER6CWMlzvPrmPG43tEBNibboloO FEdycpYUaP6AQcPrGBW2mimBvobhJQv9cRKbbQtEACP4iRRqKu5MpYRbu6tu0nIdUm6d XqiLsUfypjBjfM+YFrNsswKWISmkPhzuU5zk9ocGLNveCTkeTISzkr6zxCFdxRZ93Zam hWyIaSlF8gJQYT5pIHgHj5y56GqCnbChrnrZ/7ADL3x5oR0c8iJuG6eQrTxtD8zBFgo1 i+pagCIKzfUZz3uKGrwHOAv5j7PeRhjXgUcCmam08a/2EI3xJyH8CUln2L1zjE0sG3Nj m1Sw== X-Forwarded-Encrypted: i=1; AJvYcCXQlCD+KpXgTVnvKalDJLlAC2/ZQAMvq77I+OyBZGPebTrJH2wL7b+Ij5DAINHl1jt5IxRZqDxG5TNqkKw=@vger.kernel.org X-Gm-Message-State: AOJu0Yxma/sx7xrSQ+zBptUxn70BDRVCFGyYDlZiJhokWE9v5U0ohlhL 661cS0E6kEDkeHmLGPD2Cb9M0juLM/ySQb4TbrUHo6ltE2usafT7nohNE5Dn4Q4eq/1EbZSIQGj noFjtDJnnyWUKORoXb/EFgLkczAUiGU8LwEf5M2e1Kce3SPt9JfUknbX6zYlgJgyPhYU= X-Gm-Gg: AZuq6aJ8GVU4JolvaeqMY8U3R3bWvWQ4clyciFTBYVthqC+Qj4x2pBXTLCKcRznHZf8 uipc2oSKnIRLWCai+jI2LZFG7k13yvSviGD5FICBLhq4N3woPTKALPEXHkxcHJAZiwcmolmbYSc 1hjhS8DVN9WCWlhnqVfOJy4b6ZZnobFH5pK4j0wzolXQ2n87wOMqr1GcZ6tpMNVxTjSrDYKC6K1 z7+/tdTqAx+XrIeQkDMMWATEVf3v3vnJeDE5X6JzTp91inmIcNr91rB07QVy3X5I0OQyfa42S8S eMemV3Tu8lwI8IHKWpoypct6lbqXaT0l0lnCERUgBMfA3UQbJJnTij+0ZsFDSRwIR2psbazI8WM droHaVaw253uOXwL0cwn/Gvt3RMkChD1U9GgQEWsCMrjV25FDrHYOipA= X-Received: by 2002:a05:620a:408c:b0:8cb:5176:f00 with SMTP id af79cd13be357-8cb8ca6731emr1093334185a.45.1771870079266; Mon, 23 Feb 2026 10:07:59 -0800 (PST) X-Received: by 2002:a05:620a:408c:b0:8cb:5176:f00 with SMTP id af79cd13be357-8cb8ca6731emr1093327785a.45.1771870078795; Mon, 23 Feb 2026 10:07:58 -0800 (PST) Received: from localhost.localdomain ([5.133.47.210]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43970d401aasm20458574f8f.23.2026.02.23.10.07.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Feb 2026 10:07:58 -0800 (PST) From: Srinivas Kandagatla To: broonie@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: mohammad.rafi.shaik@oss.qualcomm.com, linux-sound@vger.kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, johan@kernel.org, dmitry.baryshkov@oss.qualcomm.com, konrad.dybcio@oss.qualcomm.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, srini@kernel.org, Srinivas Kandagatla Subject: [PATCH v2 03/14] ASoC: qcom: qdsp6: topology: check widget type before accessing data Date: Mon, 23 Feb 2026 18:07:29 +0000 Message-ID: <20260223180740.444311-4-srinivas.kandagatla@oss.qualcomm.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260223180740.444311-1-srinivas.kandagatla@oss.qualcomm.com> References: <20260223180740.444311-1-srinivas.kandagatla@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=c5OmgB9l c=1 sm=1 tr=0 ts=699c9780 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=5HTw2GpdgXbBP0wXRk4A:9 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-GUID: 8iKCvHdxXQvU_lXp3ndcUr02HK2uX9i- X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjIzMDE1NiBTYWx0ZWRfX/2pZS/TnR29L 6UKdK4TLCIy1MsoppsfaiqYIeiRBNC/s5jkvAND8gCP4sKWKVrrMFHS9bGDA140ui0mY+gt+Hj0 6DbAuu1qU1NriQbFAChVVevL2PylKpidKdhrjHzQZfpl7sIsF1jupAsH6WixYjlODloc5Xiua57 AxMpCHPeQwDqHPsSZQ+k25tpl0PTW755+hdKfoLbEZvSbZdbKbR7uomvrK49mi7MU8q7CWgrBZE 6fEt0jY7J5giBWxujLF+I+1h5ehHdzFdnuGuw8Q82jrEDrDo62lV3herEuoxCAUlvCx/7T8TZG8 fsalKPdMofEsDT8ZgNSAgUX/gQH1oYdoimfvEcgagQu4ZwRme/4Gh1hJ4VHz58Or7OS01pyNiQ7 b9lX3baPyzvRLfBYBFoNUzdRW3Fs1+SoFR0azGaZoq640zYmvM63DRj5WAcxHXmL9NSSJd7n0zO IGpMhZ61KyZldl2Ho/w== X-Proofpoint-ORIG-GUID: 8iKCvHdxXQvU_lXp3ndcUr02HK2uX9i- X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-23_04,2026-02-23_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 impostorscore=0 malwarescore=0 lowpriorityscore=0 adultscore=0 clxscore=1015 bulkscore=0 spamscore=0 suspectscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602230156 Check widget type before accessing the private data, as this could a virtual widget which is no associated with a dsp graph, container and module. Accessing witout check could lead to incorrect memory access. Fixes: 36ad9bf1d93d ("ASoC: qdsp6: audioreach: add topology support") Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/topology.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/sound/soc/qcom/qdsp6/topology.c b/sound/soc/qcom/qdsp6/topology.c index 2e71eaa90441..80afcc817d78 100644 --- a/sound/soc/qcom/qdsp6/topology.c +++ b/sound/soc/qcom/qdsp6/topology.c @@ -952,9 +952,6 @@ static int audioreach_widget_unload(struct snd_soc_component *scomp, struct audioreach_container *cont; struct audioreach_module *mod; - mod = dobj->private; - cont = mod->container; - if (w->id == snd_soc_dapm_mixer) { /* virtual widget */ struct snd_ar_control *scontrol = dobj->private; @@ -963,6 +960,11 @@ static int audioreach_widget_unload(struct snd_soc_component *scomp, kfree(scontrol); return 0; } + mod = dobj->private; + if (!mod) + return 0; + + cont = mod->container; mutex_lock(&apm->lock); idr_remove(&apm->modules_idr, mod->instance_id); -- 2.47.3