From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C5771DEFE9 for ; Mon, 23 Feb 2026 21:09:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771880995; cv=none; b=llYZQNe5k4PP2weNRSBlIjabN60xVNsad7DceupZ1zD1N3nEM/DfcfmZQAnbGRDAWtRSst5HVCTsIQr3SW57uoW5Z63B9rlTreNpfwwxJQvbf2z/8m9qkm15IkWlaaKeJN9VSbrcSAVOp4o+vVkwdPRCiaSsObCrXtyD5mHXHSI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771880995; c=relaxed/simple; bh=lYSFLw0xah4h/+68xrRS+X6hzYryo1L2cUiMAzxuTP8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=g8duP9cXVgisHk9IoNUiRi31FwpFUL9xFgtZp+Jv2by/hh5CVaq7ZbeRMZvRC8xnwBEtWem8jhrVCiWHIrp8C5o1FuryCkeK1/1gvTuGDlV5Y/0ekTa6Fj7mp7WsNhjA0pM4KCb087mGatnSpSd76ha8oHcg262/w1cUc1WOf3s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WzfQf6nZ; arc=none smtp.client-ip=209.85.218.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WzfQf6nZ" Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-b8fa449e618so776306766b.0 for ; Mon, 23 Feb 2026 13:09:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771880993; x=1772485793; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GgYaJHOEUtfkRSeV4/ucyw2w3tzEF0ffgSH0n+B20gI=; b=WzfQf6nZdxHlompylB4hOEx3q+1otLGpFzW9O4cDp7LwK/eaSw+42gP/yWyDlt1dI2 j+Xzw/m34DOFxF1/TQfDtJG1fvG6gogbWn76PjNtN7TuE1kKT0UvqDK0TlGYgegm/ZOY su2KQOwxo+OkgwxJ3epio57PcSHC47UwYTvD+IuK9T0VcGoPThslVWnIQzPOB4U9Ry4W 4AGkEviZc1jQ38AUvGexiUZ1XS94eDd8QZvVUyPIIqWZ2KLJdVSGibzcD9XMUuLWChlp bpyaa6yL6TufdYdG1JEcd76EYH52MdIBz+qOxryZxPyHnW3lE+7S+SPE8z6O1lIeo6aP +oUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771880993; x=1772485793; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=GgYaJHOEUtfkRSeV4/ucyw2w3tzEF0ffgSH0n+B20gI=; b=UKeGroGo0aCzBZbajByxSlhR6Hh0nXrrwSjk2/DQERbF5pXpfaY8wRYHRlamyQf0ao 4uFFZe2sIEMdAs0Ee0r3N74BTXG1GAf6YnQhOKqmyniIdAul5dCB4ipJxEfNAn6vIOas v2IOU2Z+tVYkPkSZQxt30wB/yEzUVc8Dy8wNR7WuFYXm9/30sx2q9gP//0POwkEJJdim j0v132qKUl8hN0ES10gOLmcwzO8kTRBZI8Y/D02rJMAo+fjfdQwNPTznVWPf5FKHnZJS NuLK5tYpp8eAiSJrQK6fac0j3Vz69TAUm1Vjyqv2KSSWhAo5lqk+9JuQ2fb/BJczIFHA Vggw== X-Forwarded-Encrypted: i=1; AJvYcCV+yVG4U+HiAdoiutNCxN0HVPYNq1hinxFD+TZ/ADSxSYQoqArEBWiWg+Fj/tvPAOQqOOPiXI3SVgcRNWk=@vger.kernel.org X-Gm-Message-State: AOJu0YxTPQst/nVMI9I4jreTFvkCehIoANolFeY4bTJsPMg5I7A6gPXx hPxNviSt6+KaSo761Zb6SmpsGtKAmHYlhd/cqM/jBoXm4w+SBBYqy7lG X-Gm-Gg: ATEYQzwRvNh9ICxyEpJEAINPlWmSygkrDQv6HFageFh9OeWYaGUAOWgKO9G7ztvUM9o j1DnKrzLA8wFFfBXkCUsIOpxBFea4uJ4T8ivXAvqlAvhA5l6JSDUNabxr/QRwbVgcYdJTFvgjo6 Gc1lJVBgAoabm98XOhxkfrxwpYhak0e3NZIoUxQ61/Ec8Xbi5ITyEZhYQ4JBK5GmizKFeISHCVK bTLJ+azIP6e78Nx5ZwE1J0HLh2Uj4TPOu90vubJPIfgrs5V+8Ru1mHSsjjB4kBBeZ9hJnEErMR3 Y1n+k4mD5/NIjhq3sD1BplU0Vh4R74BGUQsekLz8slvnbgHjibywdwi8RIQoDCys2P7pT+wALaq +ImVlDozMa4KlGs0nQt0nZ+J8Iu5+2UNAXRAN6T+JYSlf+JknH3qWqIyU5Zqj7qjdqP4dMXcPpD X+ev01tPBudmOLsuRT0oYlwW37tM6+5HLVznc7CZpN/dWR86pzLclWirnlMDSaNOl+tIky6XEYJ FwuAZ7Cnbk7IqCE3IEbjb/0nAjwKVB+tmLGhtSFopjw/xO4kpNp79lYWz9T48bo15vUm6+c3tbY X-Received: by 2002:a17:907:3e02:b0:b8d:be68:bc24 with SMTP id a640c23a62f3a-b9081984f15mr662564766b.11.1771880992699; Mon, 23 Feb 2026 13:09:52 -0800 (PST) Received: from cs-874966990260-default.europe-west4-b.c.i2f7e30109524dc12-tp.internal (186.209.141.34.bc.googleusercontent.com. [34.141.209.186]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9084c5dcb2sm366399766b.6.2026.02.23.13.09.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Feb 2026 13:09:52 -0800 (PST) From: Artem Lytkin To: Greg Kroah-Hartman Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Artem Lytkin Subject: [PATCH v2 2/3] staging: most: dim2: use dev_err_probe and proper error codes for clock Date: Mon, 23 Feb 2026 21:09:49 +0000 Message-ID: <20260223210950.1900-3-iprintercanon@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260223210950.1900-1-iprintercanon@gmail.com> References: <20260216201921.1788-1-iprintercanon@gmail.com> <20260223210950.1900-1-iprintercanon@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace hardcoded -EFAULT returns with dev_err_probe() and PTR_ERR() when devm_clk_get() fails in fsl_mx6_enable(). This ensures the correct error code is propagated (e.g. -EPROBE_DEFER for deferred probing) and avoids log noise during probe deferral. Signed-off-by: Artem Lytkin --- drivers/staging/most/dim2/dim2.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/dim2.c index cea1ba99caf7..e4c8b4995c61 100644 --- a/drivers/staging/most/dim2/dim2.c +++ b/drivers/staging/most/dim2/dim2.c @@ -921,10 +921,9 @@ static int fsl_mx6_enable(struct platform_device *pdev) int ret; dev->clk = devm_clk_get(&pdev->dev, "mlb"); - if (IS_ERR(dev->clk)) { - dev_err(&pdev->dev, "unable to get mlb clock\n"); - return -EFAULT; - } + if (IS_ERR(dev->clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(dev->clk), + "unable to get mlb clock\n"); ret = clk_prepare_enable(dev->clk); if (ret) { @@ -936,9 +935,9 @@ static int fsl_mx6_enable(struct platform_device *pdev) /* enable pll */ dev->clk_pll = devm_clk_get(&pdev->dev, "pll8_mlb"); if (IS_ERR(dev->clk_pll)) { - dev_err(&pdev->dev, "unable to get mlb pll clock\n"); clk_disable_unprepare(dev->clk); - return -EFAULT; + return dev_err_probe(&pdev->dev, PTR_ERR(dev->clk_pll), + "unable to get mlb pll clock\n"); } writel(0x888, dev->io_base + 0x38); -- 2.43.0