From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from 013.lax.mailroute.net (013.lax.mailroute.net [199.89.1.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 176F93793C5 for ; Mon, 23 Feb 2026 21:52:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=199.89.1.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771883543; cv=none; b=JjYkevs2KPT8th8tSFI0GLxYsWAHTkxQlXGsC4BQFJSq+ecOpmAg3sQp9wcVNpfH5FJW3eRtYh/SMv9qvQS/mfSUlNUdX1gFRD7fRMboQwzRo7T/qgdWMAg3m70IxaTiKJlruNdC7/m/bu17YmNZG/eShkajb2NpaadTX4G4A/M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771883543; c=relaxed/simple; bh=NYYASPEOWb6Q0YEVzcpHEKl6xm6AKKmKSrXtd5fUvCU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Oi79l60I9W7Ztd2qsYqHRhUvP1C8kJXzJES/4jogsieb4bYAiTGVge6kwVTM/hAznNoM5gQUmTxSiT4I7kEudrSuBICcfpjqZDTDuFJQ5tdd/PYaAR/Agjjf5QXqm8hKQG9/UH7mYmszdzORRW3l+2Vl2TYYzw7+pm/gDBTCyAg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=acm.org; spf=pass smtp.mailfrom=acm.org; dkim=pass (2048-bit key) header.d=acm.org header.i=@acm.org header.b=m6CXafkP; arc=none smtp.client-ip=199.89.1.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=acm.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=acm.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=acm.org header.i=@acm.org header.b="m6CXafkP" Received: from localhost (localhost [127.0.0.1]) by 013.lax.mailroute.net (Postfix) with ESMTP id 4fKZMS5hyDzlfl6N; Mon, 23 Feb 2026 21:52:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=acm.org; h= content-transfer-encoding:mime-version:references:in-reply-to :x-mailer:message-id:date:date:subject:subject:from:from :received:received; s=mr01; t=1771883537; x=1774475538; bh=FKL1z AbzuQm/DVssvwrbDTSQOGpHE8XdSgHaKLIImYI=; b=m6CXafkPgqNX3CXuFRCPR q4dop4I0CArt6VY59MPCGs7gXvkeYDkHuhwFWK1IvJqH61UauNagUgXjdKPJkODP Y76gYIfFQ93NUXM/ZalTazXVivjC3fApBn3Wagnp178dvU3zbHEvbhFGjZDCc9gc mVOTqsopf5RbK5I86z70VI/8fvp6sSQ12Zk47DSUu6H4h/9KCrPJD65MnO35j27Q cHyTAChhVchz6DP6S6DqEnMLsNrZVLYyeKIKI3Yp51LbT+//fMgQWhmFgDzzenAF sr1TC7aBNEoYNAke3ZxgIwh6tdwAdGSjvBsZFr1sXr7aV+kr1kkCndpziJA8szPA w== X-Virus-Scanned: by MailRoute Received: from 013.lax.mailroute.net ([127.0.0.1]) by localhost (013.lax [127.0.0.1]) (mroute_mailscanner, port 10029) with LMTP id 2NCPEeGTtZYP; Mon, 23 Feb 2026 21:52:17 +0000 (UTC) Received: from bvanassche.mtv.corp.google.com (unknown [104.135.180.219]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bvanassche@acm.org) by 013.lax.mailroute.net (Postfix) with ESMTPSA id 4fKZMJ0cVYzlh1Wk; Mon, 23 Feb 2026 21:52:11 +0000 (UTC) From: Bart Van Assche To: Peter Zijlstra Cc: Ingo Molnar , Will Deacon , Boqun Feng , Waiman Long , linux-kernel@vger.kernel.org, Marco Elver , Christoph Hellwig , Steven Rostedt , Nick Desaulniers , Nathan Chancellor , Kees Cook , Jann Horn , Bart Van Assche , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Swapnil Jakhade , Tomi Valkeinen Subject: [PATCH 09/62] drm: bridge: cdns-mhdp8546: Fix a locking bug in an error path Date: Mon, 23 Feb 2026 13:50:24 -0800 Message-ID: <20260223215118.2154194-10-bvanassche@acm.org> X-Mailer: git-send-email 2.53.0.371.g1d285c8824-goog In-Reply-To: <20260223215118.2154194-1-bvanassche@acm.org> References: <20260223215118.2154194-1-bvanassche@acm.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Do not unlock mhdp->mbox_mutex if it has not been locked. This bug has been detected by the Clang thread-safety analyzer. Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Robert Foss Cc: Laurent Pinchart Cc: Jonas Karlman Cc: Jernej Skrabec Cc: Swapnil Jakhade Cc: Tomi Valkeinen Fixes: fb43aa0acdfd ("drm: bridge: Add support for Cadence MHDP8546 DPI/D= P bridge") Signed-off-by: Bart Van Assche --- drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c b/driver= s/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c index 9392c226ff5b..ce4516de11d8 100644 --- a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c +++ b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c @@ -502,8 +502,7 @@ int cdns_mhdp_adjust_lt(struct cdns_mhdp_device *mhdp= , unsigned int nlanes, =20 if (nlanes !=3D 4 && nlanes !=3D 2 && nlanes !=3D 1) { dev_err(mhdp->dev, "invalid number of lanes: %u\n", nlanes); - ret =3D -EINVAL; - goto out; + return -EINVAL; } =20 payload[0] =3D nlanes;