From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from 013.lax.mailroute.net (013.lax.mailroute.net [199.89.1.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 723C337A484 for ; Mon, 23 Feb 2026 21:52:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=199.89.1.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771883546; cv=none; b=giHb336ZifHIr5hL1AI40cT9IAJlh3ZBkeTRBczfN2l09HnGnRZd3rv+lfPlkphCaYEcqqFnY6CfoxBJzrfMpC3FJwwrTuQQnQleFVPMXesIaxm4TUTnxFyOd3vRRbZrDk+bjXJRzQfCHnk02fe01fTj0x72Xt7bo2t3k8/lHYA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771883546; c=relaxed/simple; bh=6ydWV6AeQZiQhhdwfu5StMyhFsoMkUQ4E8FptlX1Kao=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ALULLM63QnIr4zOJKiCnNpJg/8xGsu5FSBQvaGDdDvF1tRFc+wpNZoKPRKkOzATO5lVxJe/Ki9vFTSqO99xZAYi1lj91IL7MWI53GL34m59byWMF1BqoNfyx+KYBq07MMpB18owSkqiwwWQYwnMa4ZW28athzSIUizZiECKI4Wo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=acm.org; spf=pass smtp.mailfrom=acm.org; dkim=pass (2048-bit key) header.d=acm.org header.i=@acm.org header.b=1M5Cqi2b; arc=none smtp.client-ip=199.89.1.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=acm.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=acm.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=acm.org header.i=@acm.org header.b="1M5Cqi2b" Received: from localhost (localhost [127.0.0.1]) by 013.lax.mailroute.net (Postfix) with ESMTP id 4fKZMY0GhqzlfgQH; Mon, 23 Feb 2026 21:52:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=acm.org; h= content-transfer-encoding:mime-version:references:in-reply-to :x-mailer:message-id:date:date:subject:subject:from:from :received:received; s=mr01; t=1771883541; x=1774475542; bh=OvI1u avbzQViNWyaGgvMC9y/22qqPBqRhNJLziI1iFQ=; b=1M5Cqi2buVuaf67cDCFPp Ts9GgmySoPIjhTz53kijTTrJU1p8gXXjJ5NyBKJq+gJBjitg0NO8b2BbW6aW9i6H mAV7RMsWIuM1virMZukIClB+UlprWkMAziwh3fzLOWg3FLZLfmNHwNYIYyRRpIkk 53kNKK1XRH/EWYV84avoWF/FvrhGiI6qfr8ZXTxj0y4dwlWAvxWypMyNLpCrgO/x 3OiOPiGgf+xxI2JBG7rwdqApW+U2yGmjjTChIq5nwxPOF4cD8e4zP+8oZMKKtX+N efJv/EZhzhks0DapMEFWdadkO9w2Zejv5VAsX2rK8OrB1QxY7tB5peXyngKnsmI6 g== X-Virus-Scanned: by MailRoute Received: from 013.lax.mailroute.net ([127.0.0.1]) by localhost (013.lax [127.0.0.1]) (mroute_mailscanner, port 10029) with LMTP id yjuXiimT25aQ; Mon, 23 Feb 2026 21:52:21 +0000 (UTC) Received: from bvanassche.mtv.corp.google.com (unknown [104.135.180.219]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bvanassche@acm.org) by 013.lax.mailroute.net (Postfix) with ESMTPSA id 4fKZMP67c9zlh2fD; Mon, 23 Feb 2026 21:52:17 +0000 (UTC) From: Bart Van Assche To: Peter Zijlstra Cc: Ingo Molnar , Will Deacon , Boqun Feng , Waiman Long , linux-kernel@vger.kernel.org, Marco Elver , Christoph Hellwig , Steven Rostedt , Nick Desaulniers , Nathan Chancellor , Kees Cook , Jann Horn , Bart Van Assche , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann Subject: [PATCH 10/62] drm: Make drm_read() easier to analyze Date: Mon, 23 Feb 2026 13:50:25 -0800 Message-ID: <20260223215118.2154194-11-bvanassche@acm.org> X-Mailer: git-send-email 2.53.0.371.g1d285c8824-goog In-Reply-To: <20260223215118.2154194-1-bvanassche@acm.org> References: <20260223215118.2154194-1-bvanassche@acm.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Prepare for enabling the Clang thread-safety analyzer by duplicating a return statement. No functionality has been changed. Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Signed-off-by: Bart Van Assche --- drivers/gpu/drm/drm_file.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_file.c b/drivers/gpu/drm/drm_file.c index ec820686b302..200979d78452 100644 --- a/drivers/gpu/drm/drm_file.c +++ b/drivers/gpu/drm/drm_file.c @@ -572,8 +572,9 @@ ssize_t drm_read(struct file *filp, char __user *buff= er, mutex_unlock(&file_priv->event_read_lock); ret =3D wait_event_interruptible(file_priv->event_wait, !list_empty(&file_priv->event_list)); - if (ret >=3D 0) - ret =3D mutex_lock_interruptible(&file_priv->event_read_lock); + if (ret < 0) + return ret; + ret =3D mutex_lock_interruptible(&file_priv->event_read_lock); if (ret) return ret; } else {