From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from 013.lax.mailroute.net (013.lax.mailroute.net [199.89.1.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E14337A492 for ; Mon, 23 Feb 2026 21:52:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=199.89.1.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771883551; cv=none; b=nB4F6zRR3kFUx2LczPlYGH5oZhCZEjKGNQiagPC97+qQhSAPuRJz0uJkQR615ohN1VAMCE33vpesEcMuD8xfoswvzzaZseBnPjYDHwVIkRMNfvwUORy7ibsJFH3sy9hD/DYQSXLY58ugoR+OLXHentVDFvqCAQdqeqpinCcBjT8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771883551; c=relaxed/simple; bh=e8870KR82WwIYWd5sVXb7rbWaoT/JxAp0Ph66ZWyiTk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=azYrXdpdNQekYCPAmfLWbrsNLQ5SMt+vvTpMOr/ip0cDT1x3dfn0paeMeIlJ5GBBIL+NWLKzNCqaZFx9fgk86e9OBOq1+J3NX/HFug2Ck3OiqYBANxuuc/BBksLww3i1tOPiYLNo+bvRP6XKWewQimzJdoJqEyQDw48vpJcNEOs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=acm.org; spf=pass smtp.mailfrom=acm.org; dkim=pass (2048-bit key) header.d=acm.org header.i=@acm.org header.b=lF0N02J9; arc=none smtp.client-ip=199.89.1.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=acm.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=acm.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=acm.org header.i=@acm.org header.b="lF0N02J9" Received: from localhost (localhost [127.0.0.1]) by 013.lax.mailroute.net (Postfix) with ESMTP id 4fKZMd6Vwdzlh2fK; Mon, 23 Feb 2026 21:52:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=acm.org; h= content-transfer-encoding:content-type:content-type:mime-version :references:in-reply-to:x-mailer:message-id:date:date:subject :subject:from:from:received:received; s=mr01; t=1771883546; x= 1774475547; bh=t4wvtEISV40qls13t6NfT9B2mu1gvLkKzyQwNoMAJDk=; b=l F0N02J9cR4+CSc/3F1BzXvKxLQdNvKQyw2Gjf5Mjrji+umM8UpNYEstrHWo15dA/ VKWwYJXUlO6ad6EwFflu0UJ2AzghuUc3tvOSQAWfXDAxFDA1loL/nbAQT2MrgXoU oXDkWzYO3m8yRlz5L9mzIUTxt281195uLi6/rie/9JediOznj3HdSiOCGJc9OrCt xzYJ5LGu9SBq9/FND7Wg9Elgdn+r16UfVTJ14LbYCoHYOn+1/FE3bZ9gKarcMPJb gPQYK/VidnS7Si4tmICY4gLoCknbYu+4VgTZoA7Dee4Txk62O/JYN1r8HiL/+MJu dPTZkoKQRnQn8CTlhZ4Lg== X-Virus-Scanned: by MailRoute Received: from 013.lax.mailroute.net ([127.0.0.1]) by localhost (013.lax [127.0.0.1]) (mroute_mailscanner, port 10029) with LMTP id 4Y9fX0RcDABf; Mon, 23 Feb 2026 21:52:26 +0000 (UTC) Received: from bvanassche.mtv.corp.google.com (unknown [104.135.180.219]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bvanassche@acm.org) by 013.lax.mailroute.net (Postfix) with ESMTPSA id 4fKZMV25dGzlh2fH; Mon, 23 Feb 2026 21:52:22 +0000 (UTC) From: Bart Van Assche To: Peter Zijlstra Cc: Ingo Molnar , Will Deacon , Boqun Feng , Waiman Long , linux-kernel@vger.kernel.org, Marco Elver , Christoph Hellwig , Steven Rostedt , Nick Desaulniers , Nathan Chancellor , Kees Cook , Jann Horn , Bart Van Assche , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , =?UTF-8?q?Thomas=20Hellstr=C3=B6m?= , Matthew Brost Subject: [PATCH 11/62] drm/pagemap: Unlock cache->lock before freeing it Date: Mon, 23 Feb 2026 13:50:26 -0800 Message-ID: <20260223215118.2154194-12-bvanassche@acm.org> X-Mailer: git-send-email 2.53.0.371.g1d285c8824-goog In-Reply-To: <20260223215118.2154194-1-bvanassche@acm.org> References: <20260223215118.2154194-1-bvanassche@acm.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Although freeing a spinlock without unlocking it is fine, this confuses static analyzers. Hence this patch. Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: Thomas Hellstr=C3=B6m Cc: Matthew Brost Signed-off-by: Bart Van Assche --- drivers/gpu/drm/drm_pagemap_util.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/drm_pagemap_util.c b/drivers/gpu/drm/drm_pag= emap_util.c index 14ddb948a32e..50cb5f9cdac5 100644 --- a/drivers/gpu/drm/drm_pagemap_util.c +++ b/drivers/gpu/drm/drm_pagemap_util.c @@ -74,6 +74,8 @@ static void drm_pagemap_cache_fini(void *arg) cache->dpagemap =3D NULL; spin_unlock(&cache->lock); drm_pagemap_destroy(dpagemap, false); + } else { + spin_unlock(&cache->lock); } =20 out: