From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from 013.lax.mailroute.net (013.lax.mailroute.net [199.89.1.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C421137AA92 for ; Mon, 23 Feb 2026 21:52:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=199.89.1.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771883555; cv=none; b=lUbhVsRz/XGq9Ue0dPtsGEKYobTKrjwKc6+uIPdB1JouOCQqIUYAD5b371pfYliOV3MQhwAJbum1rs726xdsdUqupTuEWh2NSUBzdgGmM4LThfrnUkRh3p0hcgNYZMJyPFKv1dbKWDB/+0ZRhUqLb3yStw0UE9ZaEoh9iOo6StM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771883555; c=relaxed/simple; bh=BzSGx3QHmZte3rFZXL0yUx3Yzt3kiUhSkTo6aPzxG0U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=d3ChXWOSy6wnqqA/Zs5zTla6Jc/bFcxeOKykVms+W6qlZDq37T3JP4Du2WNRGJohLHM7uo84sMPmcyfGZ8MJiAeD9CMooFe7hooQrO0jqRTxuCaWHXn1wpvi8gjSnNOrW7D58lFcJ5f+iBL1kCVTsLlOH691SB50W46eeWYppLo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=acm.org; spf=pass smtp.mailfrom=acm.org; dkim=pass (2048-bit key) header.d=acm.org header.i=@acm.org header.b=cIJTTpwz; arc=none smtp.client-ip=199.89.1.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=acm.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=acm.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=acm.org header.i=@acm.org header.b="cIJTTpwz" Received: from localhost (localhost [127.0.0.1]) by 013.lax.mailroute.net (Postfix) with ESMTP id 4fKZMk46kCzlh2fH; Mon, 23 Feb 2026 21:52:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=acm.org; h= content-transfer-encoding:content-type:content-type:mime-version :references:in-reply-to:x-mailer:message-id:date:date:subject :subject:from:from:received:received; s=mr01; t=1771883551; x= 1774475552; bh=CAL/IP74sGa/WgkpjtZBT/RYQPOkKCQz/vgCG/KMe0c=; b=c IJTTpwzfYvGHrlYdTQRxQLFfMZoRoejBgtYbn8M/kjx7XCQg0gumZvIU26/HMocd mRjZjkSwlopMbg3M6MpQD5xpt5UUImXfo7HdOOfUkJ7LGO9V4Zj+LF3S5MTdxRh8 bmxPJ7Nkzbo6JjUGe7XhnTtTOuZzqLXPtICSPDo16EnP4H7pItsEUFJnftBt4ALB Gk+m3uAqgWvc0BvgIL2AYjLSC6A3bOXn4GIOwAF7SpNcBefHKL4LP1La+Dpf5i9T J1JJIMNmoDfzjyddVKPMRvhebdYB2Fih/nS05yUlsjA9sTxuJM3Wnz0L+sDeQQLZ VkQWdZtXN1oTU2JdfU6Yw== X-Virus-Scanned: by MailRoute Received: from 013.lax.mailroute.net ([127.0.0.1]) by localhost (013.lax [127.0.0.1]) (mroute_mailscanner, port 10029) with LMTP id 7s-i7hPRnn3L; Mon, 23 Feb 2026 21:52:31 +0000 (UTC) Received: from bvanassche.mtv.corp.google.com (unknown [104.135.180.219]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bvanassche@acm.org) by 013.lax.mailroute.net (Postfix) with ESMTPSA id 4fKZMb1dNjzlh2fJ; Mon, 23 Feb 2026 21:52:26 +0000 (UTC) From: Bart Van Assche To: Peter Zijlstra Cc: Ingo Molnar , Will Deacon , Boqun Feng , Waiman Long , linux-kernel@vger.kernel.org, Marco Elver , Christoph Hellwig , Steven Rostedt , Nick Desaulniers , Nathan Chancellor , Kees Cook , Jann Horn , Bart Van Assche , =?UTF-8?q?Thomas=20Hellstr=C3=B6m?= , Matthew Brost , Himal Prasad Ghimiray , Maarten Lankhorst Subject: [PATCH 12/62] drm/gpusvm.c: Fix a locking bug in an error path Date: Mon, 23 Feb 2026 13:50:27 -0800 Message-ID: <20260223215118.2154194-13-bvanassche@acm.org> X-Mailer: git-send-email 2.53.0.371.g1d285c8824-goog In-Reply-To: <20260223215118.2154194-1-bvanassche@acm.org> References: <20260223215118.2154194-1-bvanassche@acm.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Only call drm_gpusvm_notifier_unlock() if drm_gpusvm_notifier_lock() was called first. This has been detected by the Clang thread-safety analyzer. Compile-tested only. Cc: Thomas Hellstr=C3=B6m Cc: Matthew Brost Cc: Himal Prasad Ghimiray Cc: Maarten Lankhorst Fixes: f1d08a586482 ("drm/gpusvm: Introduce a function to scan the curren= t migration state") Signed-off-by: Bart Van Assche --- drivers/gpu/drm/drm_gpusvm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_gpusvm.c b/drivers/gpu/drm/drm_gpusvm.c index 24180bfdf5a2..e9b79ab2f83c 100644 --- a/drivers/gpu/drm/drm_gpusvm.c +++ b/drivers/gpu/drm/drm_gpusvm.c @@ -819,7 +819,7 @@ enum drm_gpusvm_scan_result drm_gpusvm_scan_mm(struct= drm_gpusvm_range *range, =20 if (!(pfns[i] & HMM_PFN_VALID)) { state =3D DRM_GPUSVM_SCAN_UNPOPULATED; - goto err_free; + goto unlock; } =20 page =3D hmm_pfn_to_page(pfns[i]); @@ -856,9 +856,10 @@ enum drm_gpusvm_scan_result drm_gpusvm_scan_mm(struc= t drm_gpusvm_range *range, i +=3D 1ul << drm_gpusvm_hmm_pfn_to_order(pfns[i], i, npages); } =20 -err_free: +unlock: drm_gpusvm_notifier_unlock(range->gpusvm); =20 +err_free: kvfree(pfns); return state; }