From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from 013.lax.mailroute.net (013.lax.mailroute.net [199.89.1.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F399F3793CF for ; Mon, 23 Feb 2026 21:52:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=199.89.1.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771883531; cv=none; b=dE8B5X63PDHgPKHEEAY0utG9MyXfGcY5vmSyaZUZxOSQhpHSEK7qiMNt29QL/OeOlA7WyOvTDMxjypyTu/RhqJF0WI3UIwpRJuLr0UD5nW/XjKjiIXVGIB0BRV1B8mMkqR0hi+PgCWMb94D6ksckEqQsmlV0O6hwCDW12r3ZK9I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771883531; c=relaxed/simple; bh=OEjYecRpew9d2fcCvsR+4YhxcBK/AufRe3AxbS3fFig=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=DDvJ+PQ2/YPGiniAVRlZ1uuNzlE9YibG8cXLTa+ot2aCJFbCcvyeWH4nC1iNZ1d1joow1f50whEaEn7+4CqGT1K1g8Zx0mUDhMPxY2t4YhPRSluHVONSTkkJtGRQudcRaoxZi2QmgwOEX48alB7ScsM2Fom9HHXjI0qbauHBU8g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=acm.org; spf=pass smtp.mailfrom=acm.org; dkim=pass (2048-bit key) header.d=acm.org header.i=@acm.org header.b=CDO7fvLt; arc=none smtp.client-ip=199.89.1.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=acm.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=acm.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=acm.org header.i=@acm.org header.b="CDO7fvLt" Received: from localhost (localhost [127.0.0.1]) by 013.lax.mailroute.net (Postfix) with ESMTP id 4fKZMF5dlSzlh2fC; Mon, 23 Feb 2026 21:52:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=acm.org; h= content-transfer-encoding:content-type:content-type:mime-version :references:in-reply-to:x-mailer:message-id:date:date:subject :subject:from:from:received:received; s=mr01; t=1771883526; x= 1774475527; bh=rEwFEZTUSl6LNKSqrsL5gdSMoPWPvyg78DBwTRH1PVQ=; b=C DO7fvLt/K74uWhcRCH/lVvpaNdFS/cm1qnpLXmrVSdyZvuMt9gF3m7oGUbAag0jK 5cro3C8kkjAazy+LUaOoa7BLdSOWyv0w277kipwEbDVcfIE3768yqK/OiAlt5rET mq4rC1551uwB/aUvqa1xhpM7Te+kRMRLq+/R34++OoiaJqaJqPn5RIKLDBahH9Ht GGuWAZkW9OSWsV2IivNiHUd0Mw928pu2ztyU9o01d5FcKAjGuGuInNFpZUfzuo68 aj00lYJ+Iw239caHZRDUneeoJC5ucS88fsiIBe9BEur0r6aGhaN969gQaN6bMdkW Ce/I4JzewRyJwzB9kN5bQ== X-Virus-Scanned: by MailRoute Received: from 013.lax.mailroute.net ([127.0.0.1]) by localhost (013.lax [127.0.0.1]) (mroute_mailscanner, port 10029) with LMTP id LHQb9KUdfYmU; Mon, 23 Feb 2026 21:52:06 +0000 (UTC) Received: from bvanassche.mtv.corp.google.com (unknown [104.135.180.219]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bvanassche@acm.org) by 013.lax.mailroute.net (Postfix) with ESMTPSA id 4fKZM556L2zlh1Wk; Mon, 23 Feb 2026 21:52:01 +0000 (UTC) From: Bart Van Assche To: Peter Zijlstra Cc: Ingo Molnar , Will Deacon , Boqun Feng , Waiman Long , linux-kernel@vger.kernel.org, Marco Elver , Christoph Hellwig , Steven Rostedt , Nick Desaulniers , Nathan Chancellor , Kees Cook , Jann Horn , Bart Van Assche , Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , Yang Wang , Hawking Zhang , amd-gfx@lists.freedesktop.org Subject: [PATCH 07/62] drm/amdgpu: Unlock a mutex before destroying it Date: Mon, 23 Feb 2026 13:50:22 -0800 Message-ID: <20260223215118.2154194-8-bvanassche@acm.org> X-Mailer: git-send-email 2.53.0.371.g1d285c8824-goog In-Reply-To: <20260223215118.2154194-1-bvanassche@acm.org> References: <20260223215118.2154194-1-bvanassche@acm.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Mutexes must be unlocked before these are destroyed. This has been detect= ed by the Clang thread-safety analyzer. Cc: Alex Deucher Cc: Christian K=C3=B6nig Cc: Yang Wang Cc: Hawking Zhang Cc: amd-gfx@lists.freedesktop.org Fixes: f5e4cc8461c4 ("drm/amdgpu: implement RAS ACA driver framework") Signed-off-by: Bart Van Assche --- drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c b/drivers/gpu/drm/am= d/amdgpu/amdgpu_aca.c index afe5ca81beec..db7858fe0c3d 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c @@ -641,6 +641,7 @@ static void aca_error_fini(struct aca_error *aerr) aca_bank_error_remove(aerr, bank_error); =20 out_unlock: + mutex_unlock(&aerr->lock); mutex_destroy(&aerr->lock); } =20