From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B291379978 for ; Mon, 23 Feb 2026 21:57:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771883864; cv=none; b=T2paOZp+/tP2JLh+LioBO7kbVZjGDL+ERdOxVkgPR+xLTlJ1oR2VJU1pyHWIQ44khJa219NONV+/1j2PqocrXAQGSWWjU7wGgAQ1gWYel7JclbzkfpR7NjoHMUtIpQjOWUaHDCy4y7C1f8fwkV017hNs3TTuS0+Igaft0/+Rh+0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771883864; c=relaxed/simple; bh=7oo9T8B+FeTgiTuGE51KQBYrxr/r6RR5TDgp6mMWUEg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=duOuJ27m10kNsTcJKd4sTrV8kWR3rMPg2fwOjf/BWGlfnJCnqmGfbxoaPSlx4CncYOIjkl/oaxamfSstDOk7xfS3ZornKnFHywGkIZ5HFoTZHlfa+do5UVnh3xcDQSSn1+DnaHt5HBY+YDha9kkkvd4orfSU/l4fzccMKOXKQ2M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YatqPKnz; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YatqPKnz" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2ab46931cf1so35505595ad.0 for ; Mon, 23 Feb 2026 13:57:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771883863; x=1772488663; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Zd8TDmTMVMgTxvBQpe26DMVz8nZYPD6skY/6JxqF5/M=; b=YatqPKnzP+WYsN+WDmf2+7XbUUp2NCtgiU5ayD7EZhDH8PCOwP66lMLTWYoWSCXTyG bj2M4JNp10BlKBeEOWvFhIqIincneZztklwKcNXUFDPc00xNxCJds9MTkUjsmcPmxsk1 hPf0Xy8N/XhCq3cN8wxk7iqSrOWCrPwk+P2znDhYGB3RFE/TC94xVsIo43wIYUP3os2k 9uHVNssbZPoKHw45mUBU9/TpZNhi2gnByTXinDijIHIJMEOMVtN6iajG2IYFcVJQvq61 sSjkYfpA0HRbkxyFfI2rmkqkD2i31ypEzGSahsbIVFP56k/cUEzHB+wBPJCEUQOAPULW NUJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771883863; x=1772488663; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Zd8TDmTMVMgTxvBQpe26DMVz8nZYPD6skY/6JxqF5/M=; b=WZgQU9IZkKed3OM6qVPFHb6zjzMD48840dhZonGBY76jRSQaGA8XHtLW47CaFWOj/9 ILGRiBgjGyqIX+SkLSQX3lowHgYp12CFtDQ5UKsIaxSvgbnJX37N+z21/O+ufZX/cMfi +VS0dfohlMZpeyyx/Gsgss6QYkfw5WoaArB7pv2Dcfmx56E7E5ssybK5mz8iMabAhyaU 4p3oTI17V81eq7pTzg4X4nSf7njaRQKYQOHDr8nO4dkaC+feynyhILxfhP81acWbZH6c W8qzxgxzfE7dix0LQWPg9rS/F2+zYhyRhEh2kcETfpg9Vh3hmHDIXHdpaBrJFCKI5F+c WC+Q== X-Forwarded-Encrypted: i=1; AJvYcCUnakgmvJ4ZcFC3+7jtK6wA1ksZSckhQauS/p3AtinEDpPr96kuOlTOVZhJ0eze5TYh7lyMdJTl0UrrvsQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwkmteXjD1u/nC0TEJ3HSM6emFOUgJPjxuVGRUfBAddCl8XgHDe bsimYHOxBxBtJxJoks3PhGrO53id596/NvNj1gnmZPbb7e/3zIua0o72 X-Gm-Gg: ATEYQzzYcnDT3K9MEos0hZS3v2kG9qmK4AHq7m3gKH8+EgIvrx9YCskhW6TYKYbjuIB s9kXFaO8qz3QiVul0B4kwzxzN8/KY0xeXdjhlKV7C+1JGEmLRABSHA3B8lvvwaZxAxGXV0VvbTm oSbmE4l0rF2m9PVtyHrtqFI3hPayJqb9KMICAcrXLt6i6uAcJJfxd2KvXNkBPtbB7iIE6k8ubUN Uw6TIdPOZZ10hWB44/CuE2Bc7nQ+cNOZAMgUOfOu6v1ocukWoB99+UnIA7BOnUvNOm5QScBu8NZ 3vHQhK+sNWtVKpxccDNduv/166qNLxx3/eSaLtYFNnWLSnJfFyYd5mhLmAmuQ4AoPQ8f9oQP4WI H86C1adzCCEY3G3bOz7cuR4wZCX9pSFWa1JBV7FhCdvMexlidMP/Lb3lzPNZokIuji4x8KZGUSD okP5qA+1bV4IyWzozSJhDTqw== X-Received: by 2002:a17:90a:d888:b0:354:c3a4:3a6 with SMTP id 98e67ed59e1d1-358aeab3addmr7740458a91.3.1771883862730; Mon, 23 Feb 2026 13:57:42 -0800 (PST) Received: from arch ([2409:40c2:5428:afe:6feb:bc4:5ef7:1700]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-358dc0092d1sm352772a91.5.2026.02.23.13.57.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Feb 2026 13:57:42 -0800 (PST) From: Bhargav Joshi To: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, rougueprince47@gmail.com Subject: [PATCH v4 3/3] iio: frequency: ad9523: fix checkpatch warnings for symbolic permissions Date: Tue, 24 Feb 2026 03:26:36 +0530 Message-ID: <20260223215636.18606-4-rougueprince47@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260223215636.18606-1-rougueprince47@gmail.com> References: <20260223215636.18606-1-rougueprince47@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The driver currently defines device attributes using symbolic permission flags (S_IRUGO and S_IWUSR). Update these to use octal permissions (0444 and 0200) to resolve checkpatch warnings. Signed-off-by: Bhargav Joshi --- drivers/iio/frequency/ad9523.c | 78 +++++++++++++--------------------- 1 file changed, 29 insertions(+), 49 deletions(-) diff --git a/drivers/iio/frequency/ad9523.c b/drivers/iio/frequency/ad9523.c index 6daa2ea354a8..ad32eb66edca 100644 --- a/drivers/iio/frequency/ad9523.c +++ b/drivers/iio/frequency/ad9523.c @@ -558,55 +558,35 @@ static ssize_t ad9523_show(struct device *dev, return ret; } -static IIO_DEVICE_ATTR(pll1_locked, S_IRUGO, - ad9523_show, - NULL, - AD9523_STAT_PLL1_LD); - -static IIO_DEVICE_ATTR(pll2_locked, S_IRUGO, - ad9523_show, - NULL, - AD9523_STAT_PLL2_LD); - -static IIO_DEVICE_ATTR(pll1_reference_clk_a_present, S_IRUGO, - ad9523_show, - NULL, - AD9523_STAT_REFA); - -static IIO_DEVICE_ATTR(pll1_reference_clk_b_present, S_IRUGO, - ad9523_show, - NULL, - AD9523_STAT_REFB); - -static IIO_DEVICE_ATTR(pll1_reference_clk_test_present, S_IRUGO, - ad9523_show, - NULL, - AD9523_STAT_REF_TEST); - -static IIO_DEVICE_ATTR(vcxo_clk_present, S_IRUGO, - ad9523_show, - NULL, - AD9523_STAT_VCXO); - -static IIO_DEVICE_ATTR(pll2_feedback_clk_present, S_IRUGO, - ad9523_show, - NULL, - AD9523_STAT_PLL2_FB_CLK); - -static IIO_DEVICE_ATTR(pll2_reference_clk_present, S_IRUGO, - ad9523_show, - NULL, - AD9523_STAT_PLL2_REF_CLK); - -static IIO_DEVICE_ATTR(sync_dividers, S_IWUSR, - NULL, - ad9523_store, - AD9523_SYNC); - -static IIO_DEVICE_ATTR(store_eeprom, S_IWUSR, - NULL, - ad9523_store, - AD9523_EEPROM); +static IIO_DEVICE_ATTR(pll1_locked, 0444, ad9523_show, NULL, + AD9523_STAT_PLL1_LD); + +static IIO_DEVICE_ATTR(pll2_locked, 0444, ad9523_show, NULL, + AD9523_STAT_PLL2_LD); + +static IIO_DEVICE_ATTR(pll1_reference_clk_a_present, 0444, ad9523_show, NULL, + AD9523_STAT_REFA); + +static IIO_DEVICE_ATTR(pll1_reference_clk_b_present, 0444, ad9523_show, NULL, + AD9523_STAT_REFB); + +static IIO_DEVICE_ATTR(pll1_reference_clk_test_present, 0444, ad9523_show, NULL, + AD9523_STAT_REF_TEST); + +static IIO_DEVICE_ATTR(vcxo_clk_present, 0444, ad9523_show, NULL, + AD9523_STAT_VCXO); + +static IIO_DEVICE_ATTR(pll2_feedback_clk_present, 0444, ad9523_show, NULL, + AD9523_STAT_PLL2_FB_CLK); + +static IIO_DEVICE_ATTR(pll2_reference_clk_present, 0444, ad9523_show, NULL, + AD9523_STAT_PLL2_REF_CLK); + +static IIO_DEVICE_ATTR(sync_dividers, 0200, NULL, ad9523_store, + AD9523_SYNC); + +static IIO_DEVICE_ATTR(store_eeprom, 0200, NULL, ad9523_store, + AD9523_EEPROM); static struct attribute *ad9523_attributes[] = { &iio_dev_attr_sync_dividers.dev_attr.attr, -- 2.53.0