From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: luka.gejak@linux.dev
Cc: Dan Carpenter <dan.carpenter@linaro.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH v3 01/22] staging: rtl8723bs: fix potential out-of-bounds read in rtw_restruct_wmm_ie
Date: Mon, 23 Feb 2026 15:18:27 +0100 [thread overview]
Message-ID: <2026022332-reemerge-gestate-5760@gregkh> (raw)
In-Reply-To: <20260208110111.46642-2-luka.gejak@linux.dev>
On Sun, Feb 08, 2026 at 12:00:50PM +0100, luka.gejak@linux.dev wrote:
> From: Luka Gejak <luka.gejak@linux.dev>
>
> The current code checks 'i + 5 < in_len' at the end of the if statement.
> However, it accesses 'in_ie[i + 5]' before that check, which can lead
> to an out-of-bounds read. Move the length check to the beginning of the
> conditional to ensure the index is within bounds before accessing the
> array.
>
> Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver")
> Cc: stable@vger.kernel.org
> Signed-off-by: Luka Gejak <luka.gejak@linux.dev>
> ---
> drivers/staging/rtl8723bs/core/rtw_mlme.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
You have mixed bugfixes that should go into 7.0-final with cleanups in
the same series, makeing it a mess for me to try to apply this. Can you
resend this as two different series, one with just bugfixes for
7.0-final and the rest being the normal coding style cleanups? That way
I can apply them properly.
thanks,
greg k-h
next prev parent reply other threads:[~2026-02-23 14:19 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-08 11:00 [PATCH v3 00/22] staging: rtl8723bs: fix out-of-bounds and various cleanups luka.gejak
2026-02-08 11:00 ` [PATCH v3 01/22] staging: rtl8723bs: fix potential out-of-bounds read in rtw_restruct_wmm_ie luka.gejak
2026-02-23 14:18 ` Greg Kroah-Hartman [this message]
2026-02-08 11:00 ` [PATCH v3 02/22] staging: rtl8723bs: remove unused rtl8192c function declarations luka.gejak
2026-02-08 11:00 ` [PATCH v3 03/22] staging: rtl8723bs: remove unused RECV_BLK defines luka.gejak
2026-02-08 11:00 ` [PATCH v3 04/22] staging: rtl8723bs: remove unused MAX_PATH_NUM defines luka.gejak
2026-02-08 11:00 ` [PATCH v3 05/22] staging: rtl8723bs: convert PSTA_INFO_T to struct sta_info * luka.gejak
2026-02-08 11:00 ` [PATCH v3 06/22] staging: rtl8723bs: remove NDIS type aliases luka.gejak
2026-02-08 11:00 ` [PATCH v3 07/22] staging: rtl8723bs: remove redundant MAC_ARG macro luka.gejak
2026-02-08 11:00 ` [PATCH v3 08/22] staging: rtl8723bs: core: fix line lengths in rtw_wlan_util.c luka.gejak
2026-02-08 11:00 ` [PATCH v3 09/22] staging: rtl8723bs: core: fix line lengths in rtw_recv.c luka.gejak
2026-02-08 11:00 ` [PATCH v3 10/22] staging: rtl8723bs: hal: fix line lengths in HalPhyRf_8723B.c luka.gejak
2026-02-08 11:01 ` [PATCH v3 11/22] staging: rtl8723bs: os_dep: fix line lengths in ioctl_cfg80211.c luka.gejak
2026-02-08 11:01 ` [PATCH v3 12/22] staging: rtl8723bs: hal: fix line lengths in rtl8723b_cmd.c luka.gejak
2026-02-08 11:01 ` [PATCH v3 13/22] staging: rtl8723bs: hal: fix line lengths in rtl8723b_hal_init.c luka.gejak
2026-02-08 11:01 ` [PATCH v3 14/22] staging: rtl8723bs: hal: fix line lengths in rtl8723b_phycfg.c luka.gejak
2026-02-08 11:01 ` [PATCH v3 15/22] staging: rtl8723bs: core: fix various line length overflows luka.gejak
2026-02-08 11:01 ` [PATCH v3 16/22] staging: rtl8723bs: hal: " luka.gejak
2026-02-08 11:01 ` [PATCH v3 17/22] staging: rtl8723bs: os_dep: " luka.gejak
2026-02-08 11:01 ` [PATCH v3 18/22] staging: rtl8723bs: core: fix line lengths in rtw_cmd.c luka.gejak
2026-02-08 11:01 ` [PATCH v3 19/22] staging: rtl8723bs: core: fix line lengths in rtw_mlme_ext.c luka.gejak
2026-02-08 11:01 ` [PATCH v3 20/22] staging: rtl8723bs: core: fix line lengths in rtw_mlme.c luka.gejak
2026-02-08 11:01 ` [PATCH v3 21/22] staging: rtl8723bs: core: fix line lengths in rtw_xmit.c luka.gejak
2026-02-08 11:01 ` [PATCH v3 22/22] staging: rtl8723bs: core: fix various line length overflows luka.gejak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026022332-reemerge-gestate-5760@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=dan.carpenter@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=luka.gejak@linux.dev \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®