From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 75E4E36CDED for ; Mon, 23 Feb 2026 19:10:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771873854; cv=none; b=qg/Xya3uCwRdI7Eznwm0RefSgtwa1YQ6QW3v/nZBccYzmwk4cXrffkML22QdykuEFwYzLmHtuUSvvJ5gf7OZHW6la6nv1LiZeFSe2bWOhAiShyR+s7Jyg7sHXqqzU/aXsyBfemB5zx5AO3b0zfk7O1a1WUt+J6f90BFQwHiqeec= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771873854; c=relaxed/simple; bh=2RxOxXc9zqZvtJxNIuKIxSb9BnPuUuUrWmkgeMbTfW8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Zkfx4K7fcbkWC2LFzxKabWtlIfqf8ZViOCWGwXcSuLJ+3uBzKkB1wjo0BQBKJY0EtPgrn2Pvm4AMpcrgxwdqXNg9HMekmmDQuKpvUGO2DNy1Tp9L1NI1yv5lJDDVrvmOsVkDDCHezOZR+dzkl1dRiawpzKkdn5vAbKru114DI80= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=OqkqPx5D; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=EuXsJpaS; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="OqkqPx5D"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="EuXsJpaS" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61NIoCY83409247 for ; Mon, 23 Feb 2026 19:10:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 3cEndrH++ZoozGxCle7RcLV8UVr6wjbisoptDK/+Xp8=; b=OqkqPx5DajaGaPNQ 9oi4JyZMGMa3uC/V148Ftz8x1qGnU5jAn3Hp0OyelszklsQjRnTYsvyORjcrM5J9 kM2n5nqoKGR3lemZUd6RdrKRRqFvGW+Q1Ht3tEGVxFO/2U6dEhXf8cn5HZ2X3kXl Kkizh3UFar+DJHRqvmO0AMqAGaxwp0V1dX2VUyrwQCIw/4H0tBsl02lEtqFDdgtC VthsA6QRlGvoQIhZwQfqW6jdByd9tRb8EMbf3I8v1Q5yINNnEVDs5ZwLyY9LMi9G O4Oz+2umASGPUZxESnS87u4K/HjCdhLsQ3y9P+KMc0qpOIZj+mZGE2SJvRACwM8/ zPRv3g== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cgn8tsk71-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 23 Feb 2026 19:10:52 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2a7a98ba326so70506155ad.1 for ; Mon, 23 Feb 2026 11:10:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771873852; x=1772478652; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=3cEndrH++ZoozGxCle7RcLV8UVr6wjbisoptDK/+Xp8=; b=EuXsJpaSuyQ5hgcpecnCFKA0JdvZk8ISaj+JVDBul6G0xsg47ap3H/Ipsn2BjWMBpx iOX0la6mVJl1Rq58SFDg6Pwh5mCQ3D8jHTjrRCiaK2Vu3oL9EBXXBoLZMdQGptCfpUJy UsPDXWeQ3cgCzsUvobOyyhZTi5MXQIIdVi5b0s0YsjFhadpY3QCN8LZPBkFH/pOfUnTA DmzDWhRkmLOo2EXXs73Spx8crKPmRWrB+sHtpZhntpL5Mu/Vhyx4KzYjG73Uhjib8Z69 YMEOrbtXdv7SLpQQa4cHddiOWf+0Rs+1QDSOoHOeBJWXxnkR867abOJ23k45T+2odIvA 2U8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771873852; x=1772478652; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=3cEndrH++ZoozGxCle7RcLV8UVr6wjbisoptDK/+Xp8=; b=c5qn4uFn0zVOezL0raEdTD+8rD8ooiVVIqbflvhSInaIhORX5000Up1eWOmFjFPzfP pXxcApvOX3rNvisGjPv3Kr3eH4OyvP0rOPX2egOD2u4406RAqscskmQ3TH3MOmm4lNgk CrY6tkeyFb+LXcaLVCQpPccwrgWJl1KppENezxvMiF7mJrFdv40rM2IkO6xRZxmVzh8E XSUcFo8j/PUldyDIMS/CNeNhX4fnGB3221CQL6sgxS4vZBGrhap1MfVMZ39UEo6j5s4D uNujEmXREMWBwFZuWOv4yDrpLj+RF/wExD4Nh3RpuDpp/zOK6PqxnwO7j6uk1O67OpUH MrGw== X-Forwarded-Encrypted: i=1; AJvYcCVNwMiKVfegmFT/Ick7aXE6lbfNk47X6lQvaeyzJ97lUm8ISMRvdrv7NwsyQFUUyV8xkv1TB77FOPYgi38=@vger.kernel.org X-Gm-Message-State: AOJu0YwQRbLuCJ1r+yAQ75Hr7qV7aV4DY18YRIqWwojTHQSgTk9SA1ia q1GQShWHc+qnG/eM4ccLT+tXKt8xJJZUNgjZ9nz6IhVRu2Vj3Or+O/1su9jiQj+QOnSVjUztruJ MqXuSr0Ck8/2oAmtItbkebC9zHOBjLsJ6R9d8r+CKKjVw4VRqTyLUiWUpDnNgePEQ8p4= X-Gm-Gg: ATEYQzx1XUPfl40LwoBlV3iEJY7xUKgdqT+jxbJXkFWNcgytVTVcNoacIN66yVQ1SPF WQGdC5+Tzbge3O1YKm744EZqePnf5jp+gKD9my+Ba3bGfoYqJHZ1nFNC6SsgbqFo5Vi56X1ulwS fQXWGNygmkfw9T7IG1/jNLvoGnVaLVlsqfeBXOwme77zixhjAYBPPe1DSpLYPOS6haqHxvxmUE8 CX7ct8YqsLMNPHuTm/rtnh+GufJxeT6G88lPTqdhvVn0qgx6felK3BLYpW0STLVNIA/NAYLQpy/ OTqWKhOB8yaHRw/UIm685ZVempctAmJyjVPiMyYQxb8JFBihEeToOqVNBuJOzk1Yc26Djpk47D7 gvs4p5FbxIIKPrYwS08PpywCwbhZVum2gzj/ygqiKtK5Dto2pUipcPg== X-Received: by 2002:a17:903:1107:b0:2a9:320d:285e with SMTP id d9443c01a7336-2ad5f7b8baamr123910585ad.27.1771873844289; Mon, 23 Feb 2026 11:10:44 -0800 (PST) X-Received: by 2002:a17:903:1107:b0:2a9:320d:285e with SMTP id d9443c01a7336-2ad5f7b8baamr123910275ad.27.1771873843731; Mon, 23 Feb 2026 11:10:43 -0800 (PST) Received: from hu-ekangupt-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ad74e34e18sm83501505ad.10.2026.02.23.11.10.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Feb 2026 11:10:43 -0800 (PST) From: Ekansh Gupta Date: Tue, 24 Feb 2026 00:39:05 +0530 Subject: [PATCH RFC 11/18] accel/qda: Add GEM_CREATE and GEM_MMAP_OFFSET IOCTLs Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260224-qda-firstpost-v1-11-fe46a9c1a046@oss.qualcomm.com> References: <20260224-qda-firstpost-v1-0-fe46a9c1a046@oss.qualcomm.com> In-Reply-To: <20260224-qda-firstpost-v1-0-fe46a9c1a046@oss.qualcomm.com> To: Oded Gabbay , Jonathan Corbet , Shuah Khan , Joerg Roedel , Will Deacon , Robin Murphy , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Sumit Semwal , =?utf-8?q?Christian_K=C3=B6nig?= Cc: dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, iommu@lists.linux.dev, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org, Srinivas Kandagatla , Dmitry Baryshkov , Bharath Kumar , Chenna Kesava Raju , Ekansh Gupta X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1771873753; l=6899; i=ekansh.gupta@oss.qualcomm.com; s=20260223; h=from:subject:message-id; bh=2RxOxXc9zqZvtJxNIuKIxSb9BnPuUuUrWmkgeMbTfW8=; b=OdNLCIrevKeJOr4Sn7iJQ7EA64taPtlHsqOdk0FAznWQBx7+UrSyEBkaxLabf/n4ZADVR797g gmHDCtzQkxDCDFwH4r3tYY2PYPpjtmNKwQNMzhCaFXo/sq/VV+FDLok X-Developer-Key: i=ekansh.gupta@oss.qualcomm.com; a=ed25519; pk=n0SepARizye+pYjhjg1RA5J+Nq4+IJbyRcBybU+/ERQ= X-Authority-Analysis: v=2.4 cv=X7Jf6WTe c=1 sm=1 tr=0 ts=699ca63c cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=mxALtX23GHkpHf8IwecA:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-ORIG-GUID: r7u9tjHDbDylOnxEa0fsQtyVguno2Wx8 X-Proofpoint-GUID: r7u9tjHDbDylOnxEa0fsQtyVguno2Wx8 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjIzMDE2NiBTYWx0ZWRfX/8/j0LDhObEw 2JfFfh9NlXtj4gOBI9PUKVvLuHfsyG9iw6WpQKeUdssruZ5dLlGzPaSslLnHXdKom9LtsqqYj2+ Le0EKe+HAphMVDbLgtakfhv5RXDdNyAfYiTEetI0n0isKMHsIHKwO4ixrTtrP8QUIJi3Wcbg5hU EkpraEfDJOs5bMy4E6Bfn8Dk+BBxWmZ3j/s5zkktOEoPkoayg4TV50Pcy6Qvxwj/dN+fGuVyLrz /fQl/f0vibKDelFWW1SzKBi7TbK7ZGTJJoEZF1p9TRClFs5tSa9tUrikc5LPOe7+fClt4apREY1 sTYpK7P5AXxpxEx9ToFYUWsybzv7+kfoNESqN+MoJhGqVDXWOtFGTI6e8sfFlYfnznF+5E3VGf3 f4miXaE+4/xUd7vcgMDSGaAvuzOEhHfX5lHJNsnwHpCxPShCuknGPze+c8NIjGXSVh3k/AAf/9X i7tGjqZLznYQf4XG1FA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-23_04,2026-02-23_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 priorityscore=1501 clxscore=1015 bulkscore=0 adultscore=0 spamscore=0 impostorscore=0 lowpriorityscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602230166 Add two GEM-related IOCTLs for the QDA accelerator driver and hook them into the DRM accel driver. DRM_IOCTL_QDA_GEM_CREATE allocates a DMA-backed GEM buffer object via qda_gem_create_object() and returns a GEM handle to userspace, while DRM_IOCTL_QDA_GEM_MMAP_OFFSET returns a valid mmap offset for a given GEM handle using drm_gem_create_mmap_offset() and the vma_node in the GEM object. The QDA driver is updated to advertise DRIVER_GEM in its driver_features, and the new IOCTLs are wired through the QDA GEM and memory-manager backend. These IOCTLs allow userspace to allocate buffers and map them into its address space as a first step toward full compute buffer management and integration with DSP workloads. Signed-off-by: Ekansh Gupta --- drivers/accel/qda/qda_drv.c | 5 ++++- drivers/accel/qda/qda_gem.h | 30 ++++++++++++++++++++++++++++++ drivers/accel/qda/qda_ioctl.c | 35 +++++++++++++++++++++++++++++++++++ include/uapi/drm/qda_accel.h | 36 ++++++++++++++++++++++++++++++++++++ 4 files changed, 105 insertions(+), 1 deletion(-) diff --git a/drivers/accel/qda/qda_drv.c b/drivers/accel/qda/qda_drv.c index 19798359b14e..0dd0e2bb2c0f 100644 --- a/drivers/accel/qda/qda_drv.c +++ b/drivers/accel/qda/qda_drv.c @@ -12,6 +12,7 @@ #include #include "qda_drv.h" +#include "qda_gem.h" #include "qda_ioctl.h" #include "qda_rpmsg.h" @@ -154,10 +155,12 @@ DEFINE_DRM_ACCEL_FOPS(qda_accel_fops); static const struct drm_ioctl_desc qda_ioctls[] = { DRM_IOCTL_DEF_DRV(QDA_QUERY, qda_ioctl_query, 0), + DRM_IOCTL_DEF_DRV(QDA_GEM_CREATE, qda_ioctl_gem_create, 0), + DRM_IOCTL_DEF_DRV(QDA_GEM_MMAP_OFFSET, qda_ioctl_gem_mmap_offset, 0), }; static struct drm_driver qda_drm_driver = { - .driver_features = DRIVER_COMPUTE_ACCEL, + .driver_features = DRIVER_GEM | DRIVER_COMPUTE_ACCEL, .fops = &qda_accel_fops, .open = qda_open, .postclose = qda_postclose, diff --git a/drivers/accel/qda/qda_gem.h b/drivers/accel/qda/qda_gem.h index caae9cda5363..cbd5d0a58fa4 100644 --- a/drivers/accel/qda/qda_gem.h +++ b/drivers/accel/qda/qda_gem.h @@ -47,6 +47,36 @@ struct drm_gem_object *qda_gem_create_object(struct drm_device *drm_dev, void qda_gem_free_object(struct drm_gem_object *gem_obj); int qda_gem_mmap_obj(struct drm_gem_object *gem_obj, struct vm_area_struct *vma); +/* + * GEM IOCTL handlers + */ + +/** + * qda_ioctl_gem_create - Create a GEM buffer object + * @dev: DRM device structure + * @data: User-space data containing buffer creation parameters + * @file_priv: DRM file private data + * + * This IOCTL handler creates a new GEM buffer object with the specified + * size and returns a handle to the created buffer. + * + * Return: 0 on success, negative error code on failure + */ +int qda_ioctl_gem_create(struct drm_device *dev, void *data, struct drm_file *file_priv); + +/** + * qda_ioctl_gem_mmap_offset - Get mmap offset for a GEM buffer object + * @dev: DRM device structure + * @data: User-space data containing buffer handle and offset result + * @file_priv: DRM file private data + * + * This IOCTL handler retrieves the mmap offset for a GEM buffer object, + * which can be used to map the buffer into user-space memory. + * + * Return: 0 on success, negative error code on failure + */ +int qda_ioctl_gem_mmap_offset(struct drm_device *dev, void *data, struct drm_file *file_priv); + /* * Helper functions for GEM object allocation and cleanup * These are used internally and by the PRIME import code diff --git a/drivers/accel/qda/qda_ioctl.c b/drivers/accel/qda/qda_ioctl.c index 9fa73ec2dfce..ef3c9c691cb7 100644 --- a/drivers/accel/qda/qda_ioctl.c +++ b/drivers/accel/qda/qda_ioctl.c @@ -43,3 +43,38 @@ int qda_ioctl_query(struct drm_device *dev, void *data, struct drm_file *file_pr return 0; } + +int qda_ioctl_gem_create(struct drm_device *dev, void *data, struct drm_file *file_priv) +{ + struct drm_qda_gem_create *args = data; + struct drm_gem_object *gem_obj; + struct qda_drm_priv *drm_priv; + + drm_priv = get_drm_priv_from_device(dev); + if (!drm_priv || !drm_priv->iommu_mgr) + return -EINVAL; + + gem_obj = qda_gem_create_object(dev, drm_priv->iommu_mgr, args->size, file_priv); + if (IS_ERR(gem_obj)) + return PTR_ERR(gem_obj); + + return qda_gem_create_handle(file_priv, gem_obj, &args->handle); +} + +int qda_ioctl_gem_mmap_offset(struct drm_device *dev, void *data, struct drm_file *file_priv) +{ + struct drm_qda_gem_mmap_offset *args = data; + struct drm_gem_object *gem_obj; + int ret; + + gem_obj = qda_gem_lookup_object(file_priv, args->handle); + if (IS_ERR(gem_obj)) + return PTR_ERR(gem_obj); + + ret = drm_gem_create_mmap_offset(gem_obj); + if (ret == 0) + args->offset = drm_vma_node_offset_addr(&gem_obj->vma_node); + + drm_gem_object_put(gem_obj); + return ret; +} diff --git a/include/uapi/drm/qda_accel.h b/include/uapi/drm/qda_accel.h index 0aad791c4832..ed24a7f5637e 100644 --- a/include/uapi/drm/qda_accel.h +++ b/include/uapi/drm/qda_accel.h @@ -19,6 +19,8 @@ extern "C" { * They are used with DRM_COMMAND_BASE to create the full IOCTL numbers. */ #define DRM_QDA_QUERY 0x00 +#define DRM_QDA_GEM_CREATE 0x01 +#define DRM_QDA_GEM_MMAP_OFFSET 0x02 /* * QDA IOCTL definitions * @@ -27,6 +29,10 @@ extern "C" { * data structure and direction (read/write) for each IOCTL. */ #define DRM_IOCTL_QDA_QUERY DRM_IOR(DRM_COMMAND_BASE + DRM_QDA_QUERY, struct drm_qda_query) +#define DRM_IOCTL_QDA_GEM_CREATE DRM_IOWR(DRM_COMMAND_BASE + DRM_QDA_GEM_CREATE, \ + struct drm_qda_gem_create) +#define DRM_IOCTL_QDA_GEM_MMAP_OFFSET DRM_IOWR(DRM_COMMAND_BASE + DRM_QDA_GEM_MMAP_OFFSET, \ + struct drm_qda_gem_mmap_offset) /** * struct drm_qda_query - Device information query structure @@ -40,6 +46,36 @@ struct drm_qda_query { __u8 dsp_name[16]; }; +/** + * struct drm_qda_gem_create - GEM buffer object creation parameters + * @size: Size of the GEM object to create in bytes (input) + * @handle: Allocated GEM handle (output) + * + * This structure is used with DRM_IOCTL_QDA_GEM_CREATE to allocate + * a new GEM buffer object. + */ +struct drm_qda_gem_create { + __u32 handle; + __u32 pad; + __u64 size; +}; + +/** + * struct drm_qda_gem_mmap_offset - GEM object mmap offset query + * @handle: GEM handle (input) + * @pad: Padding for 64-bit alignment + * @offset: mmap offset for the GEM object (output) + * + * This structure is used with DRM_IOCTL_QDA_GEM_MMAP_OFFSET to retrieve + * the mmap offset that can be used with mmap() to map the GEM object into + * user space. + */ +struct drm_qda_gem_mmap_offset { + __u32 handle; + __u32 pad; + __u64 offset; +}; + #if defined(__cplusplus) } #endif -- 2.34.1