From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 048F736AB7D for ; Mon, 23 Feb 2026 19:10:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771873836; cv=none; b=iibxY6H7+v9NwIJJ5n8NLmTS2Fc1WP/ZZDCATb/R+3vE2L8Y43xLMt+Y1esW6cxpl9Zp+qXixQMxoknYofAf8/jBalZG5ddxM0zlBkoR4peWVb0dftJjEbwTqVwykzuY8d0RKVlW+0C3OO3p+Yg8YA+r1yEw5WfEudrapSX0SUQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771873836; c=relaxed/simple; bh=cPe6XiIaqlleCllXAqlYjNWCbV9gcpzWtKPjZ8WPpf8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=OhBH0DgojMklubSaMio6oyr5Q57oNIMyijnjrqbhnH/WIBAtVw/g96nhUjcR5rpBeGFYRTmxwLkdZrOavdStLXE6Nbjw7IK9VYzV5I4DHDh911eO1cGznbncjVLJdaPyn3Y+Ol6No9/EurVSX0k4FhncGpqwARKf3iBUrIkHbi4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=mr0aOAlt; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=A+KblW2U; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="mr0aOAlt"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="A+KblW2U" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61NH4ORx910232 for ; Mon, 23 Feb 2026 19:10:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 4cWM5gPirp6izkRy//rcobyzuJsSsXAsmgnCXnHF9B0=; b=mr0aOAltrI4uJ7Y/ eX9yHYbh93qOBnF0O2Jqi5e+eWUymu4EHSr+IRSR6gTZxrvMqgHZ6o1FClrysAH3 pMZrf70/KSN/FcBb2TvAafzdorTIV4pVb4LiUtBBsF0Km8bD0I4tL6M7YTD+PGca 4CNb3QtHn2c06AyXuTJyxX4vRMNwVn7Hxqo3Hio+v8Wbu7rCaEj44wddHPe6RanH GrilYYSFJwxyqM62A14LM/3SDVGNbRisSdICQwZWw3r+AMJwc8gQQsG3/33xl13e HPu3/IMadAw3RB4Z9G9QTr+krQ0RRdQjJBoCxtyld2upIJwRwgKRcmHlx4IB8xP8 jzK1Qg== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cgtyj8d63-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 23 Feb 2026 19:10:30 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2a946c0e441so42561295ad.1 for ; Mon, 23 Feb 2026 11:10:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771873829; x=1772478629; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=4cWM5gPirp6izkRy//rcobyzuJsSsXAsmgnCXnHF9B0=; b=A+KblW2U0GhVc3IE3cPCz8b2KMcevi1GgyYJ1fqciqYsd7h72jTlcMwxjYvzMGU0uY ZHyZrCoPTVRk6EKzM6JTt+u5ji9EcHNrkbSavgfPLs6qigGxOnn7z7F509fDtZV+e+Ew hyu0Df6kCSj7iX1wq2oaXT/i+7HWcqx2xTuafbDHPOr0vWMuD7iO+7UNJFP4t/GEm+xN FajN9zVVKx7vCSyIQeZzt5TYwqmcPpfy3crlk+Hx2FsaeJ7Qnuh8GUSZD3iRn9G04RX0 bw7Wm6Oqm2jUoN+QZWWaKgMVh9mEcH7Wtv1yBSHjEpDFfVJoU/PKNKYzzs3XXUFdd8C9 uiYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771873829; x=1772478629; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=4cWM5gPirp6izkRy//rcobyzuJsSsXAsmgnCXnHF9B0=; b=FTt4ICgNETFWPT9N46ArKTtKgP8MaVlUYWyqsVXwVqOlejwD4wAefqshh/tcOvRfX/ UjPD8y5DMSmq+3hmnwvr+Lyycvsdgh9lAKt+Resce8lEWz91kJ2F3YWYPPB8Szgy1J3E eEegN2inXx1m4/X15YYwkeAOxFnob8i4YOH4pF+SJIK7VJ7SAEq3leIE0g7kZOSZqyz3 2s2LttDr0pR+jfJL/mWZQP2aQ8pwDphN54DEx+Vha+kPaOteRNKnvtwF/hF5K/k2HDM6 WImaqMNQRFyXJ9Ib4c586SPok7LzuSVQfG9Z/qGWRK4fTfYCY/tARltBoT12819dTtnH ahgA== X-Forwarded-Encrypted: i=1; AJvYcCUysy6wxZ7yDaTdvKs4xVlvGCFKXUbR1THsCv+sxCAg7dOsrpIGRUmnBIyImGmi0LYdpg9XqAUmOpjTfsg=@vger.kernel.org X-Gm-Message-State: AOJu0YwGrpEBTZ5DMfmMpitAcrCQAdmLznvkJr3WQboQxqVfacp9mzL0 woHUiQxquyt5r3zm8vTNZc4f6Atd5GaL0N2VUVLw9fpjZp5z+T2Xf5PN4b/sIxzevqPW5FbX/Iu yK4KOwTocblNPAhsfg1pkXghugGiLcA1gM/D65/U/AqV1Il30M5wEq4Zc2zb4c70Epxo= X-Gm-Gg: ATEYQzz+6bZOsU/pljivl7IzkaOH6aNzAi95qLVftCc8R5tF8vK9gx185jlLuNgwiWM qgFjWF3v5MZX1SpoP+3YUqITiDCoX8R+X7MP4wiZVmZJ8tZKpSo0c0sf0pc/msGEMnm2HlVpYmL H2l00H2eiX/fjGcDAPKtLNCg98bMXZdoZ/DMxFnaL+tCJiVzlMZ3tU2BOXe26BSFtbLthqnibJ5 WQgUJVj5msSbtYeKUiKPU1dKjxuFMMFqve+tM1P6dh3qG+aF7lkqzhvAB3+kfViuYqBOdvanBQT L5XSnfSKnC9v8lF0SBJvIhjNVjzmSkcJuqZBMRakbbamt/aVcB8nook6X7EPYNlGnv8R6fpP1XD cLXT1R7D8XqI+RQQD93ctN8a1XPtxGloUbpQflX+XNjRG7cV6cInx0A== X-Received: by 2002:a17:903:2f8c:b0:2a9:451b:422 with SMTP id d9443c01a7336-2ad74439669mr84594685ad.14.1771873829353; Mon, 23 Feb 2026 11:10:29 -0800 (PST) X-Received: by 2002:a17:903:2f8c:b0:2a9:451b:422 with SMTP id d9443c01a7336-2ad74439669mr84594305ad.14.1771873828808; Mon, 23 Feb 2026 11:10:28 -0800 (PST) Received: from hu-ekangupt-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ad74e34e18sm83501505ad.10.2026.02.23.11.10.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Feb 2026 11:10:28 -0800 (PST) From: Ekansh Gupta Date: Tue, 24 Feb 2026 00:39:03 +0530 Subject: [PATCH RFC 09/18] accel/qda: Add QUERY IOCTL and basic QDA UAPI header Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260224-qda-firstpost-v1-9-fe46a9c1a046@oss.qualcomm.com> References: <20260224-qda-firstpost-v1-0-fe46a9c1a046@oss.qualcomm.com> In-Reply-To: <20260224-qda-firstpost-v1-0-fe46a9c1a046@oss.qualcomm.com> To: Oded Gabbay , Jonathan Corbet , Shuah Khan , Joerg Roedel , Will Deacon , Robin Murphy , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Sumit Semwal , =?utf-8?q?Christian_K=C3=B6nig?= Cc: dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, iommu@lists.linux.dev, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org, Srinivas Kandagatla , Dmitry Baryshkov , Bharath Kumar , Chenna Kesava Raju , Ekansh Gupta X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1771873753; l=6604; i=ekansh.gupta@oss.qualcomm.com; s=20260223; h=from:subject:message-id; bh=cPe6XiIaqlleCllXAqlYjNWCbV9gcpzWtKPjZ8WPpf8=; b=ZymVL6dioZif6Wgr4wJm47EDwZKmJDJvKkln1f30mqSxFcv/WXANZRzJ6HZOt0B38TaPvWsjI 2zkyvEL7H+3AOLdSQuIn9G6ImRaRh4RXlXJ9NOWvLTJOVVCdBtH+0mj X-Developer-Key: i=ekansh.gupta@oss.qualcomm.com; a=ed25519; pk=n0SepARizye+pYjhjg1RA5J+Nq4+IJbyRcBybU+/ERQ= X-Authority-Analysis: v=2.4 cv=Jq/8bc4C c=1 sm=1 tr=0 ts=699ca626 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=xFwpPJ--XgJ2TdNcX9IA:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-ORIG-GUID: Of8iE3jX2fQEvLxXIgp4cu68i7nu-7pX X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjIzMDE2NiBTYWx0ZWRfXwdBkVlpBJJAK poYqjsqWRPPl68TgOWtd9WahPWumDlkdiXhrzD8L0sFWsW4YP96dsGpWRubY7tZqGjw56wfQV7H ewurvlxQfwd2qeVPEVHV2zSJvFOqhYm/tyVCW7SUHIekLEsNjxbGu6MuhADNFZ4pWHHjuzBSTE1 1ofR894qyZPVxqqpq9aUDrne1UwjZEtVnz+ypZnybVip4wn+UMgZtjispoptV0OSM+FEbMG+Caj skq8Exzb+AralaxqwIBDrsH1h8u/RTNXY1r9b+Gc9r2YXV0JgYPvvnghO6KOVILqk9f+mwCAMKC 2jS2M5TS8iN0maOk8z4t3yW70ruDesacMPncrlflA+BPr6n7KUQYNJQ+gtSlh7dan6oPrR2R6+N 5VVf7CgRNHHMogEIkKNa3Nb2Lq5AebfTB4ogUrXiNcozxXdOo22ze7WxWxaT4f2AhARfXzJ18TW rzQQwg3dyiehehfWMwQ== X-Proofpoint-GUID: Of8iE3jX2fQEvLxXIgp4cu68i7nu-7pX X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-23_04,2026-02-23_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 lowpriorityscore=0 malwarescore=0 priorityscore=1501 spamscore=0 adultscore=0 phishscore=0 suspectscore=0 impostorscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602230166 Introduce a basic UAPI for the QDA accelerator driver along with a DRM IOCTL handler to query DSP device identity. A new UAPI header include/uapi/drm/qda_accel.h defines DRM_QDA_QUERY, the corresponding DRM_IOCTL_QDA_QUERY command, and struct drm_qda_query, which contains a DSP name string. On the kernel side, qda_ioctl_query() validates the per-file context, resolves the qda_dev instance from dev->dev_private, and copies the DSP name from qdev->dsp_name into the query structure. The new qda_ioctls[] table wires this IOCTL into the QDA DRM driver so userspace can call it through the standard DRM command interface. This IOCTL provides a simple and stable way for userspace to discover which DSP a given QDA device node represents and serves as the first building block for a richer QDA UAPI in subsequent patches. Signed-off-by: Ekansh Gupta --- drivers/accel/qda/Makefile | 1 + drivers/accel/qda/qda_drv.c | 9 +++++++++ drivers/accel/qda/qda_ioctl.c | 45 +++++++++++++++++++++++++++++++++++++++++ drivers/accel/qda/qda_ioctl.h | 26 ++++++++++++++++++++++++ include/uapi/drm/qda_accel.h | 47 +++++++++++++++++++++++++++++++++++++++++++ 5 files changed, 128 insertions(+) diff --git a/drivers/accel/qda/Makefile b/drivers/accel/qda/Makefile index 7e96ddc40a24..f547398e1a72 100644 --- a/drivers/accel/qda/Makefile +++ b/drivers/accel/qda/Makefile @@ -10,5 +10,6 @@ qda-y := \ qda_rpmsg.o \ qda_cb.o \ qda_memory_manager.o \ + qda_ioctl.o \ obj-$(CONFIG_DRM_ACCEL_QDA_COMPUTE_BUS) += qda_compute_bus.o diff --git a/drivers/accel/qda/qda_drv.c b/drivers/accel/qda/qda_drv.c index bf95fc782cf8..86758a9cd982 100644 --- a/drivers/accel/qda/qda_drv.c +++ b/drivers/accel/qda/qda_drv.c @@ -9,7 +9,10 @@ #include #include #include +#include + #include "qda_drv.h" +#include "qda_ioctl.h" #include "qda_rpmsg.h" static struct qda_drm_priv *get_drm_priv_from_device(struct drm_device *dev) @@ -128,11 +131,17 @@ static void qda_postclose(struct drm_device *dev, struct drm_file *file) DEFINE_DRM_ACCEL_FOPS(qda_accel_fops); +static const struct drm_ioctl_desc qda_ioctls[] = { + DRM_IOCTL_DEF_DRV(QDA_QUERY, qda_ioctl_query, 0), +}; + static struct drm_driver qda_drm_driver = { .driver_features = DRIVER_COMPUTE_ACCEL, .fops = &qda_accel_fops, .open = qda_open, .postclose = qda_postclose, + .ioctls = qda_ioctls, + .num_ioctls = ARRAY_SIZE(qda_ioctls), .name = DRIVER_NAME, .desc = "Qualcomm DSP Accelerator Driver", }; diff --git a/drivers/accel/qda/qda_ioctl.c b/drivers/accel/qda/qda_ioctl.c new file mode 100644 index 000000000000..9fa73ec2dfce --- /dev/null +++ b/drivers/accel/qda/qda_ioctl.c @@ -0,0 +1,45 @@ +// SPDX-License-Identifier: GPL-2.0-only +// Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. +#include +#include +#include +#include "qda_drv.h" +#include "qda_ioctl.h" + +static int qda_validate_and_get_context(struct drm_device *dev, struct drm_file *file_priv, + struct qda_dev **qdev, struct qda_user **qda_user) +{ + struct qda_drm_priv *drm_priv = dev->dev_private; + struct qda_file_priv *qda_file_priv; + + if (!drm_priv) + return -EINVAL; + + *qdev = drm_priv->qdev; + if (!*qdev) + return -EINVAL; + + qda_file_priv = (struct qda_file_priv *)file_priv->driver_priv; + if (!qda_file_priv || !qda_file_priv->qda_user) + return -EINVAL; + + *qda_user = qda_file_priv->qda_user; + + return 0; +} + +int qda_ioctl_query(struct drm_device *dev, void *data, struct drm_file *file_priv) +{ + struct qda_dev *qdev; + struct qda_user *qda_user; + struct drm_qda_query *args = data; + int ret; + + ret = qda_validate_and_get_context(dev, file_priv, &qdev, &qda_user); + if (ret) + return ret; + + strscpy(args->dsp_name, qdev->dsp_name, sizeof(args->dsp_name)); + + return 0; +} diff --git a/drivers/accel/qda/qda_ioctl.h b/drivers/accel/qda/qda_ioctl.h new file mode 100644 index 000000000000..6bf3bcd28c0e --- /dev/null +++ b/drivers/accel/qda/qda_ioctl.h @@ -0,0 +1,26 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. + */ + +#ifndef _QDA_IOCTL_H +#define _QDA_IOCTL_H + +#include +#include +#include +#include "qda_drv.h" + +/** + * qda_ioctl_query - Query DSP device information and capabilities + * @dev: DRM device structure + * @data: User-space data containing query parameters and results + * @file_priv: DRM file private data + * + * This IOCTL handler queries information about the DSP device. + * + * Return: 0 on success, negative error code on failure + */ +int qda_ioctl_query(struct drm_device *dev, void *data, struct drm_file *file_priv); + +#endif /* _QDA_IOCTL_H */ diff --git a/include/uapi/drm/qda_accel.h b/include/uapi/drm/qda_accel.h new file mode 100644 index 000000000000..0aad791c4832 --- /dev/null +++ b/include/uapi/drm/qda_accel.h @@ -0,0 +1,47 @@ +/* SPDX-License-Identifier: GPL-2.0-only WITH Linux-syscall-note */ +/* + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. + */ + +#ifndef __QDA_ACCEL_H__ +#define __QDA_ACCEL_H__ + +#include "drm.h" + +#if defined(__cplusplus) +extern "C" { +#endif + +/* + * QDA IOCTL command numbers + * + * These define the command numbers for QDA-specific IOCTLs. + * They are used with DRM_COMMAND_BASE to create the full IOCTL numbers. + */ +#define DRM_QDA_QUERY 0x00 +/* + * QDA IOCTL definitions + * + * These macros define the actual IOCTL numbers used by userspace applications. + * They combine the command numbers with DRM_COMMAND_BASE and specify the + * data structure and direction (read/write) for each IOCTL. + */ +#define DRM_IOCTL_QDA_QUERY DRM_IOR(DRM_COMMAND_BASE + DRM_QDA_QUERY, struct drm_qda_query) + +/** + * struct drm_qda_query - Device information query structure + * @dsp_name: Name of DSP (e.g., "adsp", "cdsp", "cdsp1", "gdsp0", "gdsp1") + * + * This structure is used with DRM_IOCTL_QDA_QUERY to query device type, + * allowing userspace to identify which DSP a device node represents. The + * kernel provides the DSP name directly as a null-terminated string. + */ +struct drm_qda_query { + __u8 dsp_name[16]; +}; + +#if defined(__cplusplus) +} +#endif + +#endif /* __QDA_ACCEL_H__ */ -- 2.34.1