From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AEAF928750B for ; Tue, 24 Feb 2026 18:30:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771957823; cv=none; b=jJi1XgTGH+kP4NVeD476hh7uk39jXuDBkeNLpi+9NNKQf7TifbT4ZsXsCxgkdaqq+p14WNAp1QEwB+3PBu/gQmf5HBE5GTJM7ced1VT7zyVJowwq/1kEzFKxb9ay/EIEM4OHqg/ttq5DW0Ui+ymPODTq1/y+kgeSEVmc3APacRM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771957823; c=relaxed/simple; bh=03PWhkdD8XDT0HwrAZ3Kruf1L2fD8kllDVsuQ4ULThU=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=oUah0ZXxKY+4nEWu9UjlrQTSvjSE4n7KG7D+nzP7/EIzqSP6Rc+W5fmJSsx1mJjyB2ccdTGufsxwPNcWmIeyvpTUuyRNymRgMIfCMHkbHsfY5LbpQSkCJIGZY+uho1MvWXq68I02/YMe+txBS9ewBAcphMuv58ZxeVyOlixcATg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=QzewLFPn; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="QzewLFPn" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D60B9C116D0; Tue, 24 Feb 2026 18:30:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1771957823; bh=03PWhkdD8XDT0HwrAZ3Kruf1L2fD8kllDVsuQ4ULThU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=QzewLFPnkpX7XAGPNb46J/oYeLhg5Sbv+ZU8d9yddomnEJo9fjEr5oS+/uBoPGdbY Lj49QjcIUmAeMDTIvDm/o5GnhotGNYBku3on7Y6MDic3ueaVl+AzkGOgdckoqtM/Hl 0/vSzVPpaatfu/u2upS2JH4WXD2WWiBfogTyTue0= Date: Tue, 24 Feb 2026 10:30:22 -0800 From: Andrew Morton To: Michal Clapinski Cc: Evangelos Petrongonas , Pasha Tatashin , Mike Rapoport , Pratyush Yadav , Alexander Graf , kexec@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 2/2] kho: make preserved pages compatible with deferred struct page init Message-Id: <20260224103022.37b8b6d1cd11e11aef192c87@linux-foundation.org> In-Reply-To: <20260220165203.3213375-3-mclapinski@google.com> References: <20260220165203.3213375-1-mclapinski@google.com> <20260220165203.3213375-3-mclapinski@google.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 20 Feb 2026 17:52:03 +0100 Michal Clapinski wrote: > From: Evangelos Petrongonas > > When CONFIG_DEFERRED_STRUCT_PAGE_INIT is enabled, struct page > initialization is deferred to parallel kthreads that run later > in the boot process. > > During KHO restoration, deserialize_bitmap() writes metadata for > each preserved memory region. However, if the struct page has not been > initialized, this write targets uninitialized memory, potentially > leading to errors like: > BUG: unable to handle page fault for address: ... > > Fix this by introducing kho_get_preserved_page(), which ensures > all struct pages in a preserved region are initialized by calling > init_deferred_page() which is a no-op when deferred init is disabled > or when the struct page is already initialized. > > ... > > static void __init deserialize_bitmap(unsigned int order, > struct khoser_mem_bitmap_ptr *elm) > { Doesn't exist any more! Can you please rework, retest and resend against mm.git's mm-new branch? git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm Thanks.