From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.andi.de1.cc (mail.andi.de1.cc [178.238.236.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 797323A0E8B for ; Tue, 24 Feb 2026 17:26:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.238.236.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771953963; cv=none; b=ef1tZK44KKaAH0dvG/g+N345efVZSjdb0yLS4N1NKsQQDNYnkrOlAfm1PWjqg5lw233DLoCPGsXYKq4BxahV5t/qUDVWE+/u6MDcObAQcy1lgqX3ZOxX6Gcx9B30e7IgR9ILSQLDFdoTOs/EGN9GIoDMMYTMIKgPqWCMBI3ceUU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771953963; c=relaxed/simple; bh=eiorXkS02htfU8r/8DQEDIRqTPfQegxf/ikIPhIMpys=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=DV/HEbYJ1txUCJp8EAaIyZcbWgoJvVkEQhepDPEvr2cJVYbPJ92u3tj7qunKjX6i9d4veW26UBUprI81DV5ybJxeul7yGPnY0fcbDraa9xU5Wr99GRw41djPQn5rgPZsmACuiV0I29f/tTaVMMHg4Ewf9C8p/rEswqtkBI8DwI4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=kemnade.info; spf=pass smtp.mailfrom=kemnade.info; dkim=pass (2048-bit key) header.d=kemnade.info header.i=@kemnade.info header.b=FGWE1HS0; arc=none smtp.client-ip=178.238.236.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=kemnade.info Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kemnade.info Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kemnade.info header.i=@kemnade.info header.b="FGWE1HS0" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=kemnade.info; s=20220719; h=References:In-Reply-To:Cc:From:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID; bh=s1D8S/1IeMLKayYEXjnXR287PJc/q90n4055HgRBIjM=; b=FGWE1HS0SH2jbPUs2mspo3rvzC Zgjl4YC3csj5rkH7BWjWjnEOon18gmfs0Vz3iYnJfXdpvynPmikbJzbp5pdflKo+vqp9HmKOLtPO4 60LaFDBvQnUHfdVohvtGtnTT0AmdO9+JM9If4MLSgNoTXhBRXyNU4VLflR9Om7tY5P4hyxeUCwGuU AjItA5/rrqNGYJKeyepdzYSNIx1nPrtNPWpaIIik4t3He8Zk1TPZmL5JZfLE5bZNnNBgd3GmN8fGv gh1aLB9+w8CRLCfwPBjsqGzEhiaK2WWYs0YRIsutwdhGowhfjx+gjgZ9idV2clQxnrkGhqeujncqD yxRTbGKg==; Date: Tue, 24 Feb 2026 12:20:46 +0100 From: Andreas Kemnade To: Felix Gu Cc: Liam Girdwood , Mark Brown , linux-kernel@vger.kernel.org Subject: Re: [PATCH] regulator: fp9931: Fix PM runtime reference leak in fp9931_hwmon_read() Message-ID: <20260224122046.5bb1d960@kemnade.info> In-Reply-To: <20260224-fp9931-v1-1-1cf05cabef4a@gmail.com> References: <20260224-fp9931-v1-1-1cf05cabef4a@gmail.com> X-Mailer: Claws Mail 4.3.1 (GTK 3.24.49; aarch64-unknown-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 24 Feb 2026 18:07:59 +0800 Felix Gu wrote: > In fp9931_hwmon_read(), if regmap_read() failed, the function returned > the error code without calling pm_runtime_put_autosuspend(), causing > a PM reference leak. > > Fixes: 12d821bd13d4 ("regulator: Add FP9931/JD9930 driver") > Signed-off-by: Felix Gu Reviewed-by: Andreas Kemnade