From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f228.google.com (mail-yw1-f228.google.com [209.85.128.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4278F3A8FE1 for ; Tue, 24 Feb 2026 17:15:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.228 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771953304; cv=none; b=mVqiBrCFCjoWJKMfUvJqYRt98GpJ/eE6Osi0IGrfDnkhyyUSEjXsF699qW2d/JUT/h1RrAgky7dqQIhsvPUyKPWhuPttEWHNOkn7Z3ENA7z3Ttc5ORJFG+oUMQWur7TeuO/d8cN+QvwuFnpOSr8Pk+hhcS9biryJqUpzy2/4PZo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771953304; c=relaxed/simple; bh=NdPvYIVAiaJrTIXUdUqqs5xQQgNiklVTzdScYSwE5do=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UYqfn6H+HlvqIKHzsYzeJXJB6L8VqFczwFcP16mwe4EhVS/LUPSPjiCZ6F6jH1EP3LFCrpw4X/s6UAz9lfkUyaIN1LQdEpiQA9/xv/IsBZnki8hkg+vmdeAWMyxFokrqJ046neXGVsEkMvZRwI8pIzVipBmmPZZkr7iVtt30kAo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com; spf=fail smtp.mailfrom=purestorage.com; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b=XwWanbkn; arc=none smtp.client-ip=209.85.128.228 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=purestorage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b="XwWanbkn" Received: by mail-yw1-f228.google.com with SMTP id 00721157ae682-79636336576so1642947b3.0 for ; Tue, 24 Feb 2026 09:15:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1771953302; x=1772558102; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=d5MnxCfiSl8pO88LgItQirBF6Sk69OYbyQL24d2UZK0=; b=XwWanbknJ3KmXyucrz+0x0Ps788Cly6iCgyrbbylCmiGAVxjm0umUZ9oVUhBcK72qQ oO0Pac5yu3wxoN0gpJcmFcyJwAghpLp5zu5ch29wq/5z2rWgWoHkhztc1fHgZEilmPQf toMS7InfRh1gWJYrfuZP1QCKC14M+7opfUVkDbv2GNfFIuMKCwiPUMcA5e8qG7lWltDY 0iPW4X9YYR+eBll/QH3LXi3RdK3SxVUfHDbFWTtKRkUQtclYUJhSE5Za81EFyKtjBybr NWX0OZz+RhJcuqT5CSVMeEQgX+rPEh+eeTXs0u5VlS7gOqH+Rx1nbEwviSPMGpNbwvmv IiUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771953302; x=1772558102; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=d5MnxCfiSl8pO88LgItQirBF6Sk69OYbyQL24d2UZK0=; b=S5AM5I2fu74wCxpbQF0oNenTKpni9A60aSK0BtUJCz56eCpyQPhdsDmnooz6jES3LZ RSPLgXErnL6HJaJ4OMR328TB71Rnip1GLlpoLeq6yyhbslOE+BiXCFiPQ7pSeRGQRT/t u3gmmiDMv87GDFwIzEU2SxW5dkYf2vcT/FHbmXwycPyTHBfnwwj3sf/UQYiRLdRwQy9r q10LxFT5u3GloDtMwwS70I9k+s7K+dg17ki40BfZiCc9NknHF8FfLz5m7lGr3ENGVPXU hw+yr0VCwN8OhjLhFPKmsHUdFuABE1HQCc0hRaqcJNQWB9HsMS1iGQdYKCrCKhG1Af5l HemQ== X-Forwarded-Encrypted: i=1; AJvYcCVNyM/njsVi2w1WpFZHUR/Y3ocSF+QsWT94s7stKxx2okS9YM/8ODxa9A7wCVNW6cbHwiY0uIGVKPCnAHU=@vger.kernel.org X-Gm-Message-State: AOJu0YwXmqUF0VucybyKEiLJELEe4Im9pKAVDZetXkIwf4mDFEaxZZQ3 TaC+DfW5hmfSePxq34/Ks1gU5xToSuHtOJ6NSV2Uaxj/t6d7ucuEUq3z9/aT6/swCh8j0A8l9Nn OWdS9CykoJjx8taqiw02xTjIR+i2jRtfciwAb X-Gm-Gg: ATEYQzwSc7JIi4z+oiy014odRhaitKWjxyzYWxeJohBA/AIh7OSVd0MTPmSuFSPXqzA sj+o9DgkZMS01X2G3s5EYwwblO36qrKEv2TatbFr4Y7Qpd7Va/kdhLHbcT9MtmkLL/5bxv1isRu UHebiqA2dUEoC7vOt5olKQ0xLv5REDJz80ToYPjWru0UY0d8DO6lEAjGaoCLMCP5CmNb8u+EQXh JSRpdJusPXb2gEjn/0DexOxC2i/ZwsISGN6CxnJnS8t5/p3DIsjtDvBDaS99BOcx7c2V3yU7EwT kqDKt8DHTpENN/ZhaCjGEySIgzKJx/PON9kwgkxDHRwie6MqPrfwJTyx2Rm5KiQo1BJ2GLmc5VN Pj8EDgCq5kFRaHXnhFvdvXo+t4se/IliYfc7oDce7GCFRHuTGBA9ddw== X-Received: by 2002:a05:690c:82:b0:794:2019:29b with SMTP id 00721157ae682-79828f7233fmr100481647b3.3.1771953302220; Tue, 24 Feb 2026 09:15:02 -0800 (PST) Received: from c7-smtp-2023.dev.purestorage.com ([208.88.159.129]) by smtp-relay.gmail.com with ESMTPS id 00721157ae682-7982de1ca32sm13166237b3.29.2026.02.24.09.15.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Feb 2026 09:15:02 -0800 (PST) X-Relaying-Domain: purestorage.com Received: from dev-csander.dev.purestorage.com (dev-csander.dev.purestorage.com [10.112.29.101]) by c7-smtp-2023.dev.purestorage.com (Postfix) with ESMTP id 791C934211E; Tue, 24 Feb 2026 10:15:01 -0700 (MST) Received: by dev-csander.dev.purestorage.com (Postfix, from userid 1557716354) id 73E66E41254; Tue, 24 Feb 2026 10:15:01 -0700 (MST) From: Caleb Sander Mateos To: Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , Chaitanya Kulkarni Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Caleb Sander Mateos Subject: [PATCH v3 4/8] nvme: always issue I/O Command Set specific Identify Namespace Date: Tue, 24 Feb 2026 10:14:33 -0700 Message-ID: <20260224171437.3175993-5-csander@purestorage.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20260224171437.3175993-1-csander@purestorage.com> References: <20260224171437.3175993-1-csander@purestorage.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Currently, the I/O Command Set specific Identify Namespace structure is only fetched for controllers that support extended LBA formats. This is because struct nvme_id_ns_nvm is only used by nvme_configure_pi_elbas(), which is only called when the ELBAS bit is set in the CTRATT field of the Identify Controller structure. However, the I/O Command Set specific Identify Namespace structure will soon be used in nvme_update_disk_info(), so always try to obtain it in nvme_update_ns_info_block() if the controller supports NVMe version 2.0 or later. Signed-off-by: Caleb Sander Mateos Reviewed-by: Christoph Hellwig --- drivers/nvme/host/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c index bff6f26d7bcf..2b433478f328 100644 --- a/drivers/nvme/host/core.c +++ b/drivers/nvme/host/core.c @@ -2352,11 +2352,11 @@ static int nvme_update_ns_info_block(struct nvme_ns *ns, ret = -ENXIO; goto out; } lbaf = nvme_lbaf_index(id->flbas); - if (ns->ctrl->ctratt & NVME_CTRL_ATTR_ELBAS) { + if (ns->ctrl->vs >= NVME_VS(2, 0, 0)) { ret = nvme_identify_ns_nvm(ns->ctrl, info->nsid, &nvm); if (ret < 0) goto out; } -- 2.45.2