mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hardik Phalet <hardik.phalet@pm.me>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Vaibhav Agarwal <vaibhav.sr@gmail.com>
Cc: Dan Carpenter <dan.carpenter@linaro.org>,
	Mark Greer <mgreer@animalcreek.com>,
	Johan Hovold <johan@kernel.org>, Alex Elder <elder@kernel.org>,
	greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org, Hardik Phalet <hardik.phalet@pm.me>
Subject: [PATCH v3 0/2] staging: greybus: audio: remove dead code and clean up
Date: Tue, 24 Feb 2026 18:54:46 +0000	[thread overview]
Message-ID: <20260224185421.824210-1-hardik.phalet@pm.me> (raw)

This series cleans up dead code in the Greybus audio manager.

gb_audio_manager_get_module() has no in-tree callers. The previously
reported NULL dereference is therefore unreachable. Per review feedback,
the unused function is removed to avoid carrying dead code.

Patch 2 performs a small cleanup in the same area.

Changes in v3:
- Replaced the NULL-deref fix with removal of gb_audio_manager_get_module()
  since there are no in-tree callers (per Greg KH).
- No functional changes otherwise.

Thanks for the review.

Signed-off-by: Hardik Phalet <hardik.phalet@pm.me>

Hardik Phalet (2):
  staging: greybus: audio: remove unused gb_audio_manager_get_module()
  staging: greybus: audio: drop stale TODO comment

 drivers/staging/greybus/audio_manager.c        | 12 ------------
 drivers/staging/greybus/audio_manager.h        |  7 -------
 drivers/staging/greybus/audio_manager_module.c |  1 -
 3 files changed, 20 deletions(-)

-- 
2.53.0



             reply	other threads:[~2026-02-24 18:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-24 18:54 Hardik Phalet [this message]
2026-02-24 18:54 ` [PATCH v3 1/2] staging: greybus: audio: remove unused gb_audio_manager_get_module() Hardik Phalet
2026-02-25 15:04   ` Greg Kroah-Hartman
2026-02-24 18:55 ` [PATCH v3 2/2] staging: greybus: audio: drop stale TODO comment Hardik Phalet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260224185421.824210-1-hardik.phalet@pm.me \
    --to=hardik.phalet@pm.me \
    --cc=dan.carpenter@linaro.org \
    --cc=elder@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=greybus-dev@lists.linaro.org \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=mgreer@animalcreek.com \
    --cc=vaibhav.sr@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®