From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 479292EACF9 for ; Tue, 24 Feb 2026 19:05:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771959921; cv=none; b=TguY+pabLkWa6U5LlgC5BRNhQ7cB3wqfFWCzIePJmhUITfNNXGhyzIGnr8rEodUnQ8ThaCvRkTCR8CSzYwlmLy+ZDYqn0S36g6DuEZe5BzHE6eKh0PY0731nnp3soN6FlZGW4+DVYTf84P6bQMeywn0IacWj/pizermTP0YvHRE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771959921; c=relaxed/simple; bh=0FuowrmXWz5fweQD82lQddocIRrSqNVvenJqi997sYE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=XCMauAfIGE4a9YVwQjZsoMTwGDuI8KHpojhvH12Rfx0BMG7rlzV6pThY3pBwN+n6lpm/4zXtL/9VtV1ZYnAr7mc0L+yPJPgSrQGBWYZj+Vk14K5PaYlx/MBBI5jU2cf1GG3BCn4xy6n1bRazwAPW27UWSi4y//NfkmkbxFsoNnE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EmErRP+l; arc=none smtp.client-ip=209.85.215.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EmErRP+l" Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-c6e1d3e4dc4so1300949a12.3 for ; Tue, 24 Feb 2026 11:05:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771959920; x=1772564720; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0FuowrmXWz5fweQD82lQddocIRrSqNVvenJqi997sYE=; b=EmErRP+lIk/zboczs9ZATk9OCeMQ0Z3d04ypkGpHqHBNEGiq7OniCVOOPuJlWl6iHV 0YYJFXxvUPfKczvJRPCOm2iO1OK4EcCTfbm8SXcuidxXrI885eKv7uVIJPzOXONiWPa5 3ST3WoOq9jepJFHq73b9FgnE/IZjYEhjviICoe5aVclXB+HuniYxzn0iir5ciV/e6LOa HFbWyGmgXV26uqbYh70D4ZHH2cRf5NvARud0fMk2S4P7zce3sgZrGm7FlRRG3hgKv+3v VhY4BBYYDmyIhP3kAKJXHky4L/iuzVsV1GWpcIBbQL/uB4Ma63dlkQqDjCWamLuzHeaC TJow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771959920; x=1772564720; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=0FuowrmXWz5fweQD82lQddocIRrSqNVvenJqi997sYE=; b=ZcOkGmlgsworMcdWKap0IYpnBwX9D/tRw6gSURn4LXYuk7rMRPrVywiAP0ZzAUWwor Xl+2qCAdiAfsTMCES48SYhDJXnxO+/KuY5pjeMlrfAdEauUBlWIfZc+odgyXouJEYxRq JdU58gBbYhFJVKRAY6uFsCXU8TxquhSlL2XyTdFnfJLRr47ZXt2hEa8yPfW1MvzFEptL PPGLyTys4lUcE8f4eALz3vOtL58f5wCWjw6NzyvSYU37yQDWKYGWbjFvMsDRI80Il0Q+ RzlcZAv5N8JYYYiCjgIUF3wV6+V0pS1N9t7+uIBKBbV+9YOpDxpIMWM+vS23ip2bEi+5 cehQ== X-Forwarded-Encrypted: i=1; AJvYcCW980x3k4caQNN5J9gHwDXhHvANgN6QL+4ep847/qi4+3lmcKTX29equtvQNqCoO+rh8TYbl/B8jd4ISoQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yy2XLDVWm7ZTol79b0mXyeDp9FFGZX81T4ubex226kmVDDUUHAl CvCSD63/Esmq8+XvOwYEJliv8wgixb0ZgYj73GuhJPCHzf2Dq8Vpr/Tp X-Gm-Gg: ATEYQzwTx1b1bXBLJXUb6JIQtUbp+9zQ1xt/aVRgG2SA4S8HtP6GFjeFCwn3PDW2X2u DcAx1GnrBxUgiVHxVbpB9ahC8YUpMK98+PQtERlmU59DEX5aoigdu1mxN7LLMJuWc3TX4W8NNOE 3MzXAswaoMBFthaAkZeiifT0NrtVhwGfJua9QzOx6qIoEhcu7KbTyyC0oNRtBn6WCG5ZcDBsNnP GNDj6TYRxU28EYKT28kv1iDSzmQkCIyvePgoLIP4jSjYDbHChA1pkRYb85Wni3XNsNgtdccWMuf r5aJ+/DUXU5fbPwY5y/IPRd1gzlgPb/zTEoOm7cw6WJGEdMWr49KOE2rcFDFZSE7p/11DyxvhpT o1cMZv1GSsWc5TVDHPfq6bJZilC8V6IY/+vov6DHWuPRxZ/nb92cX6MXthNKDEG7L387Busv2Jr dpZVEIx2V1F6rpTzUY8W7mK4NnMEoBtvCZvjQ= X-Received: by 2002:a17:90b:3d8c:b0:354:b2f6:b4e4 with SMTP id 98e67ed59e1d1-358ae6adc2amr9880998a91.0.1771959919516; Tue, 24 Feb 2026 11:05:19 -0800 (PST) Received: from fedora ([2409:40e5:11e8:25ba:c234:5daa:9801:9675]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-359029d9d2fsm566993a91.13.2026.02.24.11.05.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Feb 2026 11:05:18 -0800 (PST) From: Shubham Chakraborty To: gregkh@linuxfoundation.org Cc: vaibhav.sr@gmail.com, mgreer@animalcreek.com, johan@kernel.org, elder@kernel.org, greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] staging: greybus: audio: Use sysfs_emit in show functions Date: Wed, 25 Feb 2026 00:35:04 +0530 Message-ID: <20260224190506.23334-1-chakrabortyshubham66@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <2026022438-gamma-blog-1561@gregkh> References: <2026022438-gamma-blog-1561@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi Greg, You are right. The \n additions were a mistake on my part — the original sprintf calls did not include \n and I should not have changed the output behavior in the same patch. I will send a v4 that does a pure mechanical conversion from sprintf to sysfs_emit with no change in output, keeping the format strings identical to the originals. Thank you for the review. Shubham