mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: AnishMulay <anishm7030@gmail.com>
To: Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>
Cc: Viacheslav Dubeyko <Slava.Dubeyko@ibm.com>,
	Damien Le Moal <dlemoal@kernel.org>,
	Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
	linux-kernel@vger.kernel.org, AnishMulay <anishm7030@gmail.com>
Subject: [PATCH] ramfs: convert alloc_pages() to folio_alloc() in ramfs_nommu_expand_for_mapping()
Date: Tue, 24 Feb 2026 15:31:34 -0500	[thread overview]
Message-ID: <20260224203134.101436-1-anishm7030@gmail.com> (raw)

Currently, ramfs_nommu_expand_for_mapping() utilizes the deprecated
alloc_pages() API. This patch converts the allocation step to use
the modern folio_alloc() API, removing a legacy caller and helping
pave the way for the eventual removal of alloc_pages().

Because nommu architectures require physically contiguous memory that
often needs to be trimmed to the exact requested size, the allocated
folio is immediately shattered using split_page().

Since split_page() destroys the compound folio metadata, using folio
iteration helpers (like folio_page) becomes unsafe. Therefore, this
patch deliberately drops back to a standard struct page array after
the split. This safely isolates the folio conversion to the allocation
phase while strictly preserving the existing trimming and page cache
insertion behavior.

Signed-off-by: AnishMulay <anishm7030@gmail.com>
---
 fs/ramfs/file-nommu.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/fs/ramfs/file-nommu.c b/fs/ramfs/file-nommu.c
index 77b8ca2757e0d..767de8fc56f0f 100644
--- a/fs/ramfs/file-nommu.c
+++ b/fs/ramfs/file-nommu.c
@@ -62,6 +62,7 @@ const struct inode_operations ramfs_file_inode_operations = {
 int ramfs_nommu_expand_for_mapping(struct inode *inode, size_t newsize)
 {
 	unsigned long npages, xpages, loop;
+	struct folio *folio;
 	struct page *pages;
 	unsigned order;
 	void *data;
@@ -81,10 +82,12 @@ int ramfs_nommu_expand_for_mapping(struct inode *inode, size_t newsize)
 
 	/* allocate enough contiguous pages to be able to satisfy the
 	 * request */
-	pages = alloc_pages(gfp, order);
-	if (!pages)
+	folio = folio_alloc(gfp, order);
+	if (!folio)
 		return -ENOMEM;
 
+	pages = &folio->page;
+
 	/* split the high-order page into an array of single pages */
 	xpages = 1UL << order;
 	npages = (newsize + PAGE_SIZE - 1) >> PAGE_SHIFT;
-- 
2.51.0


             reply	other threads:[~2026-02-24 20:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-24 20:31 AnishMulay [this message]
2026-02-25 18:44 ` Viacheslav Dubeyko
2026-02-25 22:18   ` Matthew Wilcox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260224203134.101436-1-anishm7030@gmail.com \
    --to=anishm7030@gmail.com \
    --cc=Slava.Dubeyko@ibm.com \
    --cc=brauner@kernel.org \
    --cc=dlemoal@kernel.org \
    --cc=jack@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lorenzo.stoakes@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®