From: Vasiliy Kovalev <kovalev@altlinux.org>
To: Thomas Winischhofer <thomas@winischhofer.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
lvc-project@linuxtesting.org, kovalev@altlinux.org
Subject: [PATCH v2 0/2] USB: sisusbvga: Fix integer overflow and NULL dereference
Date: Wed, 25 Feb 2026 00:55:05 +0300 [thread overview]
Message-ID: <20260224215507.1736020-1-kovalev@altlinux.org> (raw)
This series fixes two issues in the sisusbvga driver found by static
analysis and confirmed through testing with USB gadget emulation:
1. Integer overflow in boundary check of sisusb_clear_vram() that can be
triggered by a compromised USB device reporting inflated VRAM size.
2. NULL pointer dereference in sisusb_read_mem_bulk() when both
kernbuffer and userbuffer are NULL, causing immediate kernel panic.
Both issues are reproducible with the 'USB Gadget Tests' framework [1].
v2:
- Patch 2/2: Move NULL check into sisusb_read_mem_bulk() and
return -EINVAL (suggested by Fedor Pchelkin)
[1] https://github.com/kovalev0/usb-gadget-tests
Vasiliy Kovalev (2):
USB: sisusbvga: Fix integer overflow in sisusb_clear_vram
USB: sisusbvga: Fix NULL pointer dereference in sisusb_read_mem_bulk
drivers/usb/misc/sisusbvga/sisusbvga.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
--
2.50.1
next reply other threads:[~2026-02-24 21:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-24 21:55 Vasiliy Kovalev [this message]
2026-02-24 21:55 ` [PATCH v2 1/2] USB: sisusbvga: Fix integer overflow in sisusb_clear_vram Vasiliy Kovalev
2026-02-24 21:55 ` [PATCH v2 2/2] USB: sisusbvga: Fix NULL pointer dereference in sisusb_read_mem_bulk Vasiliy Kovalev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260224215507.1736020-1-kovalev@altlinux.org \
--to=kovalev@altlinux.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=thomas@winischhofer.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®