From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f175.google.com (mail-yw1-f175.google.com [209.85.128.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6DCA334D391 for ; Tue, 24 Feb 2026 22:48:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771973330; cv=none; b=JzX7iQ22E7Ht+jGX/q1xHAAk89Bop6qNyRHCYVsXcVg3GGrE+rtoa9taNMRaPpghbgLy3PISZIk3NEs0ow6zCvBK+nLPLiVvjZeVR6Py8Ugk5Mwocob8V/5vh2Rd879GWiSOZZDCiFMs7VA8Urzv9o+tmgEFiJ2UKemw447sqzU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771973330; c=relaxed/simple; bh=nmugurTC3LquwwQ3c1ikZQil6rC8xY1wLp3DAB/gqsA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MkorOliMle7jzywBO8b6I+h0gdl98JrlD2OuJA7+0iVPpce+gvlKrVYouT+fNcMujOf+1IEqFUCc86/1Ua1ALhASLruKhJ2FCLyTHKKDzRH/WSwh83yR32Et06SAOM8WA6vlTH3R1haS1yMVKI4ziFn2KgRhHw5QOcZrHy6fPAk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gC1JKzm+; arc=none smtp.client-ip=209.85.128.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gC1JKzm+" Received: by mail-yw1-f175.google.com with SMTP id 00721157ae682-7964fb9ae3dso54530087b3.0 for ; Tue, 24 Feb 2026 14:48:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771973327; x=1772578127; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=iRmBa3MakDv6vabRp84EIeQ9FVfS2U/MlXhf84RaaaU=; b=gC1JKzm+1up+NQ/0qjJQc0FUsas4V5RVB1iOafT+trxakAs5GWRYEG09jzWtDRHLtE sxXdfR17+1p77bnMA5EUJRkdE+xDa3yfiN684yVi/bsVXg/hf4XLUUrMGVRvDSRZ6pES wxgDsfn1MaeilaiwVyvJJakXFaC7KB0M4vNqIan0Jv8vw9o/kSZNF8lnDo1btZWPWO97 vYFAJWZyMK8X26LYQop9teEndToNKGZnkDTHp15RMqBDrPPBGmF8h5LZQcZ7W9zVpCTK UOBZRcrDc91kBqlqm8UeFysDQplC/2peTqpJrnUUlgGNmIjNCdFhzBwM0naq2oDYQzS/ jNcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771973327; x=1772578127; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=iRmBa3MakDv6vabRp84EIeQ9FVfS2U/MlXhf84RaaaU=; b=OvB76WkI83Qbcop300avshc4kAPXAYQBwaYmpR0sgjgs/UE/GKM3YkzvvyTYUbAOiF Z/BdwLEolSRDEgfKoPni9UWbvm5WJrL2fnFv0GzbpCOf1p4PmlNAwnSyfZwtqF0FCeoi 2+suMb/jKD/nZM7WB1OcP2B5m6k5dsxdKOqp5b1AcS5mxgK5LaWVC/zV/Qe4d0ODDlU0 awVVsPv4hxrANOZO2aXWdJYxzBdcwPu2DZePGJ8ZdakSIidOhBqosOIvlVpYgr+aq9iJ /YSn2ZxI619tCC8pDHPIDi88/8LuOqBaJOanjK/7Fl98KuNjB9u+on3V1VdFFMbjvjFQ JzAQ== X-Forwarded-Encrypted: i=1; AJvYcCVbXGVbOSMd4pqnx3l7bnWPbO32RKSJ1fpPvjkJELOgeBKPmDVHz16ljSlc5UGqKL0EFEarCby8wt+8kmk=@vger.kernel.org X-Gm-Message-State: AOJu0Yz7Z7DRAWibIJ4KLs/cGGbMPGkS3bRpC6TwscxaN5GwQv/i6Ycj 2p4XnJWjfx+Va8PSpM/jPKCNOHxzPyud41V9LjvRg/iA6F1BaQ+rShY4 X-Gm-Gg: ATEYQzxyPUupe4yEhvaSqRY8TNV8fFNfw5SI+XPUqDKXeK3zOwm/zdYC0RFFZijzYvv VoTHEd2HcGltZwq4CHzOjub3+rAglohjd1u991dt9fVljYyCQYYlsDb15NBqQjJkXTVn7yejibX DJgBML07BFkPSYF5pO4B8mJb7d9jQcvgsOC4u/5eMM1vvHicz2mOmyrdAhW2R5t3kxGwXOOM8WX NPohEgZmvJHqfKsAz5y3QsJ6POT4L35yl4ibF9Tn31jJ2y56BUsNEfMxRbXs5ggrSnASEhMB4E1 HkiWsWtg4hnDKJpvBSGDNxpKvQxlvjBsmYGsFEhICnLchIgdfDawi6a5dlYq4GXTaBTuL1NfbBP /Wb/42CIw+pEK8/pLdqmQ8+kMApPzsYqaKYXPAEid4gfYBsQxgP2r88kmCAkKKxBNZGYkDbs4E0 X1I6Ly9nuHR2JMSlbmcVbZ5XOFUJajfX/AX7ZeznNq3cVyLcC8OjWgXVQEmZDDhJigzghnO1ose 0wRJarhScBXoBvqp9EG5ucEpYQ7+ey6xqI= X-Received: by 2002:a05:690c:101:b0:798:5951:f42b with SMTP id 00721157ae682-7985951fb32mr45275177b3.42.1771973327471; Tue, 24 Feb 2026 14:48:47 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00::5c0b]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7982dd88efcsm48838757b3.24.2026.02.24.14.48.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Feb 2026 14:48:47 -0800 (PST) From: Ethan Tidmore To: linusw@kernel.org, jic23@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH v3 2/4] iio: gyro: mpu3050: Fix irq resource leak Date: Tue, 24 Feb 2026 16:48:16 -0600 Message-ID: <20260224224818.2452675-3-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260224224818.2452675-1-ethantidmore06@gmail.com> References: <20260224224818.2452675-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The interrupt handler is setup but only a few lines down if iio_trigger_register() fails the function returns without properly releasing the handler. Add cleanup goto to resolve resource leak. Detected by Smatch: drivers/iio/gyro/mpu3050-core.c:1128 mpu3050_trigger_probe() warn: 'irq' from request_threaded_irq() not released on lines: 1124. Fixes: 3904b28efb2c7 ("iio: gyro: Add driver for the MPU-3050 gyroscope") Reviewed-by: Linus Walleij Signed-off-by: Ethan Tidmore --- v3: - Remove unneeded code snippet. v2: - Use manual cleanup instead of devm_. drivers/iio/gyro/mpu3050-core.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/iio/gyro/mpu3050-core.c b/drivers/iio/gyro/mpu3050-core.c index 06162d886b59..b6e05afbe512 100644 --- a/drivers/iio/gyro/mpu3050-core.c +++ b/drivers/iio/gyro/mpu3050-core.c @@ -1121,11 +1121,16 @@ static int mpu3050_trigger_probe(struct iio_dev *indio_dev, int irq) ret = iio_trigger_register(mpu3050->trig); if (ret) - return ret; + goto err_iio_trigger; indio_dev->trig = iio_trigger_get(mpu3050->trig); return 0; + +err_iio_trigger: + free_irq(mpu3050->irq, mpu3050->trig); + + return ret; } int mpu3050_common_probe(struct device *dev, -- 2.53.0