mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Frank Li <Frank.Li@nxp.com>
To: Rob Herring <robh@kernel.org>, Vinod Koul <vkoul@kernel.org>,
	 Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	 Pengutronix Kernel Team <kernel@pengutronix.de>,
	 Fabio Estevam <festevam@gmail.com>,
	Saravana Kannan <saravanak@kernel.org>
Cc: dmaengine@vger.kernel.org, devicetree@vger.kernel.org,
	 linux-kernel@vger.kernel.org, imx@lists.linux.dev,
	 linux-arm-kernel@lists.infradead.org,
	Shawn Guo <shawn.guo@freescale.com>,  Frank Li <Frank.Li@nxp.com>
Subject: [PATCH v3 08/13] dmaengine: imx-sdma: Use devm_clk_get_prepared() to simplify code
Date: Wed, 25 Feb 2026 16:41:44 -0500	[thread overview]
Message-ID: <20260225-mxsdma-module-v3-8-8f798b13baa6@nxp.com> (raw)
In-Reply-To: <20260225-mxsdma-module-v3-0-8f798b13baa6@nxp.com>

Use devm_clk_get_prepared() to simplify code. No functional change.

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 drivers/dma/imx-sdma.c | 26 +++++---------------------
 1 file changed, 5 insertions(+), 21 deletions(-)

diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
index 4c8196d78001201bd354bbdb8057440eae625030..187e8e573fdf437a0d614548f1aa777a0ba3e24d 100644
--- a/drivers/dma/imx-sdma.c
+++ b/drivers/dma/imx-sdma.c
@@ -2265,34 +2265,24 @@ static int sdma_probe(struct platform_device *pdev)
 	if (IS_ERR(sdma->regs))
 		return PTR_ERR(sdma->regs);
 
-	sdma->clk_ipg = devm_clk_get(&pdev->dev, "ipg");
+	sdma->clk_ipg = devm_clk_get_prepared(&pdev->dev, "ipg");
 	if (IS_ERR(sdma->clk_ipg))
 		return PTR_ERR(sdma->clk_ipg);
 
-	sdma->clk_ahb = devm_clk_get(&pdev->dev, "ahb");
+	sdma->clk_ahb = devm_clk_get_prepared(&pdev->dev, "ahb");
 	if (IS_ERR(sdma->clk_ahb))
 		return PTR_ERR(sdma->clk_ahb);
 
-	ret = clk_prepare(sdma->clk_ipg);
-	if (ret)
-		return ret;
-
-	ret = clk_prepare(sdma->clk_ahb);
-	if (ret)
-		goto err_clk;
-
 	ret = devm_request_irq(&pdev->dev, irq, sdma_int_handler, 0,
 				dev_name(&pdev->dev), sdma);
 	if (ret)
-		goto err_irq;
+		return ret;
 
 	sdma->irq = irq;
 
 	sdma->script_addrs = kzalloc_obj(*sdma->script_addrs);
-	if (!sdma->script_addrs) {
-		ret = -ENOMEM;
-		goto err_irq;
-	}
+	if (!sdma->script_addrs)
+		return -ENOMEM;
 
 	/* initially no scripts available */
 	saddr_arr = (s32 *)sdma->script_addrs;
@@ -2406,10 +2396,6 @@ static int sdma_probe(struct platform_device *pdev)
 	dma_async_device_unregister(&sdma->dma_device);
 err_init:
 	kfree(sdma->script_addrs);
-err_irq:
-	clk_unprepare(sdma->clk_ahb);
-err_clk:
-	clk_unprepare(sdma->clk_ipg);
 	return ret;
 }
 
@@ -2421,8 +2407,6 @@ static void sdma_remove(struct platform_device *pdev)
 	devm_free_irq(&pdev->dev, sdma->irq, sdma);
 	dma_async_device_unregister(&sdma->dma_device);
 	kfree(sdma->script_addrs);
-	clk_unprepare(sdma->clk_ahb);
-	clk_unprepare(sdma->clk_ipg);
 	/* Kill the tasklet */
 	for (i = 0; i < MAX_DMA_CHANNELS; i++) {
 		struct sdma_channel *sdmac = &sdma->channel[i];

-- 
2.43.0


  parent reply	other threads:[~2026-02-25 21:42 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-25 21:41 [PATCH v3 00/13] dmaegnine: freescale-dmas: small improvement Frank Li
2026-02-25 21:41 ` [PATCH v3 01/13] dmaengine: of_dma: Add devm_of_dma_controller_register() Frank Li
2026-02-25 21:41 ` [PATCH v3 02/13] dmaengine: mxs-dma: Fix missing return value from of_dma_controller_register() Frank Li
2026-02-25 21:41 ` [PATCH v3 03/13] dmaengine: mxs-dma: Use local dev variable in probe() Frank Li
2026-02-25 21:41 ` [PATCH v3 04/13] dmaengine: mxs-dma: Use dev_err_probe() to simplify code Frank Li
2026-02-25 21:41 ` [PATCH v3 05/13] dmaengine: mxs-dma: Use managed API devm_of_dma_controller_register() Frank Li
2026-02-25 21:41 ` [PATCH v3 06/13] dmaengine: mxs-dma: Add module license and description Frank Li
2026-02-25 21:41 ` [PATCH v3 07/13] dmaengine: mxs-dma: Turn MXS_DMA as tristate Frank Li
2026-02-25 21:41 ` Frank Li [this message]
2026-02-25 21:41 ` [PATCH v3 09/13] dmaengine: imx-sdma: Use managed API to simplify code Frank Li
2026-02-25 21:41 ` [PATCH v3 10/13] dmaengine: imx-sdma: Use dev_err_probe() " Frank Li
2026-02-25 21:41 ` [PATCH v3 11/13] dmaengine: fsl-edma: Use managed API dmaenginem_async_device_register() Frank Li
2026-02-25 21:41 ` [PATCH v3 12/13] dmaengine: fsl-edma: Use dev_err_probe() to simplify code Frank Li
2026-02-25 21:41 ` [PATCH v3 13/13] dmaengine: fsl-qdma: " Frank Li
2026-03-09 11:45 ` [PATCH v3 00/13] dmaegnine: freescale-dmas: small improvement Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260225-mxsdma-module-v3-8-8f798b13baa6@nxp.com \
    --to=frank.li@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=saravanak@kernel.org \
    --cc=shawn.guo@freescale.com \
    --cc=shawnguo@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®