From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A397213254 for ; Wed, 25 Feb 2026 02:41:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771987310; cv=none; b=MHTmpIphc9lUZiBhSyW3I2K2eRkLDY5zZN8FA1WFByWrn5u3bhrvACgFoexnO1Pwd/q0DPfTr+ClFX66xDuJnlz6cmXS9gJklfIQQfpyEr3VnQBdlvaTzyvbqWMRSImIjA9PEJR6856szBT5RXQpU96TnWISwcejmChms5mxzgk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771987310; c=relaxed/simple; bh=X+UCdq3EltqI2kB2VmHcF9/abSCI9lHMHlMt8E+9skw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cEsnA2Z2Yd8qO/OpWBDV7QMxfLngs0uEWz+eUHUISlhxKfUFESxtj6rbV0930RRQEfPaV6OJa+JLMmgsbedxV9tqwseS6eTrW/8d+afUy6jao1AIKF6EqMkIlNKKKdZhYqaES6CtC/5c1GZ/i1OJIp3WWvea4FDeRhmBt9F/Z7U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=oE73Lipz; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="oE73Lipz" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BD360C116D0; Wed, 25 Feb 2026 02:41:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1771987310; bh=X+UCdq3EltqI2kB2VmHcF9/abSCI9lHMHlMt8E+9skw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oE73Lipz7L7jhvkhCXqac26wsSU0x3y8PBJpcNZ7pe46/1BfZAXyoGdt3hDYbbdjO Ewb2I/doxXaY29qKojKMTxfwETmXiEnq4Sxu31H83Az+mCIbP1yMUsMg89qSYid5ju FYuPwyH484mW00JtTx5OuqWpnTYMGlT7KVFqJehdxeONWZ6ufnHCzmyzVOH+1dvase J1MiCAvR1+TYJBvmEjxjcIxq385v88Jc+ZRllGrcEvOz6718VPM8F+kbQnMtzGTCyn Uw1zoA24xlTT9nuCyV9sumBZZAAnaVbMVGwHunxbwvpPMmSJ2FOd9Xa8xLwwKExOs6 gAf6Fs9vp6tTg== From: SeongJae Park To: Zi Yan Cc: SeongJae Park , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Kefeng Wang , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Ron Economos Subject: Re: [PATCH] mm/cma: move put_page_testzero() out of VM_WARN_ON in cma_release() Date: Tue, 24 Feb 2026 18:41:47 -0800 Message-ID: <20260225024148.63615-1-sj@kernel.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <88B98450-B0CE-476D-9E09-98DF6A1F6E3B@nvidia.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Tue, 24 Feb 2026 21:21:55 -0500 Zi Yan wrote: > On 24 Feb 2026, at 21:20, SeongJae Park wrote: > > > On Tue, 24 Feb 2026 18:18:44 -0800 SeongJae Park wrote: > > > >> On Tue, 24 Feb 2026 16:39:46 -0500 Zi Yan wrote: > >> > >>> When CONFIG_DEBUG_VM is not set, VM_WARN_ON is a NOP. Putting any statement > >>> with side effect inside it is incorrect. Move put_page_testzero() out and > >>> check its return value in VM_WARN_ON. Add __maybe_unused to the return > >>> value for when CONFIG_DEBUG_VM is not set. > >>> > >>> Fixes: 9bda131c6093 ("mm: cma: add cma_alloc_frozen{_compound}()") > >>> Reported-by: Ron Economos > >>> Closes: https://lore.kernel.org/all/1b17c38f-30d3-4bb4-a7e1-e74b19ada885@w6rz.net/ > > > > I forgot asking this, sorry. > > > > Should we Cc stable@ ? > > The commit is just in 7.0-rc1. Nothing is needed for stable. Ack. Thanks, SJ [...]