From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 23E392E0B58 for ; Wed, 25 Feb 2026 06:04:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771999447; cv=none; b=EQo+/st2XPgf8uVPWW82qIxhJuD4fqDd5LZH6DMCSZGk5PNKlkg9wbOEQ5sWMAim24+tthanIZgivrTu/kqkihIYycGcEXvf5CNdyizmjPGauwYhgxE4bhBx70Mm0WAMnVIx5RIou66URZnB+SPAdFxYnQDi0cJLaokv0ZEVMsI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771999447; c=relaxed/simple; bh=nbhYwnbiK4Jtvsyg3yIW+7Xkh+KbjuC+PUdKhUcCoNw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=p/By4+VCSW3qG3tu5YCe4ikkDMu2Aa2Xg7utkjTiCKdJu/9TJdSlzelvEztg/F4+GaPk/52vj7mgylIizlMuHEIxyCyAoMApdP8f8DpTYmnM0QiTCzgLQfn01wDs2JZYND4g70J6R5ER8GmSpPI/xQVCNB8LdqQdcyTo9YUKxpw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=bI5z4X/L; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=nY7C2VmD; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="bI5z4X/L"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="nY7C2VmD" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1771999445; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ijh1gRZ/vz98nkJ2ibune9S4XQ/SnjSEuxpGe+HaeR0=; b=bI5z4X/LZ7R06jnXYlItjvlG0TVOIkrDm7Xy9Mpt3VhmUBnMMI+jrxBCT+4rTInYE7bHei 4mmfAzZYps1kQrda/YtcVp3BgsrLnx+ZWEFEGHKLW6tSkz+PnBveDg9ZTynJEI8uZhPbK7 NEoDzfm613C8bvGVWL93v84Ke/xanRg= Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-447-oR8fCfdUPd-aj8-w9MWYPw-1; Wed, 25 Feb 2026 01:04:03 -0500 X-MC-Unique: oR8fCfdUPd-aj8-w9MWYPw-1 X-Mimecast-MFC-AGG-ID: oR8fCfdUPd-aj8-w9MWYPw_1771999442 Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2aad5fec176so10336005ad.2 for ; Tue, 24 Feb 2026 22:04:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1771999442; x=1772604242; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Ijh1gRZ/vz98nkJ2ibune9S4XQ/SnjSEuxpGe+HaeR0=; b=nY7C2VmDlzdrqeb4bd5jjM/fEmHEVabn0vM/WUaMm2lvjDTcRt6J9cvV5FpPqkUI0T WH455jKylJuYEdhZYoOgYnaC9UdBoCaXXBC4VE//zlsHnpxI1JbvVkmPJdq4Yi8yXgfr QU7lYwKTyotY5/wUicCs9EKpcxQtdHX/odp5oP8tg+TQg5unUzE6ZtqaQ79cJiEwqn1S 3OzjcYeMAMo9jh1qtAo5t0d17MRPw3eivLxs9j1fOYMZ05TAr9FG+osa1GGSmQjy0eOr uUlrmeniePhmwn47Xz2WxalVFFrepQXKIxVjbQaTbROMd5kw6ZFOYgQex6JinrirDKjb WPmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771999442; x=1772604242; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Ijh1gRZ/vz98nkJ2ibune9S4XQ/SnjSEuxpGe+HaeR0=; b=eQxiEKQSJUvnNJ21Wc5biDT21dZejurm46tDQJpiv6jTdsoUxkizwCXZVuUMN8AocQ nj+Ra33Yfiyz/mKPH55gd1CYeT/MHb7gLCnN4Rkzisw47HzWUxjjRqWMjrYrmkpo0Ud9 EkpR+G2TUnvLyNV5b/ViS9Pn7NJPOl9dYj6+3s48gtomYx2C0FNDe0FUbogtfR2HmU5N KtN63IAr+QxQxTQ+I+j/HilRBr/4DWMKVpWYVrurvwldwzJN6rnPmT8lDPxcuYJx8jOm xBiUD+rLcgLLy4onNOkuOuviDpGWVd7eEQGPv7RTZNZ3cThEUS7JsWGoXe5yUjmpq0p1 EXFg== X-Forwarded-Encrypted: i=1; AJvYcCWXV3YTrmDKUvPvOJwh/vVmpX7ugwQkbj0rktCzjuqcJhHdCQOFPiH3tv6vQtKOtZYI87D40kN5iq17x5U=@vger.kernel.org X-Gm-Message-State: AOJu0YzzApsrVX86MqDR02hLCtdbfuTA+ktkPUgjtWH0fDEBysuQJL+p 39Dr1D7D7ZyEiNDrjZOXk+/v6bz6ydgNNzhwq4R1JkpJVZDm2WeyRfhYGlk9YbhjmiAGYRLnVBd keTFwUQohkX77llFuRGFbaFgUhREvBCy4aDXV9Ntjiuch8y1qIkSikLnxeLStXLFckA== X-Gm-Gg: ATEYQzx2G06sx5HAu6O/mK4TuF1IRPTR9IBFL6gOzxtgmubyShtCoWJfJmlks8CsRRf wmxRDzNhX/d2dyJ/LL27x/duWKk6myecUX6Mc8v5qXEcAERsdCcT/Z64W5ToroIskmZxWyHWlrk GcoqFTk3TPKJ4nFLgarbY1gyFS5DblLNJ9LulGxEoosTvO1IJySomslHFQ5+h4OFnaP/7iOMgjk yqvgiMMCNnzwo/7bfVJjY5brYrALdUUeQRPpwGboThpOnoMu3l6utu7eVWOzWTzXaT7bUpyzC/l h9KYVAn+sQtvbR+OJ9PqIAGHiopDjOp3T/zSM/Zu4/vVNJTIBbkHjNPLnqk7E7j3buvoLsNjXEC s7RS1x6ZRvq12 X-Received: by 2002:a17:902:e787:b0:29b:e512:752e with SMTP id d9443c01a7336-2ad74556edbmr127353805ad.47.1771999442352; Tue, 24 Feb 2026 22:04:02 -0800 (PST) X-Received: by 2002:a17:902:e787:b0:29b:e512:752e with SMTP id d9443c01a7336-2ad74556edbmr127353515ad.47.1771999441818; Tue, 24 Feb 2026 22:04:01 -0800 (PST) Received: from localhost ([209.132.188.88]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ad74e3507csm127703285ad.8.2026.02.24.22.04.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Feb 2026 22:04:01 -0800 (PST) From: Coiby Xu To: kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org Cc: kernel test robot , Andrew Morton , Baoquan He , Vivek Goyal , Dave Young , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v5 2/3] crash: Align the declaration of crash_load_dm_crypt_keys with CONFIG_CRASH_DM_CRYPT Date: Wed, 25 Feb 2026 14:03:45 +0800 Message-ID: <20260225060347.718905-3-coxu@redhat.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260225060347.718905-1-coxu@redhat.com> References: <20260225060347.718905-1-coxu@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This will prevent a compiling failure when CONFIG_CRASH_DUMP is enabled but CONFIG_CRASH_DM_CRYPT is disabled, arch/powerpc/kexec/elf_64.c: In function 'elf64_load': >> arch/powerpc/kexec/elf_64.c:82:23: error: implicit declaration of function 'crash_load_dm_crypt_keys' [-Werror=implicit-function-declaration] 82 | ret = crash_load_dm_crypt_keys(image); | ^~~~~~~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202602120648.RgQALnnI-lkp@intel.com/ Signed-off-by: Coiby Xu --- include/linux/crash_core.h | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/include/linux/crash_core.h b/include/linux/crash_core.h index d35726d6a415..c1dee3f971a9 100644 --- a/include/linux/crash_core.h +++ b/include/linux/crash_core.h @@ -34,13 +34,6 @@ static inline void arch_kexec_protect_crashkres(void) { } static inline void arch_kexec_unprotect_crashkres(void) { } #endif -#ifdef CONFIG_CRASH_DM_CRYPT -int crash_load_dm_crypt_keys(struct kimage *image); -ssize_t dm_crypt_keys_read(char *buf, size_t count, u64 *ppos); -#else -static inline int crash_load_dm_crypt_keys(struct kimage *image) {return 0; } -#endif - #ifndef arch_crash_handle_hotplug_event static inline void arch_crash_handle_hotplug_event(struct kimage *image, void *arg) { } #endif @@ -96,4 +89,11 @@ static inline void crash_save_cpu(struct pt_regs *regs, int cpu) {}; static inline int kimage_crash_copy_vmcoreinfo(struct kimage *image) { return 0; }; #endif /* CONFIG_CRASH_DUMP*/ +#ifdef CONFIG_CRASH_DM_CRYPT +int crash_load_dm_crypt_keys(struct kimage *image); +ssize_t dm_crypt_keys_read(char *buf, size_t count, u64 *ppos); +#else +static inline int crash_load_dm_crypt_keys(struct kimage *image) {return 0; } +#endif + #endif /* LINUX_CRASH_CORE_H */ -- 2.53.0