From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 83EED2FCBF0; Wed, 25 Feb 2026 08:49:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772009398; cv=none; b=kHxwSort1hf6HYpq6A5+TIZ4eqlg87YtjR0aaSNoF7iZrs/S6MfRz2wTPlp0yd4wnq6Yq5qxTnH7xUAcW78AcfieLv2CiXOpghnhERc3eowiLRSPrzf3khVV49rkDgvmqCij/+KGMqrZ99G2YbXocFffBc5/vE48XcZLcLy2Mnk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772009398; c=relaxed/simple; bh=t0CSvy2V1vN07Nv5rVFVH6JCFFQHEcv+rViGBGNGM/c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kAwI1eqFvtnBpptg0O6kdn5k0FpGV74UxVwl7c+0JMMte9afL6Qpkt+cUXdCMKUbjhgwxUfMTK6V3JOEzVEZOKrG0Y1ZEhEyxIu5lH7h5HUEiVVgOQ16wqbyoKJPkkjK8Rt1Wfp3echXzTAmMr8WMPcPVm0SQCV0cEjtHsOn3Rs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C666F165C; Wed, 25 Feb 2026 00:49:50 -0800 (PST) Received: from e135073.nice.arm.com (e135073.arm.com [10.34.125.27]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id C4FC93F59E; Wed, 25 Feb 2026 00:49:53 -0800 (PST) From: Pierre Gondois To: linux-kernel@vger.kernel.org Cc: Jie Zhan , Lifeng Zheng , Ionela Voinescu , Sumit Gupta , Christian Loehle , Pierre Gondois , "Rafael J. Wysocki" , Viresh Kumar , Huang Rui , "Gautham R. Shenoy" , Mario Limonciello , Perry Yuan , Srinivas Pandruvada , Len Brown , Saravana Kannan , linux-pm@vger.kernel.org Subject: [PATCH v5 2/6] cpufreq: Add boost_freq_req QoS request Date: Wed, 25 Feb 2026 09:49:19 +0100 Message-ID: <20260225084930.1692228-3-pierre.gondois@arm.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260225084930.1692228-1-pierre.gondois@arm.com> References: <20260225084930.1692228-1-pierre.gondois@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The Power Management Quality of Service (PM QoS) allows to aggregate constraints from multiple entities. It is currently used to manage the min/max frequency of a given policy. Frequency constraints can come for instance from: - Thermal framework: acpi_thermal_cpufreq_init() - Firmware: _PPC objects: acpi_processor_ppc_init() - User: by setting policyX/scaling_[min|max]_freq The minimum of the max frequency constraints is used to compute the resulting maximum allowed frequency. When enabling boost frequencies, the same frequency request object (policy->max_freq_req) as to handle requests from users is used. As a result, when setting: - scaling_max_freq - boost The last sysfs file used overwrites the request from the other sysfs file. To avoid this, create a per-policy boost_freq_req to save the boost constraints instead of overwriting the last scaling_max_freq constraint. Signed-off-by: Pierre Gondois --- drivers/cpufreq/cpufreq.c | 37 ++++++++++++++++++++++++++++++++----- include/linux/cpufreq.h | 1 + 2 files changed, 33 insertions(+), 5 deletions(-) diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c index db414c052658b..50467b938668a 100644 --- a/drivers/cpufreq/cpufreq.c +++ b/drivers/cpufreq/cpufreq.c @@ -1359,17 +1359,21 @@ static void cpufreq_policy_free(struct cpufreq_policy *policy) /* Cancel any pending policy->update work before freeing the policy. */ cancel_work_sync(&policy->update); - if (policy->max_freq_req) { + if ((policy->max_freq_req && !policy->boost_supported) || + policy->boost_freq_req) { /* - * Remove max_freq_req after sending CPUFREQ_REMOVE_POLICY - * notification, since CPUFREQ_CREATE_POLICY notification was - * sent after adding max_freq_req earlier. + * Remove max/boost _freq_req after sending CPUFREQ_REMOVE_POLICY + * notification, since CPUFREQ_CREATE_POLICY notification was sent + * after adding max/boost _freq_req earlier. */ blocking_notifier_call_chain(&cpufreq_policy_notifier_list, CPUFREQ_REMOVE_POLICY, policy); - freq_qos_remove_request(policy->max_freq_req); } + freq_qos_remove_request(policy->boost_freq_req); + kfree(policy->boost_freq_req); + + freq_qos_remove_request(policy->max_freq_req); freq_qos_remove_request(policy->min_freq_req); kfree(policy->min_freq_req); @@ -1479,6 +1483,29 @@ static int cpufreq_policy_online(struct cpufreq_policy *policy, goto out_destroy_policy; } + if (policy->boost_supported) { + policy->boost_freq_req = kzalloc(sizeof(*policy->boost_freq_req), + GFP_KERNEL); + if (!policy->boost_freq_req) { + ret = -ENOMEM; + goto out_destroy_policy; + } + + ret = freq_qos_add_request(&policy->constraints, + policy->boost_freq_req, + FREQ_QOS_MAX, + FREQ_QOS_MAX_DEFAULT_VALUE); + if (ret < 0) { + /* + * So we don't call freq_qos_remove_request() for an + * uninitialized request. + */ + kfree(policy->boost_freq_req); + policy->boost_freq_req = NULL; + goto out_destroy_policy; + } + } + blocking_notifier_call_chain(&cpufreq_policy_notifier_list, CPUFREQ_CREATE_POLICY, policy); } diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h index 0465d1e6f72ac..c292a6a19e4f5 100644 --- a/include/linux/cpufreq.h +++ b/include/linux/cpufreq.h @@ -81,6 +81,7 @@ struct cpufreq_policy { struct freq_constraints constraints; struct freq_qos_request *min_freq_req; struct freq_qos_request *max_freq_req; + struct freq_qos_request *boost_freq_req; struct cpufreq_frequency_table *freq_table; enum cpufreq_table_sorting freq_table_sorted; -- 2.43.0