From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 935592BE644 for ; Wed, 25 Feb 2026 18:39:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772044743; cv=none; b=ghBUfbt5JIUTwyiB1rR3BN7Mc+eiN1yqltg/Fb8OiXgt6nCQJze1PBA3Y/kjed0o6S8loAPrfkI5BdZIi2Jmt+bpPu/yEDAPnxhsd1h5SAbNr2H15Wc9RDHI0hSeB29etJFxt9s7gC3wVzy7cGZxse1rxUZy3CNE92vwJMJKDSg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772044743; c=relaxed/simple; bh=rwxeENQsbEUQ3j4ryDf25T3JEjJYOz7vfeMcUpf8YGo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=dYDgMVlo3Yaaam1kXWGK92GbK2vhHEQZ0qvzRkgbjM7lfj1PjKRW02gY/p73Pmlq5R4cTrRyG/h5yAsIEq2juQzIIUvkQelb2v0AG0XbGO0wO7fHH4TGYWApE05p1G0tghjJvYIPqUuTan8/GSyrbL+pMAWEPDkHR09qKFRg180= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LT7Zw3ED; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LT7Zw3ED" Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-824ba8f0acaso29390b3a.1 for ; Wed, 25 Feb 2026 10:39:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772044741; x=1772649541; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=4HRybFjotBo7xCavdJbzXBhAVjefd7vNccK+edsdN5M=; b=LT7Zw3EDIS8EyONWFPZuDnnW8LZntiuipY4p+BM0JrXNlw/noJR0F87vfsv8X4/ZJE Y+KDpHkalYYW/HxOpyC7s8bKVkovRK0e7EUMDxSAnDCqwscINrtlIBgvi/vnJtq6AWBt Gdw24Vge9cQBWWvGuENRg+q5Un7Ef3RK+UKVgSuLxzQnGAZwPBqiLDPQ8HpSfK5QkP4K uWt4jCC6qwVRxjy9TtnmpMQEv/wAUmsrG6uCcPMZtPA1SRYmGkLfIIV7y80LBxVtN3Tm Gn2SJ76fVD7RY7XgmuOHIsgOcAcZZ1DwdmRGoJnf3rcLfgxGMK9+ssutpY0IZ5ckHexi m0jA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772044741; x=1772649541; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4HRybFjotBo7xCavdJbzXBhAVjefd7vNccK+edsdN5M=; b=dNAThCO7B1IgG3SCyGPblaMXPnyvXZCEQIpAWWyJvYDuaHC1ocYkqE42nFiyXBO8oK EotTVQVxYqcSDvs9nvnyz/bgkskfMQtX/nd6uEg+1txn/PJtf0QhS5vWZdLVbB1UPNAx 9uCDkjr+gjBxjgOF7xmGHBNqNC2os359YDdmGjuxH9E9Z98x0aINNXRS6fQMezAhEApC sZYtpHD51/OpMtq1HyBgGtFpVEVKz560qRB7nNJXGbp4PWWUfd8yQKAMRsBrx9GNNe6N TZ8Mh7Yb8Q1n1sFbWKCX9OuL5X8xHLpc8REgNTzlrQGr5rDLCGLCXS62Mql05NRYaDee LLqw== X-Forwarded-Encrypted: i=1; AJvYcCXYc8CqwQ7HZUxDzB3kQG01jq/NQpGNA7HpJj3iwcELF7XfRU/9RQGkE6KXu4liSuQjLI155feB9FU34eA=@vger.kernel.org X-Gm-Message-State: AOJu0Yxib45onr30QgatWqlyUOiH4wTMoDxeNpKJ924fYYDbhvEvqr1m TJ8UmRF0AKr3vd/cSF+1IaT/Dj31ras8kLyEDE0iR7Ab7zJRTzws1NUItyTf1sKXrmw= X-Gm-Gg: ATEYQzzg5KbULRZBmA3CrxmId5c+Wsd1iXjPCVgEJMj7JTWFGbpmp8pC97zFf7Vq3y1 WdN5jn0dvX0HkChW8JU0OgShv+4z/ayq+3Pbz+QGo6QWfKkg1DX95da+6Y7Rnfa+Os/dgkLfHSL HH8pSF5Pw/lLAb/3RPHM0iWWjJD0JDvqYobEkHzAJFbQGLy4wk0F2LeEnSv+QgvEwKav3d+8BaS Q0GmBWD9F77DDg/T8jxL8ecB9/1ujdMsQf+RiqMO7Vo3tq6MIysQ7YGExb8csUAaL9WgFHwgNnN ov3xR8nDzVnPVBBh5IqC/raGX1/IgFCQAy8DABz54iBLPwPIhisN5QTL3tWw7efdnGVLqkxxors TS3Uj0OtcNKpSPL02fr+WcjzhPYlGt2qHeqU2vHcDquZvpotipbIvPNKN0f1q4FgK3I0EBsoo1d AN+4U/gjYUyUsPm+oTGXak+3bTYKZVSDWPmBE= X-Received: by 2002:a05:6a21:9d48:b0:35d:d477:a7f3 with SMTP id adf61e73a8af0-39545ed2be5mr14317467637.20.1772044740790; Wed, 25 Feb 2026 10:39:00 -0800 (PST) Received: from fedora ([2409:40e5:105a:d068:a95a:8654:94eb:1089]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c70b724321esm14010380a12.16.2026.02.25.10.38.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Feb 2026 10:39:00 -0800 (PST) From: Shubham Chakraborty To: David Lin , Johan Hovold , Alex Elder , Greg Kroah-Hartman Cc: greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Shubham Chakraborty Subject: [PATCH 1/2] staging: greybus: uart: fix style issues Date: Thu, 26 Feb 2026 00:08:35 +0530 Message-ID: <20260225183836.20434-1-chakrabortyshubham66@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Fix checkpatch.pl warnings by adding comments to mutex and spinlocks, and fixing alignment to match open parenthesis. Signed-off-by: Shubham Chakraborty --- drivers/staging/greybus/uart.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/greybus/uart.c b/drivers/staging/greybus/uart.c index 7d060b4cd33d..1d2c4ef70865 100644 --- a/drivers/staging/greybus/uart.c +++ b/drivers/staging/greybus/uart.c @@ -50,12 +50,12 @@ struct gb_tty { unsigned int minor; unsigned char clocal; bool disconnected; - spinlock_t read_lock; - spinlock_t write_lock; + spinlock_t read_lock; /* protects read operations */ + spinlock_t write_lock; /* protects write operations */ struct async_icount iocount; struct async_icount oldcount; wait_queue_head_t wioctl; - struct mutex mutex; + struct mutex mutex; /* serializes port operations */ u8 ctrlin; /* input control lines */ u8 ctrlout; /* output control lines */ struct gb_uart_set_line_coding_request line_coding; @@ -318,7 +318,7 @@ static int gb_uart_wait_for_all_credits(struct gb_tty *gb_tty) return 0; ret = wait_for_completion_timeout(&gb_tty->credits_complete, - msecs_to_jiffies(GB_UART_CREDIT_WAIT_TIMEOUT_MSEC)); + msecs_to_jiffies(GB_UART_CREDIT_WAIT_TIMEOUT_MSEC)); if (!ret) { dev_err(&gb_tty->gbphy_dev->dev, "time out waiting for credits\n"); -- 2.53.0