From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A99FB2EC0AE for ; Wed, 25 Feb 2026 18:40:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772044847; cv=none; b=gpiVBlh1JRBL88/c7EUV+EGGejilqMlc2R4N310yY6s4XPSBRXoamVXEXacUMqKZr0qfT8mO3+R7w51JY2IZnhNuMSwqmbqoVi01mM9UbQlo+4G7PpfZpf8h/ntO/krAcScboPRqJ7OvXP/KLl+ii5B6F0pk31AIcyG8aw6w9lU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772044847; c=relaxed/simple; bh=Ta0YbASn1qZAbcPSQuAwHJNVzIkYSAUPG7JIA/lS+SI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lQBNbLump8aKBcU/7g4fV3Swyu9vEWYlhB/6Ol6HCJHkLh2fmxkE4R7xMYnhweEAz3SObBRreuL5ktjSsE4nldL2OPUPXM38QRPp6ugIDUWHSAm6KhZ/G6E4kLAr6lBi69MngUrH7/0+MXsHZf2lHEzvtnnmeGt1qSAZl8Oxz+s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OjFLW/9K; arc=none smtp.client-ip=209.85.210.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OjFLW/9K" Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-8249fc726e9so41380b3a.2 for ; Wed, 25 Feb 2026 10:40:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772044846; x=1772649646; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wKtDVfmPVgPIEBZ9rN4VgM/NHjO9Hae2x87Y+mFQu+Q=; b=OjFLW/9Kfj7YmDHDHbd8gB8z0NMXwM0Z13hvGkbljKW/evEuFcnpccq7daFV22LYAO HHcPOh68Mu9d5xvT4ZXkZCGSbov78+i0yd1Re66o/7KTm+p+yY3PyLm4O3usWgnqoLrm t6Ssmrt23LSb08X+7iBO91pYctvWgtdq5cF0C6gYFcRX08vJxlLBURU9dMGGmGoxywDQ lcCtpWmkGINcNCwXzazZrKWzGwFjE1mZ/Mq3yyy3F04vI8AcpVh0XQjoEvx+lyCuML4V TT7H8J0qgL9ZyDXQp7p71b4+Zgs+19XglNHTpKydRS2r53GG5Zv8UweAShI/lpin/w+I 857g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772044846; x=1772649646; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=wKtDVfmPVgPIEBZ9rN4VgM/NHjO9Hae2x87Y+mFQu+Q=; b=OV1UDQJO7OocRQkPSvnPVE0JzbueOJDTYW9TFq+Oz4JHmClSA7ugSEoqBeqkuKBMHr 23u8tTVALt0RbIX9WRJd7eKzhP56GwS2FtmhkjpxQ459sjMZgY77Lx1ZG/i6hhMTg0qN IDJtF6pFNesc9w3BCQGz6pjSvryL25/NAQ5lDalpnRA1T7I5y3YZ766K97+HDSeUfzIT i2jEX4gWAmVepMHBE61jHzc6Rqb2WAxy3EbVzF1iN5ZzEJQn3ML8PeDyhxHNeHZalM8B Hhnl/eXCYMZLBjsA6GxutseR00Vjphcph1tgVjvzLLBroerdNzos17Vl6CgLeiwzZF1M Kp+A== X-Forwarded-Encrypted: i=1; AJvYcCVTAdICwAM+i38RJIItGJjjZ3OWVK5p4MJoYgqmofl30RFMHjUV6KGWxn+TU6VQP6WdunwQqhgWhFSHCcU=@vger.kernel.org X-Gm-Message-State: AOJu0Yzxye4+oPCIBdKG8ZsT01bqZ85/ebohex2YWc+B9JR/f3cqxgsn SYUM+yIkaAiu/s27gvfBfRdmnEkcFYe/NrZ3duKhqku0cVSjXNxJXusN X-Gm-Gg: ATEYQzy28ZkjYXeHjebgNJYar3IruDVjaMD/vAwb83hdV6OU75L/dOzAAVquOWZHZfv 0kx3+6JqXdKR+Lq1ZzYUfRmCulno8QOgoJYn22Xj/bmAc7DIe5u0gvE7Nw1ZpPULtOQ6v33jGhg O/q6zbHoW4GBDEkZ3ShQ5aVjlfsjKhPUMUTL+4IUwgfkevTbwpUdnNNHsIA0hBv0AoQJKcKgvKC eR7m1NaAdoF+1a3REGtRKCP9O1wM/lwE6yS/7JumazHAiCa2Hdf93KP54BOH8GraEOABR2ZCAoz 8JpGzCNSzMjzKAEMFVaXSjYO8i2BxUqDS+PE9y75ukd6xTW3wp33j7Q0qSC4AgjMQR9kkrYS+38 jowW0WrAwK2P/mLwlx2IupEPfbSkGur1i+VtLDYcVZQ6f9/1f/BitvmGSdbw0+dDB9hrk78zs3R 3ncadnapYIqe2+sRET/2/iq+YCngXmJ61mB7Y= X-Received: by 2002:a05:6a21:610c:b0:395:151c:4ed5 with SMTP id adf61e73a8af0-395ad1ad008mr1109867637.37.1772044845950; Wed, 25 Feb 2026 10:40:45 -0800 (PST) Received: from fedora ([2409:40e5:105a:d068:a95a:8654:94eb:1089]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c70b724321esm14010380a12.16.2026.02.25.10.40.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Feb 2026 10:40:45 -0800 (PST) From: Shubham Chakraborty To: David Lin , Johan Hovold , Alex Elder , Greg Kroah-Hartman Cc: greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Shubham Chakraborty Subject: [PATCH 2/2] staging: greybus: uart: convert to XArray Date: Thu, 26 Feb 2026 00:08:36 +0530 Message-ID: <20260225183836.20434-2-chakrabortyshubham66@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260225183836.20434-1-chakrabortyshubham66@gmail.com> References: <20260225183836.20434-1-chakrabortyshubham66@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace the deprecated IDR API with the more modern XArray API. This simplifies the code and improves efficiency. Signed-off-by: Shubham Chakraborty --- drivers/staging/greybus/uart.c | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/drivers/staging/greybus/uart.c b/drivers/staging/greybus/uart.c index 1d2c4ef70865..fe554eba555a 100644 --- a/drivers/staging/greybus/uart.c +++ b/drivers/staging/greybus/uart.c @@ -67,7 +67,7 @@ struct gb_tty { }; static struct tty_driver *gb_tty_driver; -static DEFINE_IDR(tty_minors); +static DEFINE_XARRAY(tty_minors); static DEFINE_MUTEX(table_lock); static int gb_uart_receive_data_handler(struct gb_operation *op) @@ -342,7 +342,7 @@ static struct gb_tty *get_gb_by_minor(unsigned int minor) struct gb_tty *gb_tty; mutex_lock(&table_lock); - gb_tty = idr_find(&tty_minors, minor); + gb_tty = xa_load(&tty_minors, minor); if (gb_tty) { mutex_lock(&gb_tty->mutex); if (gb_tty->disconnected) { @@ -359,14 +359,18 @@ static struct gb_tty *get_gb_by_minor(unsigned int minor) static int alloc_minor(struct gb_tty *gb_tty) { - int minor; + u32 minor; + int ret; mutex_lock(&table_lock); - minor = idr_alloc(&tty_minors, gb_tty, 0, GB_NUM_MINORS, GFP_KERNEL); + ret = xa_alloc(&tty_minors, &minor, gb_tty, + XA_LIMIT(0, GB_NUM_MINORS - 1), GFP_KERNEL); mutex_unlock(&table_lock); - if (minor >= 0) + if (ret >= 0) { gb_tty->minor = minor; - return minor; + return minor; + } + return ret; } static void release_minor(struct gb_tty *gb_tty) @@ -375,7 +379,7 @@ static void release_minor(struct gb_tty *gb_tty) gb_tty->minor = 0; /* Maybe should use an invalid value instead */ mutex_lock(&table_lock); - idr_remove(&tty_minors, minor); + xa_erase(&tty_minors, minor); mutex_unlock(&table_lock); } @@ -984,7 +988,7 @@ static void gb_tty_exit(void) { tty_unregister_driver(gb_tty_driver); tty_driver_kref_put(gb_tty_driver); - idr_destroy(&tty_minors); + xa_destroy(&tty_minors); } static const struct gbphy_device_id gb_uart_id_table[] = { -- 2.53.0