From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A052C3921E6 for ; Thu, 26 Feb 2026 08:52:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772095943; cv=none; b=jn15xefCKtvZt4QhK9w0Abn49j0cXGI5G1vs2gk2JKG4KgXWy4jis642unMd3kONKed3T3ZlDMvJ/i4hSSHT9Nfdz91DOydM7uZ2YS4YBDJId9u1KGBGYeFa1vqbeWb3diJSHlQ9BqZ8uQEZIB/FEvq/o4lWdRvsbTQPewlZslY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772095943; c=relaxed/simple; bh=/QP/ifJFBVBr5gtAkpDepNA418WX/ZbmVBZRLYhC1Jg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=goZyqEYrQ97zsM+EBcBDuaolGzoS4Mkmk9aps9p4wmwNFp2anr9zLXPV+qzCCzDFpgTGZupAySP4ra08PJFtXc/njJpPayRBdVcGUVhZ5xM4ajehhsNM+0M1ZTEvuYbZRYBq0Ou2CnHvfiTsFiniu4OHhoMW2+KwpO20YTEc5hc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=CBNos0PM; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="CBNos0PM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6C776C19422; Thu, 26 Feb 2026 08:52:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772095943; bh=/QP/ifJFBVBr5gtAkpDepNA418WX/ZbmVBZRLYhC1Jg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CBNos0PMs0bQ3OcawkwD3VT+nkeHCrlfX7VuxrMfuOI5dT1rmtAC7D5jEGOocvmFJ BhE6vYXh6py4wkthaDRZEoie3OLQKZeYe7F2p6czow1yw4gom/hOQStCL/3/pZZNQA 3LfiVteH3m25NuEYEH56ewlIeBeZOrpNX2lFsnPBmcNnn8a1XXVIREWpMAYDpFXA9N tbo6q/h7hyvKAd6vB+ZISfJSjIj7kRo2bcCHIQg8zoM9xQKnUxSYRk+zki/x4R94mF H6m7gwLN0Mf+VQEaGVgNB4Uh15jglEOz/BwDjuiVflCL4LeSoWkFULn7sfjYoT2eWn yog6tiAws8aVw== Date: Thu, 26 Feb 2026 08:52:19 +0000 From: Conor Dooley To: Himanshu Chauhan Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, pjw@kernel.org, palmer@dabbelt.com, aou@eecs.berkeley.edu, alex@ghiti.fr, shuah@kernel.org Subject: Re: [PATCH v3 1/2] riscv: Introduce support for hardware break/watchpoints Message-ID: <20260226-lagging-showplace-5931d23fe69a@spud> References: <20260223044918.1359983-1-himanshu.chauhan@oss.qualcomm.com> <20260223044918.1359983-2-himanshu.chauhan@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="s+XNTX+MEfdZnmZG" Content-Disposition: inline In-Reply-To: <20260223044918.1359983-2-himanshu.chauhan@oss.qualcomm.com> --s+XNTX+MEfdZnmZG Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Feb 23, 2026 at 10:19:17AM +0530, Himanshu Chauhan wrote: > +static int rv_init_mcontrol_trigger(const struct perf_event_attr *attr, > +static int rv_init_mcontrol6_trigger(const struct perf_event_attr *attr, Another minor thing in passing, can you do s/rv/riscv/ here? rv is actual subsystem and riscv arch code is almost exclusively using riscv as a prefix. Cheers, Conor. --s+XNTX+MEfdZnmZG Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCaaAJwwAKCRB4tDGHoIJi 0gWpAP0W/THm8GnjU1SKWk5Z8tBo0z/SDG+Dt67x4kVg/6GsnwEAyaGHS/5zq+ux XnpMXWRkLdrIDduRQnb68tV5f/sa5Ac= =iYLY -----END PGP SIGNATURE----- --s+XNTX+MEfdZnmZG--