From: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
To: Zeeshan Ahmad <zeeshanahmad022019@gmail.com>
Cc: Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Dan Carpenter <dan.carpenter@linaro.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] usb: dwc3: qcom: simplify error check in dwc3_qcom_find_num_ports()
Date: Thu, 26 Feb 2026 02:14:32 +0000 [thread overview]
Message-ID: <20260226021427.xoy2euyaqox7c43h@synopsys.com> (raw)
In-Reply-To: <20260225065157.8952-1-zeeshanahmad022019@gmail.com>
On Wed, Feb 25, 2026, Zeeshan Ahmad wrote:
> The platform_get_irq_byname_optional() function returns a non-zero
> IRQ number on success and a negative error code on failure. It
> never returns zero.
>
> The current implementation in the modern dwc3-qcom driver checks for
> a return value less than or equal to zero. Since zero is not a
> valid return value, simplify the check to only look for negative
> error codes. This aligns the logic with the standard return contract
> of the platform IRQ APIs.
>
> Signed-off-by: Zeeshan Ahmad <zeeshanahmad022019@gmail.com>
> ---
> v3:
> - Fix missing version changelog in the v2 submission.
> v2:
> - Targeted the modern dwc3-qcom.c driver instead of the legacy one
> as suggested by Thinh Nguyen.
> - Audited the modern driver to confirm the same redundant error
> check exists there.
> - Updated the commit message to specifically mention the modern
> dwc3-qcom driver.
>
> drivers/usb/dwc3/dwc3-qcom.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c
> index 9ac75547820d..f43f73ac36ff 100644
> --- a/drivers/usb/dwc3/dwc3-qcom.c
> +++ b/drivers/usb/dwc3/dwc3-qcom.c
> @@ -526,14 +526,14 @@ static int dwc3_qcom_find_num_ports(struct platform_device *pdev)
> int irq;
>
> irq = platform_get_irq_byname_optional(pdev, "dp_hs_phy_1");
> - if (irq <= 0)
> + if (irq < 0)
> return 1;
>
> for (port_num = 2; port_num <= DWC3_QCOM_MAX_PORTS; port_num++) {
> sprintf(irq_name, "dp_hs_phy_%d", port_num);
>
> irq = platform_get_irq_byname_optional(pdev, irq_name);
> - if (irq <= 0)
> + if (irq < 0)
> return port_num - 1;
> }
>
> --
> 2.43.0
>
Acked-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
BR,
Thinh
prev parent reply other threads:[~2026-02-26 2:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-18 11:01 [PATCH] " Zeeshan Ahmad
2026-02-19 22:55 ` Thinh Nguyen
2026-02-20 8:15 ` Dan Carpenter
2026-02-21 10:41 ` Zeeshan Ahmad
2026-02-24 0:41 ` Thinh Nguyen
2026-02-24 6:44 ` Zeeshan Ahmad
2026-02-25 0:10 ` Thinh Nguyen
2026-02-25 6:42 ` [PATCH v2] " Zeeshan Ahmad
2026-02-25 6:51 ` [PATCH v3] " Zeeshan Ahmad
2026-02-26 2:14 ` Thinh Nguyen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260226021427.xoy2euyaqox7c43h@synopsys.com \
--to=thinh.nguyen@synopsys.com \
--cc=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=zeeshanahmad022019@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®