From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f228.google.com (mail-yw1-f228.google.com [209.85.128.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92586392813 for ; Thu, 26 Feb 2026 08:34:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.228 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772094844; cv=none; b=aj4IVOQXbpXirOgnyRMBrcPgb5o1CsqXLN0ki0gbSVl2ZwAaD2PoCypVbYvTyox6yZ6uEONb0wKAILwARVtMOngbg1EMtJrXb1bz+WHGv6ojFBL6ktQqmgoradMywto52HPc2jYZVy4hP9oaKThTiSE9RNV/cn0ETCn5cHvCj7c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772094844; c=relaxed/simple; bh=PN0vtQNFjFQuxfFGZCUfaC2nXnFaOhQ0eX4/W+A8K5U=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=NkvHADJ/GQf9uZrvzzW/dCmEq12GPaAs4dSa11QapiEyB9Mqor3K8Vyk02+4P5aDNO195kHs8NX5c6NaNDxPWdnHpLHYEgmash0b2vlzmcLCTk+p5P4zgbB3NJkLieXzwsobKz//FerWvkcqhvo5ojEkfdsw/vTtOFqy+aIvmbQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=CRzGKI28; arc=none smtp.client-ip=209.85.128.228 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="CRzGKI28" Received: by mail-yw1-f228.google.com with SMTP id 00721157ae682-7986e538decso4316947b3.1 for ; Thu, 26 Feb 2026 00:34:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772094842; x=1772699642; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hip7uX5emMqIAF3MBqMOQQe9Pkpj0KxYKUF9OZQ2RqI=; b=liu1/AqbFmU4GDPj9Mv784qDco1GVCpf72H/QPr4FF12/zSIJzJKZjcxtgDCpaapIy 3bKaEQ4ZvMjh6yP9ImQIKp4QuLRcmNwitVHPzR00GJ//ulLIc+o86vvUo6GY4TjqW8kw GCVLypAnPvCBIALPgIbE2ScKbayTt1K0RTk/Ry7JyqkiKaju5OugUlW9Lx6LHhceOuta fiq0HQK99R/pjkNCad5CT4YMleMqrd4RNZP5e9qcHF3qSPi6kmkAv6WlxOwyBo7CD5uq RRI/gZ+w1zMLHKeJVxgWTbu1u/pHSxL+fpaj24bJ2JicUjjzlD4lX/A+aRQ581FZny/m 2h+Q== X-Gm-Message-State: AOJu0YyoI7U1x7W87EPV0ikSyw9xCvphFVNkBDh575Xfbzh+oDkvDoto Ea6sDa5qDMp8xkCww+hV/RvT85mIIkWmHFO8DnWMz2ZJYUmFLXyRAuVbZB0J5DuBYaovASLbRqr VkvMZHXpczzvC1CloEcqTMCYPr1Pw3/a5z4OGmkgDqbE699YvPXFgg+P7bWax8RPbdo6OGN5xuV it5w32KC6bbtO4ibeZ1Zm5+bryRwyv1vo1sOvU7c+N64XT0Bs3Tp30YQL+Po+jjx3/vBelPtjPY UMivqeI8y6O7/o1+Bqt4A== X-Gm-Gg: ATEYQzylQbtP3WK8cY+0HyF4P8ASled/gS6ftzDGwttVKMHScqP6p8GoRheVVgSWXAV vqATcmnCqs2hbRMA/TaxrhsZSKPueRMCpw52X/clz25Qh4ctxIJFqWBM6DZXdZ7dOadbWBzb/Bq 10rO3H9Dq+XFAIHxNUhK4G48/1C7dE21eaLx0ssCr0cSHg99H93DD4fZ5Fm8/eR6KwSiaf2TSD7 GvDDdE7yw1QU+6DyWVKzmcES9zhasiPwzBqfci2I8RkwpSr5pCSReEKNQV2ZTuYkHn/j8lLRsG5 yXGMbfE7tZrob5P0RLYWnTPE0Gu+zDXe4xe7tov6SYArUQi1HKWLG6RRYLFHxl61iVlAhOA+Rk2 +iXKrxAbE90SEhFitVcOKtYUy5QDzBMJhX+2nYpGhcMQSjDhQh1vXSG8T4uDx5oGn/4Dz/E+M62 M+R0zHI47FzNSen6PzoYRkeHgPqukOoNwtykYsjCN+iWhNlofOMW2be0V1 X-Received: by 2002:a05:690c:f03:b0:796:6784:82cb with SMTP id 00721157ae682-7986fc9b102mr32127047b3.2.1772094842147; Thu, 26 Feb 2026 00:34:02 -0800 (PST) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-95.dlp.protect.broadcom.com. [144.49.247.95]) by smtp-relay.gmail.com with ESMTPS id 00721157ae682-79876c8295dsm1552737b3.27.2026.02.26.00.34.01 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 26 Feb 2026 00:34:02 -0800 (PST) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-8273e7824e4so422612b3a.1 for ; Thu, 26 Feb 2026 00:34:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1772094840; x=1772699640; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hip7uX5emMqIAF3MBqMOQQe9Pkpj0KxYKUF9OZQ2RqI=; b=CRzGKI28KCqRbeRsxgK98420ZmokdsOInPhbU6MJrT8bTPNuukmZCrGCPDVNYyoqpQ 2VgbdmgVZtRTFFlYcP/o5DuUr2WfPbYMuskMc0ZHpG8k11yiGkpocgpu0rraV6YxES2I yPBK+aZP63MAA6cyvfV2L1WQ+xju5Xjb9nguk= X-Received: by 2002:a05:6a00:1791:b0:827:2995:3ba0 with SMTP id d2e1a72fcca58-827337843eamr2807501b3a.32.1772094840489; Thu, 26 Feb 2026 00:34:00 -0800 (PST) X-Received: by 2002:a05:6a00:1791:b0:827:2995:3ba0 with SMTP id d2e1a72fcca58-827337843eamr2807483b3a.32.1772094840006; Thu, 26 Feb 2026 00:34:00 -0800 (PST) Received: from PC-MID-R740.dhcp.broadcom.net ([192.19.234.250]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82739d4c9b5sm1661613b3a.9.2026.02.26.00.33.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Feb 2026 00:33:59 -0800 (PST) From: Pavan Chebbi To: jgg@ziepe.ca, michael.chan@broadcom.com Cc: linux-kernel@vger.kernel.org, dave.jiang@intel.com, saeedm@nvidia.com, Jonathan.Cameron@huawei.com, gospo@broadcom.com, selvin.xavier@broadcom.com, leon@kernel.org, kalesh-anakkur.purayil@broadcom.com, Pavan Chebbi , Leon Romanovsky Subject: [PATCH v5 fwctl 3/5] fwctl/bnxt_en: Create an aux device for fwctl Date: Thu, 26 Feb 2026 00:23:16 -0800 Message-Id: <20260226082318.525518-4-pavan.chebbi@broadcom.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20260226082318.525518-1-pavan.chebbi@broadcom.com> References: <20260226082318.525518-1-pavan.chebbi@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Create an additional auxiliary device to support fwctl. The next patch will create bnxt_fwctl and bind to this device. Reviewed-by: Andy Gospodarek Reviewed-by: Leon Romanovsky Signed-off-by: Pavan Chebbi --- drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c | 12 ++++++++++-- include/linux/bnxt/ulp.h | 1 + 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c index d05a1c62fd0b..9eaf01177efb 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c @@ -50,6 +50,8 @@ static bool bnxt_auxdev_is_active(struct bnxt *bp, int idx) static struct bnxt_aux_device bnxt_aux_devices[__BNXT_AUXDEV_MAX] = {{ .name = "rdma", +}, { + .name = "fwctl", }}; static void bnxt_fill_msix_vecs(struct bnxt *bp, struct bnxt_msix_entry *ent) @@ -278,6 +280,11 @@ void bnxt_ulp_stop(struct bnxt *bp) aux_priv = bp->aux_priv[i]; edev = bp->edev[i]; mutex_lock(&edev->en_dev_lock); + if (i == BNXT_AUXDEV_FWCTL) { + edev->flags |= BNXT_EN_FLAG_ULP_STOPPED; + mutex_unlock(&edev->en_dev_lock); + continue; + } if (!bnxt_ulp_registered(edev) || (edev->flags & BNXT_EN_FLAG_ULP_STOPPED)) { mutex_unlock(&edev->en_dev_lock); @@ -316,7 +323,7 @@ void bnxt_ulp_start(struct bnxt *bp) aux_priv = bp->aux_priv[i]; edev = bp->edev[i]; mutex_lock(&edev->en_dev_lock); - if (!bnxt_ulp_registered(edev) || + if (i == BNXT_AUXDEV_FWCTL || !bnxt_ulp_registered(edev) || !(edev->flags & BNXT_EN_FLAG_ULP_STOPPED)) { goto clear_flag_continue; } @@ -521,7 +528,8 @@ void bnxt_aux_devices_add(struct bnxt *bp) aux_dev = &bp->aux_priv[idx]->aux_dev; rc = auxiliary_device_add(aux_dev); if (rc) { - netdev_warn(bp->dev, "Failed to add auxiliary device for ROCE\n"); + netdev_warn(bp->dev, "Failed to add auxiliary device for auxdev type %d\n", + idx); auxiliary_device_uninit(aux_dev); if (idx == BNXT_AUXDEV_RDMA) bp->flags &= ~BNXT_FLAG_ROCE_CAP; diff --git a/include/linux/bnxt/ulp.h b/include/linux/bnxt/ulp.h index 1a4643c46f86..0851ad3394b0 100644 --- a/include/linux/bnxt/ulp.h +++ b/include/linux/bnxt/ulp.h @@ -24,6 +24,7 @@ struct bnxt; enum bnxt_auxdev_type { BNXT_AUXDEV_RDMA = 0, + BNXT_AUXDEV_FWCTL, __BNXT_AUXDEV_MAX }; -- 2.39.1