mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Koichiro Den <den@valinux.co.jp>
To: Manivannan Sadhasivam <mani@kernel.org>,
	Frank Li <Frank.Li@nxp.com>, Jon Mason <jdmason@kudzu.us>,
	Dave Jiang <dave.jiang@intel.com>,
	Allen Hubbe <allenbh@gmail.com>,
	kwilczynski@kernel.org,
	Kishon Vijay Abraham I <kishon@kernel.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Ye Bin <yebin10@huawei.com>,
	Lorenzo Pieralisi <lpieralisi@kernel.org>
Cc: linux-pci@vger.kernel.org, ntb@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: [PATCH v5 0/5] PCI: endpoint: pci-epf-*ntb: Harden vNTB resource management
Date: Thu, 26 Feb 2026 17:41:37 +0900	[thread overview]
Message-ID: <20260226084142.2226875-1-den@valinux.co.jp> (raw)

The vNTB endpoint function (pci-epf-vntb) can be configured and
reconfigured through configfs (link/unlink functions, start/stop the
controller, update parameters). In practice, several pitfalls present:
duplicate EPC teardown that leads to oopses, a work item running after
resources were torn down, and inability to re-link/restart fundamentally
because ntb_dev was embedded and the vPCI bus teardown was incomplete.

This series addresses those issues and hardens resource management of
pci-epf-vntb:

- Remove duplicate EPC resource teardown in both pci-epf-vntb and
  pci-epf-ntb, avoiding crashes on .allow_link failures and during
  .drop_link.
- Stop the delayed cmd_handler work before clearing BARs/doorbells.
- Manage ntb_dev as a devm-managed allocation and implement .remove() in
  the vNTB PCI driver. Switch to pci_scan_root_bus().

With these changes, the controller can now be stopped, a function
unlinked, configfs settings updated, and the controller re-linked and
restarted without rebooting the endpoint, as long as the underlying
pci_epc_ops .stop() is non-destructive and .start() restores normal
operation.

Patches 1-3 carry Fixes tags and are candidates for stable.
Patch 4 is a preparatory one for Patch 5.
Patch 5 is a behavioral improvement that completes lifetime management for
relink/restart scenarios.

---
v4->v5 changes:
  - Rebased onto the latest pci/endpoint (2026-02-26).
  - Dropped [PATCH v4 1/7]; will be reposted separately via the NTB tree.
  - Dropped [PATCH v4 2/7], which has been applied in a different form.
  - Corrected the subject prefix of [PATCH v4 5/7]:
    s/NTB: epf: vntb:/PCI: endpoint: pci-epf-vntb:/.
  - Picked up a Reviewed-by tag to [PATCH v4 7/7].
  - Resolved a conflict in [PATCH v4 7/7] due to commit
    dc693d606644 ("PCI: endpoint: pci-epf-vntb: Add MSI doorbell support").
v3->v4 changes:
  - Added Reviewed-by tag for [PATCH v3 6/6].
  - Corrected patch split by moving the blank-line cleanup,
    based on the feedback from Frank.
  (No code changes overall.)
v2->v3 changes:
  - Added Reviewed-by tag for [PATCH v2 4/6].
  - Split [PATCH v2 6/6] into two, based on the feedback from Frank.
  (No code changes overall.)
v1->v2 changes:
  - Incorporated feedback from Frank.
  - Added Reviewed-by tags (except for patches #4 and #6).
  - Fixed a typo in patch #5 title.
  (No code changes overall.)

v4: https://lore.kernel.org/linux-pci/20251202072348.2752371-1-den@valinux.co.jp/
v3: https://lore.kernel.org/all/20251130151100.2591822-1-den@valinux.co.jp/
v2: https://lore.kernel.org/all/20251029080321.807943-1-den@valinux.co.jp/
v1: https://lore.kernel.org/all/20251023071757.901181-1-den@valinux.co.jp/


Koichiro Den (5):
  PCI: endpoint: pci-epf-vntb: Remove duplicate resource teardown
  PCI: endpoint: pci-epf-ntb: Remove duplicate resource teardown
  PCI: endpoint: pci-epf-vntb: Stop cmd_handler work in
    epf_ntb_epc_cleanup
  PCI: endpoint: pci-epf-vntb: Switch vpci_scan_bus() to use
    pci_scan_root_bus()
  PCI: endpoint: pci-epf-vntb: manage ntb_dev lifetime and fix vpci bus
    teardown

 drivers/pci/endpoint/functions/pci-epf-ntb.c  | 56 +-----------
 drivers/pci/endpoint/functions/pci-epf-vntb.c | 88 ++++++++++++-------
 2 files changed, 57 insertions(+), 87 deletions(-)

-- 
2.51.0


             reply	other threads:[~2026-02-26  8:42 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-26  8:41 Koichiro Den [this message]
2026-02-26  8:41 ` [PATCH v5 1/5] PCI: endpoint: pci-epf-vntb: Remove duplicate resource teardown Koichiro Den
2026-02-26  8:41 ` [PATCH v5 2/5] PCI: endpoint: pci-epf-ntb: " Koichiro Den
2026-02-26  8:41 ` [PATCH v5 3/5] PCI: endpoint: pci-epf-vntb: Stop cmd_handler work in epf_ntb_epc_cleanup Koichiro Den
2026-02-26  8:41 ` [PATCH v5 4/5] PCI: endpoint: pci-epf-vntb: Switch vpci_scan_bus() to use pci_scan_root_bus() Koichiro Den
2026-03-02 16:09   ` Manivannan Sadhasivam
2026-03-03  4:45     ` Koichiro Den
2026-02-26  8:41 ` [PATCH v5 5/5] PCI: endpoint: pci-epf-vntb: manage ntb_dev lifetime and fix vpci bus teardown Koichiro Den
2026-03-03  5:22   ` Manivannan Sadhasivam
2026-03-03 13:42     ` Koichiro Den
2026-03-04  3:10 ` [PATCH v5 0/5] PCI: endpoint: pci-epf-*ntb: Harden vNTB resource management Koichiro Den
2026-03-04  6:33   ` Manivannan Sadhasivam
2026-03-04  6:41 ` (subset) " Manivannan Sadhasivam
2026-03-04  8:43   ` Koichiro Den

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260226084142.2226875-1-den@valinux.co.jp \
    --to=den@valinux.co.jp \
    --cc=Frank.Li@nxp.com \
    --cc=allenbh@gmail.com \
    --cc=bhelgaas@google.com \
    --cc=dave.jiang@intel.com \
    --cc=geert+renesas@glider.be \
    --cc=jdmason@kudzu.us \
    --cc=kishon@kernel.org \
    --cc=kwilczynski@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=mani@kernel.org \
    --cc=ntb@lists.linux.dev \
    --cc=yebin10@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®