From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C6AD355F2A for ; Thu, 26 Feb 2026 17:58:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772128713; cv=none; b=usDn0FswmH9L/cy76QE79QQzZaK9a21Fsw5C8+J4u0zUUvVQqMESoSd76JjwcjaL4TYzob3BFAQGxzRZYrarkkchE9XSAgRDuX/vm3zDxz7PJySNjYh7dZeoO3lMYTI7LA78AF5SHPFSqNvvd0wwFRnVPSoVdLh7u3I7Ezxh12A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772128713; c=relaxed/simple; bh=YJLRMsLLh6RoXlQaUqAZ1rl6qsmJSmxpR2KNMW8P0t4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LwPo4z+AoCWrI1tbUTIbAX0lFlhzZd4P4G68IHOXBuux/N7JgdKReUodTu6TcXZ9DMTurHf6RCktF+6cqRneBSO9ArzF0+Jq1DAahnROZJqkOtXdzULBc+Gubr7E+xfkxiUD8Gq5Fafng1bSB0tS5uDWAO5q0rfQ/Mg1iBh/0Mg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HMZDFK1U; arc=none smtp.client-ip=209.85.215.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HMZDFK1U" Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-c6e734ba92bso538104a12.3 for ; Thu, 26 Feb 2026 09:58:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772128711; x=1772733511; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YJLRMsLLh6RoXlQaUqAZ1rl6qsmJSmxpR2KNMW8P0t4=; b=HMZDFK1UuDRkH7hWCTK+lSDAwGE2SVQJRubu0s14XIcs0lP54MQ3HSUS/XkQa/1Prn jqu52ab537rbLofstdEP1NngRppSar/oHnsrEVghWp/TD5Jlub+M+9DO595MG3wXFNpc hE5vIkRnMn6GsjMO+8tOfzuTRCeSScJUmXoghBpWaAG5ON8uNhQyRxDXFuQDZv1zaTQn wYoQl4Whqflmda+PmqlcO6n3wDg4n9Acmriy/jqfwcqOig40qAATEMzU+p5ZbfGsWxgh YLTK1iChsjRmb9RGUUT4NtH528FuBhS+QUOEIwSmvtVx8hZ+AP/TaPICh2SaTvAFnZDm Gp1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772128711; x=1772733511; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=YJLRMsLLh6RoXlQaUqAZ1rl6qsmJSmxpR2KNMW8P0t4=; b=mGWTh0xG0/CQgtuBd479jJlPtklebmfY3YrxZ27ArQ3eBoLjpVbdoxkeF6a0gXrnK0 kkJhFXiuvm+eeB1w1wRHZOXCnuEJnYXoJ75KIwgNKfTAs4R4qkKppQpKr2Wfr9r8detJ RzprKsoV4Sx5HGtmtsxg+FwTklFYEpB6XtmDtWSPctqjc3i16Yt71QfsUcAzGciufLYw tyMYE0cjxHDj6cKxNonc+/jQu1gNMSH5Y59Y6ypmpxXgmzAtbbu1DtBjlHFjXsITHOAN qhTBAJ0g6bFjZxsZy3+Hj8TtnGEo6hUZbinpp/YD5amR7T4RWLfmQMibCpJTyPKdhjoi NDQQ== X-Forwarded-Encrypted: i=1; AJvYcCWUkkNLdCJwlc9GEFRwswCY/TUBW+WMTHE2aZScU+zKLVqeM+0XyWZfBaM8SXMeh0ltKrbBO6S6nnMndqY=@vger.kernel.org X-Gm-Message-State: AOJu0Yygo3C7XDYoyVBz9oRB0aXnMPNc+uHGIvTzWctsqgKW9M2VAmrC rJ7WQwTSBNlM0wreBSl9RnLCUVupmCKKnliXUIQ7gI+AXogW1uu0Mdz/ X-Gm-Gg: ATEYQzwxECVLKihanUggCXZ+Zy9SM805Hi7K1qM8o8V6FKbZ60c44lMl4s8uq29vRWe AiSGu/OI9Z9m8IbdT+OTYe6nKDZ8UHI3ju1XF8aCuz9p8gzwt8Q11QGdolF65WFIVUo4EWzvJEN pnaF17g/Fkuv8tbDQJdOTD2CY27xGWzkfQRauDAR6DzDxDCb8zY/MyXDtUNSImwosvuRJHDkG2x hbcZj8dXRqQW8cflwmObZL371jTG4seFPpuLuOpKVjk4zhJVVl5ZKW3vBBtfyNs7ogEh5NbEdE+ knqisbaV6ia3ZxjbVX0FP9u3yPoCoAY2KYecqprXJyv2H2a2xFnzscICN2kIjFUwZyVkcoMs0qo TP3aE8EW22ZMsr7f2+bgUeGIquDK7jJQRdlY+Sus2ATraGW1tBRXhIv23HnEvOozkncQpm/A7KS jYCbnwclPWudTqKn37lY2w1+Np5vgWEwAjYK7PWHD5m0Vf X-Received: by 2002:a17:902:d2c2:b0:2a9:47ff:1020 with SMTP id d9443c01a7336-2ade9972102mr37058085ad.8.1772128711372; Thu, 26 Feb 2026 09:58:31 -0800 (PST) Received: from fedora ([2409:40e5:1160:7851:d9ac:d756:7e02:e043]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2adfb757a8dsm45547195ad.40.2026.02.26.09.58.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Feb 2026 09:58:30 -0800 (PST) From: Shubham Chakraborty To: dan.carpenter@linaro.org Cc: dtwlin@gmail.com, johan@kernel.org, elder@kernel.org, gregkh@linuxfoundation.org, greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] staging: greybus: uart: fix style issues Date: Thu, 26 Feb 2026 23:28:11 +0530 Message-ID: <20260226175811.17881-1-chakrabortyshubham66@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi Dan, Thanks for the review. You're right, the comments are too vague and don't add much value. I'll review what the locks actually protect and resend with more specific documentation, or drop the patch if it doesn't improve clarity. Thanks, Shubham