From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B35B36BCC8 for ; Thu, 26 Feb 2026 18:12:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772129576; cv=none; b=hnftEjm9UU25gjrBFxoCkOGiIHB0IFQ2ZemotW5cnTuOKpZ+hoz68hV2TJEhddolzTXAgx8PTChj4wL77WHofMct2p78J91GDbbx6y0/totSgu1jpXJLUUWdpg1Ujzk5q/g1nk6EopF4MTVaHBHef9tq1zSv1B2MwPWvdrYW/kA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772129576; c=relaxed/simple; bh=qd4htCK0khVMOChBbrnbti4dbvAOPxPrp95JVEVtiy4=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Y9INH0nknFs0Mov78uWDt+A6T1okqMUxmIrMrqUDVWdyV+6HIg6vo56hLnvSE6hGukqEu0xjZw/AIlJUSaTceKs4kOVvnXaOb4qNLdzdctNwLhj9zVSoa4Zn8GZ1LbMplgrV79Vnu07d9dNihC02+YWa4Wc9L0W1sz3svwmQVvQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Gzj8Wu3D; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Gzj8Wu3D" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-48371bb515eso15941315e9.1 for ; Thu, 26 Feb 2026 10:12:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772129574; x=1772734374; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=y2j0mCsqK2RFrAtvcYatwWJXN0hTJzKqIFFkj8FFAuA=; b=Gzj8Wu3DXatAaF6K2p57YiQz/dyT5lsr0/k6efGl3VZuVmClQDoKwgjj77yeroPlvs zGZ0GrzyiaT+htafCkOT+N5Br09iKDe/lhZRCg3PvAFtRSIzwjiqWGvoSWtIiV46TfiH G1P//mbBGUVHfQfPVnwLWH6yE3ITwTfuI7FepJINmWDjSq4/uyCuM2JwlRyLKWt/iN+l 2Rg24Ztvhf019/J6sivyM/nRCKegGiiLFK2FTd3RwklrE264mOIj+3p5gZlXJMyNdJ/0 pb+NdFuvj+G2Jk5PcajCjX7rmCMtFZixZpLz6SLfki1gU8NYfqw6rSYzdjnyaWlANEfv Ciqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772129574; x=1772734374; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=y2j0mCsqK2RFrAtvcYatwWJXN0hTJzKqIFFkj8FFAuA=; b=C485i8i3DlcpmbI7j85oD7sNT4HokVn92d54HuNeWOpg7WfksogLdEaTFK+MgRlT1P z0q197kt3j30rdeC4oCAkBnF3DnwjxAEn6WlEZ0r36b9FsWMqKrjU9ootaoR+Yt1WBzk EhWwvtr71nU+Ubhh65ieKxdEE6gz52Cnu13Q2u5To6BgL4UDN3aXrsbPgd2X3Y6hDFBV pQUifxoFP+wdyXfCd0q9b5rgrrWRV/hsJzxktn/UF2Eeev+9sMGfiAbd5A+XuUgwfDN4 o81GcTlyreINA67C3GWKbkvzXILTZ2ccGoJBMb+YqgNGQ/2jGx1LFJU0fcYIVj39Qbrc aJxQ== X-Forwarded-Encrypted: i=1; AJvYcCWzhgcTLsFpIcub+Fn02B/WWNPmyE7/glOb3C0FV2hxDLZjpEI5GKzYyrcn3ugBNY83r8n5Ps0aequWDAA=@vger.kernel.org X-Gm-Message-State: AOJu0YzMPHJoXKQCz/KVKf30yl5CssvYXEM7QJXJpT32/twnU5pxlhoU mSl7aMrOtq09IyiCkCF/ETdovp5DxWv2EWKnZ6/Ur0D82lPCGfLsxjD8 X-Gm-Gg: ATEYQzx+w+bXoxaf8NQ2B7v/IJ7ySiId7gH5VYxok2J0UXlagQ3w38eaeNueRRRO+l4 0X+03PU3P+/VdziVfwdc18wzXxBXl7eg9lIA+osWXOcVqnVlDeGYBo/z+RN5PbMVd+HHJ/WBiqr iNoaKTuk8Vqo7caC69Wlo7xYf8mE/PoJCmb09Lo+3qByRkS7s5Er4+0LO5tTccSNZp7+QldZ7gS 1re4rUUT/GZ/RmTLaX3w7s6axR5EaEyZP5M1ufwDs5P0fjrLvjQvh++fxzdhM+3NHCMTUln3bJ8 kWHAY+k7B8fqB2LJwgX5FEWaStsvFGTbBm4mwl/Zu0d9lalBW4h4965IPA605TDiuAqwwCfVhhR YGuraKkc1jsP8eC7hZV8DO3l64peeZljrDvUleRP/s6fY4U8PFMqHRT0p9k01D4Ifn/iQaEK21z /P+U51TySM/venJyvDHbzOfAx8D3A/h0YYsEmktjKHFElvow03sKEcDX5KXtI5LODWTrcoVaqwZ FQ= X-Received: by 2002:a05:600c:348f:b0:47e:e91d:73c0 with SMTP id 5b1f17b1804b1-483c3dd7806mr58474925e9.19.1772129573518; Thu, 26 Feb 2026 10:12:53 -0800 (PST) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483bfcb318fsm65498285e9.6.2026.02.26.10.12.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Feb 2026 10:12:53 -0800 (PST) Date: Thu, 26 Feb 2026 18:12:52 +0000 From: David Laight To: Mathieu Desnoyers Cc: Jeff Layton , Alexander Viro , Christian Brauner , Jan Kara , Steven Rostedt , Masami Hiramatsu , "Theodore Y. Ts'o" , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 02/61] vfs: change i_ino from unsigned long to u64 Message-ID: <20260226181252.252e68a6@pumpkin> In-Reply-To: <06c94e29-32d8-4753-a78c-8f5497680cf4@efficios.com> References: <20260226-iino-u64-v1-0-ccceff366db9@kernel.org> <20260226-iino-u64-v1-2-ccceff366db9@kernel.org> <06c94e29-32d8-4753-a78c-8f5497680cf4@efficios.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 26 Feb 2026 11:16:50 -0500 Mathieu Desnoyers wrote: > On 2026-02-26 10:55, Jeff Layton wrote: > > Change the type of i_ino in struct inode from unsigned long to u64. > > > > On 64-bit architectures, unsigned long is already 64 bits, so this is > > effectively a type alias change with no runtime impact. On 32-bit > > architectures, this widens i_ino from 32 to 64 bits, allowing > > filesystems like NFS, CIFS, XFS, Ceph, and FUSE to store their native > > 64-bit inode numbers without folding/hashing. > > > > The VFS already handles 64-bit inode numbers in kstat.ino (u64) and > > statx.stx_ino (__u64). The existing overflow checks in cp_new_stat(), > > cp_old_stat(), and cp_compat_stat() handle narrowing to 32-bit st_ino > > with -EOVERFLOW, so userspace ABI is preserved. > > > > struct inode will grow by 4 bytes on 32-bit architectures. > > Changing this type first without changing its associated format strings > breaks git bisect. Or find all the format strings, change to %llu and add (u64) casts. That should compile and run in both 32bit and 64bit. At the end you could delete the casts. David > > One alternative would be to introduce something like the PRIu64 macro > but for printing inode values. This would allow gradually introducing > the change without breaking the world as you do so. > > Thanks, > > Mathieu >