From: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
To: Rob Clark <robin.clark@oss.qualcomm.com>,
Dmitry Baryshkov <lumag@kernel.org>,
Abhinav Kumar <abhinav.kumar@linux.dev>,
Jessica Zhang <jesszhan0024@gmail.com>,
Sean Paul <sean@poorly.run>,
Marijn Suijten <marijn.suijten@somainline.org>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>
Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: [PATCH 4/7] drm/msm/dpu: drop VBIF id, base and name from the catalog
Date: Fri, 27 Feb 2026 20:36:43 +0200 [thread overview]
Message-ID: <20260227-drop-vbif-nrt-v1-4-2b97d0438182@oss.qualcomm.com> (raw)
In-Reply-To: <20260227-drop-vbif-nrt-v1-0-2b97d0438182@oss.qualcomm.com>
For all the platforms VBIF id is VBIF_RT, the name and base are also
fixed. Drop those fields from the catalog.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
---
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 15 +++++----------
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 5 ++---
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_vbif.c | 4 ++--
3 files changed, 9 insertions(+), 15 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
index 94c70b7b789e..35c75e11fe82 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
@@ -514,8 +514,7 @@ static const struct dpu_vbif_dynamic_ot_cfg msm8998_ot_rdwr_cfg[] = {
};
static const struct dpu_vbif_cfg msm8996_vbif = {
- .name = "vbif_rt", .id = VBIF_RT,
- .base = 0, .len = 0x1040,
+ .len = 0x1040,
.default_ot_rd_limit = 32,
.default_ot_wr_limit = 16,
.features = BIT(DPU_VBIF_QOS_REMAP) | BIT(DPU_VBIF_QOS_OTLIM),
@@ -540,8 +539,7 @@ static const struct dpu_vbif_cfg msm8996_vbif = {
};
static const struct dpu_vbif_cfg msm8998_vbif = {
- .name = "vbif_rt", .id = VBIF_RT,
- .base = 0, .len = 0x1040,
+ .len = 0x1040,
.default_ot_rd_limit = 32,
.default_ot_wr_limit = 32,
.features = BIT(DPU_VBIF_QOS_REMAP) | BIT(DPU_VBIF_QOS_OTLIM),
@@ -568,8 +566,7 @@ static const struct dpu_vbif_cfg msm8998_vbif = {
};
static const struct dpu_vbif_cfg sdm845_vbif = {
- .name = "vbif_rt", .id = VBIF_RT,
- .base = 0, .len = 0x1040,
+ .len = 0x1040,
.features = BIT(DPU_VBIF_QOS_REMAP),
.xin_halt_timeout = 0x4000,
.qos_rp_remap_size = 0x40,
@@ -586,8 +583,7 @@ static const struct dpu_vbif_cfg sdm845_vbif = {
};
static const struct dpu_vbif_cfg sm8550_vbif = {
- .name = "vbif_rt", .id = VBIF_RT,
- .base = 0, .len = 0x1040,
+ .len = 0x1040,
.features = BIT(DPU_VBIF_QOS_REMAP),
.xin_halt_timeout = 0x4000,
.qos_rp_remap_size = 0x40,
@@ -604,8 +600,7 @@ static const struct dpu_vbif_cfg sm8550_vbif = {
};
static const struct dpu_vbif_cfg sm8650_vbif = {
- .name = "vbif_rt", .id = VBIF_RT,
- .base = 0, .len = 0x1074,
+ .len = 0x1074,
.features = BIT(DPU_VBIF_QOS_REMAP),
.xin_halt_timeout = 0x4000,
.qos_rp_remap_size = 0x40,
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h
index fda4f3bdd797..38280d776c72 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h
@@ -587,8 +587,7 @@ struct dpu_vbif_qos_tbl {
/**
* struct dpu_vbif_cfg - information of VBIF blocks
- * @id enum identifying this block
- * @base register offset of this block
+ * @len: length of hardware block
* @features bit mask identifying sub-blocks/features
* @ot_rd_limit default OT read limit
* @ot_wr_limit default OT write limit
@@ -602,7 +601,7 @@ struct dpu_vbif_qos_tbl {
* @memtype array of xin memtype definitions
*/
struct dpu_vbif_cfg {
- DPU_HW_BLK_INFO;
+ u32 len;
unsigned long features;
u32 default_ot_rd_limit;
u32 default_ot_wr_limit;
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_vbif.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_vbif.c
index af76ad8a8103..de70d6b00972 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_vbif.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_vbif.c
@@ -230,13 +230,13 @@ struct dpu_hw_vbif *dpu_hw_vbif_init(struct drm_device *dev,
if (!c)
return ERR_PTR(-ENOMEM);
- c->hw.blk_addr = addr + cfg->base;
+ c->hw.blk_addr = addr;
c->hw.log_mask = DPU_DBG_MASK_VBIF;
/*
* Assign ops
*/
- c->idx = cfg->id;
+ c->idx = VBIF_RT;
c->cap = cfg;
_setup_vbif_ops(&c->ops, c->cap->features);
--
2.47.3
next prev parent reply other threads:[~2026-02-27 18:36 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-27 18:36 [PATCH 0/7] drm/msm/dpu: simplify VBIF handling Dmitry Baryshkov
2026-02-27 18:36 ` [PATCH 1/7] drm/msm/dpu: drop VBIF_NRT handling Dmitry Baryshkov
2026-03-02 12:37 ` Konrad Dybcio
2026-02-27 18:36 ` [PATCH 2/7] drm/msm/dpu: stop declaring VBIFs as an array in catalog Dmitry Baryshkov
2026-03-02 12:38 ` Konrad Dybcio
2026-02-27 18:36 ` [PATCH 3/7] drm/msm/dpu: replace VBIF-related array with bare pointers Dmitry Baryshkov
2026-03-02 12:40 ` Konrad Dybcio
2026-02-27 18:36 ` Dmitry Baryshkov [this message]
2026-03-02 12:41 ` [PATCH 4/7] drm/msm/dpu: drop VBIF id, base and name from the catalog Konrad Dybcio
2026-02-27 18:36 ` [PATCH 5/7] drm/msm/dpu: drop vbif_idx from WB configuration Dmitry Baryshkov
2026-03-02 12:42 ` Konrad Dybcio
2026-02-27 18:36 ` [PATCH 6/7] drm/msm/dpu: drop VBIF index from the VBIF params Dmitry Baryshkov
2026-03-02 12:43 ` Konrad Dybcio
2026-02-27 18:36 ` [PATCH 7/7] drm/msm/dpu: drop VBIF index from the struct dpu_hw_vbif Dmitry Baryshkov
2026-03-02 12:44 ` Konrad Dybcio
2026-03-02 11:58 ` [PATCH 0/7] drm/msm/dpu: simplify VBIF handling Konrad Dybcio
2026-03-02 12:33 ` Dmitry Baryshkov
2026-03-02 12:37 ` Konrad Dybcio
2026-03-02 12:45 ` Konrad Dybcio
2026-03-02 12:52 ` Dmitry Baryshkov
2026-03-27 19:47 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260227-drop-vbif-nrt-v1-4-2b97d0438182@oss.qualcomm.com \
--to=dmitry.baryshkov@oss.qualcomm.com \
--cc=abhinav.kumar@linux.dev \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jesszhan0024@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lumag@kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=robin.clark@oss.qualcomm.com \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®